Whamcloud - gitweb
LU-9727 mdd: properly call recording_changelog() 56/31456/2
authorSebastien Buisson <sbuisson@ddn.com>
Wed, 28 Feb 2018 16:18:32 +0000 (01:18 +0900)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 6 Mar 2018 19:13:41 +0000 (19:13 +0000)
recording_changelog() must be called everywhere in the code instead
of directly checking (mdd->mdd_cl.mc_flags & CLM_ON).

Signed-off-by: Sebastien Buisson <sbuisson@ddn.com>
Change-Id: I9ed5aac4871573e6aea94cfd4dc46b95d5df1e4a
Reviewed-on: https://review.whamcloud.com/31456
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Olaf Weber <olaf.weber@hpe.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/mdd/mdd_object.c

index 40760f0..7eb9950 100644 (file)
@@ -434,7 +434,7 @@ static int mdd_xattr_get(const struct lu_env *env,
                int rc2;
 
                /* Not recording */
                int rc2;
 
                /* Not recording */
-               if (!(mdd->mdd_cl.mc_flags & CLM_ON))
+               if (!recording_changelog(env, mdd))
                        RETURN(rc);
                if (!(mdd->mdd_cl.mc_mask & (1 << CL_GETXATTR)))
                        RETURN(rc);
                        RETURN(rc);
                if (!(mdd->mdd_cl.mc_mask & (1 << CL_GETXATTR)))
                        RETURN(rc);
@@ -960,7 +960,7 @@ static int mdd_changelog_data_store_xattr(const struct lu_env *env,
        LASSERT(handle != NULL);
 
        /* Not recording */
        LASSERT(handle != NULL);
 
        /* Not recording */
-       if (!(mdd->mdd_cl.mc_flags & CLM_ON))
+       if (!recording_changelog(env, mdd))
                RETURN(0);
        if ((mdd->mdd_cl.mc_mask & (1 << type)) == 0)
                RETURN(0);
                RETURN(0);
        if ((mdd->mdd_cl.mc_mask & (1 << type)) == 0)
                RETURN(0);
@@ -2900,7 +2900,7 @@ static int mdd_open(const struct lu_env *env, struct md_object *obj,
                mdd_obj->mod_count++;
 
        /* Not recording */
                mdd_obj->mod_count++;
 
        /* Not recording */
-       if (!(mdd->mdd_cl.mc_flags & CLM_ON))
+       if (!recording_changelog(env, mdd))
                GOTO(out, rc);
        if (!(mdd->mdd_cl.mc_mask & (1 << type)))
                GOTO(out, rc);
                GOTO(out, rc);
        if (!(mdd->mdd_cl.mc_mask & (1 << type)))
                GOTO(out, rc);