Whamcloud - gitweb
LU-11838 llite: remove assert for acl refcount 36/34236/3
authorJames Simmons <uja.ornl@yahoo.com>
Tue, 12 Feb 2019 23:59:19 +0000 (18:59 -0500)
committerOleg Drokin <green@whamcloud.com>
Wed, 27 Feb 2019 02:03:13 +0000 (02:03 +0000)
The purpose of this asssert to was to ensure lustre
was properly managing its posix_acl access. This test
is invalid due to the VFS layer also taking references
on the posix_acl. In reality their is no simple way to
detect this class of mistakes.

* lastest kernels remove this refcount *

Linux-commit: 6a42e615a28bad49f2e04829486e94190c066390

Change-Id: I167f2de449a2e8357517f33c2e81a25b25104d57
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: https://review.whamcloud.com/34236
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: Jenkins
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Ben Evans <bevans@cray.com>
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/llite/llite_lib.c

index 8dcabf6..9766890 100644 (file)
@@ -1501,7 +1501,6 @@ void ll_clear_inode(struct inode *inode)
 #ifdef CONFIG_FS_POSIX_ACL
        forget_all_cached_acls(inode);
        if (lli->lli_posix_acl) {
-               LASSERT(atomic_read(&lli->lli_posix_acl->a_refcount) == 1);
                posix_acl_release(lli->lli_posix_acl);
                lli->lli_posix_acl = NULL;
        }