Whamcloud - gitweb
LU-13153 lib: fix llapi_get_version_string 80/40680/3
authorMr NeilBrown <neilb@suse.de>
Wed, 18 Nov 2020 00:52:15 +0000 (11:52 +1100)
committerOleg Drokin <green@whamcloud.com>
Thu, 26 Nov 2020 09:27:14 +0000 (09:27 +0000)
llapi_get_version_string() has always been broken as it passes args to
get_lustre_param_value in the wrong order.

Test-Parameters: trivial
Fixes: 0c5fbd80f1ba ("LU-5969 lustreapi: replace llapi_get_version()")
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: Ib4bdd715295f97fe5b7080f42bfa06883f191234
Reviewed-on: https://review.whamcloud.com/40680
Reviewed-by: James Simmons <jsimmons@infradead.org>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
lustre/utils/liblustreapi_util.c

index c19674e..e8af531 100644 (file)
@@ -115,8 +115,8 @@ int llapi_get_version_string(char *version, unsigned int version_size)
                return -1;
        }
 
-       rc = get_lustre_param_value(NULL, NULL, FILTER_BY_NONE, buffer,
-                                   "version", sizeof(buffer));
+       rc = get_lustre_param_value(NULL, NULL, FILTER_BY_NONE, "version",
+                                   buffer, sizeof(buffer));
        if (rc < 0) {
                errno = -rc;
                return -1;