Whamcloud - gitweb
LU-3405 build: fix 'control flow' errors 66/6466/5
authorSebastien Buisson <sebastien.buisson@bull.net>
Mon, 27 May 2013 15:13:09 +0000 (17:13 +0200)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 26 Jul 2013 18:11:33 +0000 (18:11 +0000)
Fix 'control flow' issues found by Coverity version 6.5.1:
Logically dead code (DEADCODE)
Execution cannot reach this statement.
Missing break in switch (MISSING_BREAK)
This case is not terminated by a 'break' statement.
Stray semicolon (STRAY_SEMICOLON)
"if" statement with no "then" or "else" is suspicious.
Unsigned compared against 0 (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value
is always true.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: Ia737603bd9ef4dd6b01891b9b13edd59dec11891
Reviewed-on: http://review.whamcloud.com/6466
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/obdclass/obd_mount_server.c

index 9137219..ad35237 100644 (file)
@@ -985,13 +985,9 @@ static int server_stop_servers(int lsiflags)
        }
 
        if (obd != NULL && (type == NULL || type->typ_refcnt == 0)) {
        }
 
        if (obd != NULL && (type == NULL || type->typ_refcnt == 0)) {
-               int err;
-
                obd->obd_force = 1;
                /* obd_fail doesn't mean much on a server obd */
                obd->obd_force = 1;
                /* obd_fail doesn't mean much on a server obd */
-               err = class_manual_cleanup(obd);
-               if (rc != 0)
-                       rc = err;
+               rc = class_manual_cleanup(obd);
        }
 
        mutex_unlock(&server_start_lock);
        }
 
        mutex_unlock(&server_start_lock);