Whamcloud - gitweb
LU-9485 llite: check the return value of cl_file_inode_init() 58/27658/7
authorBobi Jam <bobijam.xu@intel.com>
Thu, 15 Jun 2017 08:01:13 +0000 (16:01 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 22 Jun 2017 02:55:11 +0000 (02:55 +0000)
ll_update_inode() does not check the return value of
cl_file_inode_init(), and it should check.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: I4174e4f8166d7834a1d619aa8d0191d1f428c62c
Reviewed-on: https://review.whamcloud.com/27658
Tested-by: Jenkins
Reviewed-by: Fan Yong <fan.yong@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/llite/llite_lib.c

index a1a8163..10fef55 100644 (file)
@@ -1830,13 +1830,15 @@ int ll_update_inode(struct inode *inode, struct lustre_md *md)
        struct ll_inode_info *lli = ll_i2info(inode);
        struct mdt_body *body = md->body;
        struct ll_sb_info *sbi = ll_i2sbi(inode);
+       int rc = 0;
 
-       if (body->mbo_valid & OBD_MD_FLEASIZE)
-               cl_file_inode_init(inode, md);
+       if (body->mbo_valid & OBD_MD_FLEASIZE) {
+               rc = cl_file_inode_init(inode, md);
+               if (rc)
+                       return rc;
+       }
 
        if (S_ISDIR(inode->i_mode)) {
-               int     rc;
-
                rc = ll_update_lsm_md(inode, md);
                if (rc != 0)
                        return rc;