Whamcloud - gitweb
LU-4629 gss: fix incorrect memset size 45/9345/2
authorDmitry Eremin <dmitry.eremin@intel.com>
Fri, 21 Feb 2014 13:55:55 +0000 (17:55 +0400)
committerOleg Drokin <oleg.drokin@intel.com>
Sat, 1 Mar 2014 02:25:35 +0000 (02:25 +0000)
Function 'memset' is called for 'sizeof' applied to pointer
instead of 'sizeof' applied to pointed type.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: Icd1583cb2de90617f6d96baa5d39d28c0d5167ae
Reviewed-on: http://review.whamcloud.com/9345
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/utils/gss/context_lucid.c

index bc303b2..3b2d90b 100644 (file)
@@ -210,7 +210,7 @@ extern void *krb5int_enc_aes256;
 static void
 key_lucid_to_krb5(const gss_krb5_lucid_key_t *lin, krb5_keyblock *kout)
 {
-       memset(kout, '\0', sizeof(kout));
+       memset(kout, 0, sizeof(*kout));
 #ifdef HAVE_KRB5
        kout->enctype = lin->type;
        kout->length = lin->length;
@@ -225,7 +225,7 @@ key_lucid_to_krb5(const gss_krb5_lucid_key_t *lin, krb5_keyblock *kout)
 static void
 key_krb5_to_lucid(const krb5_keyblock *kin, gss_krb5_lucid_key_t *lout)
 {
-       memset(lout, '\0', sizeof(lout));
+       memset(lout, 0, sizeof(*lout));
 #ifdef HAVE_KRB5
        lout->type = kin->enctype;
        lout->length = kin->length;