Whamcloud - gitweb
LU-6512 llite:ll_dir_ioctl cleanup of redundant comparisons 27/18027/7
authorParinay Kondekar <parinay.kondekar@seagate.com>
Mon, 18 Jan 2016 03:29:35 +0000 (08:59 +0530)
committerOleg Drokin <oleg.drokin@intel.com>
Mon, 2 May 2016 23:58:37 +0000 (23:58 +0000)
In ll_dir_ioctl() two identical comparisions are present for
return code (rc) of ll_dir_getstripe(). This patch removes
the other inside if( ) condition which is not necessary.

Change-Id: Ia32dd5ac5937d30dd3676094ef99a623e5cca608
Signed-off-by: Parinay Kondekar <parinay.kondekar@seagate.com>
Reviewed-on: http://review.whamcloud.com/18027
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Jenkins
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/llite/dir.c

index 4f28145..ec71a19 100644 (file)
@@ -1293,9 +1293,6 @@ lmv_out_free:
 
                /* Get default LMV EA */
                if (lum.lum_magic == LMV_USER_MAGIC) {
 
                /* Get default LMV EA */
                if (lum.lum_magic == LMV_USER_MAGIC) {
-                       if (rc != 0)
-                               GOTO(finish_req, rc);
-
                        if (lmmsize > sizeof(*ulmv))
                                GOTO(finish_req, rc = -EINVAL);
 
                        if (lmmsize > sizeof(*ulmv))
                                GOTO(finish_req, rc = -EINVAL);