b=10329

DESCRIPTION:
    When doing fcntl() file locking calls in a liblustre client via libsysio,
successful lock calls return random non-zero values due to use uninitialized
value as return value.

diff --git a/libsysio/src/fcntl.c b/libsysio/src/fcntl.c
index 68ce4de..22e0bcd 100644 (file)
--- a/libsysio/src/fcntl.c
+++ b/libsysio/src/fcntl.c
@@ -259,8 +259,7 @@ _sysio_vfcntl(int fd, int cmd, va_list ap)
 
                                fl64 = va_arg(ap, struct flock64 *);
                                err = _sysio_fcntl_lock(fil, cmd, fl64);
 
                                fl64 = va_arg(ap, struct flock64 *);
                                err = _sysio_fcntl_lock(fil, cmd, fl64);

-                               if (err)
-                                       rtn = -1;
+                               rtn = err ? -1 : 0;

                        }
                break;
 #endif
                        }
                break;
 #endif