Whamcloud - gitweb
LU-7623 lnet: remove useless cast 50/18950/9
authorJames Simmons <uja.ornl@yahoo.com>
Thu, 23 Jun 2016 17:38:13 +0000 (13:38 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 5 Jul 2016 23:47:31 +0000 (23:47 +0000)
In the cleanup of the user land / kernel pointers a
small cleanup was missed which removed a cast no
longer needed for a call of lnet_ping(). This brings
us into sync with the upstream client.

Change-Id: Ib281aaac7f2a1516d8586fbf3d10dee18cd77873
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: http://review.whamcloud.com/18950
Tested-by: Jenkins
Reviewed-by: Frank Zago <fzago@cray.com>
Reviewed-by: Christopher J. Morrone <morrone2@llnl.gov>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
libcfs/include/libcfs/libcfs_ioctl.h
lnet/lnet/api-ni.c

index f403e9b..990eda5 100644 (file)
@@ -74,9 +74,9 @@ struct libcfs_ioctl_data {
        char *ioc_inlbuf2;
 
        __u32 ioc_plen1; /* buffers in userspace */
-       char __user *ioc_pbuf1;
+       void __user *ioc_pbuf1;
        __u32 ioc_plen2; /* buffers in userspace */
-       char __user *ioc_pbuf2;
+       void __user *ioc_pbuf2;
 
        char ioc_bulk[0];
 };
index 99f5267..b7f297f 100644 (file)
@@ -2128,7 +2128,7 @@ LNetCtl(unsigned int cmd, void *arg)
                id.nid = data->ioc_nid;
                id.pid = data->ioc_u32[0];
                rc = lnet_ping(id, data->ioc_u32[1], /* timeout */
-                              (lnet_process_id_t __user *)data->ioc_pbuf1,
+                              data->ioc_pbuf1,
                               data->ioc_plen1/sizeof(lnet_process_id_t));
                if (rc < 0)
                        return rc;