Whamcloud - gitweb
LU-9073 gss: quiet insecure key file warning 01/25201/2
authorAndreas Dilger <andreas.dilger@intel.com>
Thu, 2 Feb 2017 05:55:15 +0000 (22:55 -0700)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 7 Feb 2017 06:19:28 +0000 (06:19 +0000)
Quiet spurious warning about insecure file access mode, because the
st_mode contains file type as well.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: If347eb3de67074269de4fe279ba4a849e03ebbe5
Reviewed-on: https://review.whamcloud.com/25201
Tested-by: Jenkins
Reviewed-by: Nathan Lavender <nblavend@iu.edu>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/utils/gss/sk_utils.c

index 8b7aecf..a0d71ac 100644 (file)
@@ -124,7 +124,7 @@ struct sk_keyfile_config *sk_read_file(char *filename)
                struct stat st;
 
                rc = fstat(fd, &st);
                struct stat st;
 
                rc = fstat(fd, &st);
-               if (rc == 0 && (st.st_mode & ~0600))
+               if (rc == 0 && (st.st_mode & ~(S_IFREG | 0600)))
                        fprintf(stderr, "warning: "
                                "secret key '%s' has insecure file mode %#o\n",
                                filename, st.st_mode);
                        fprintf(stderr, "warning: "
                                "secret key '%s' has insecure file mode %#o\n",
                                filename, st.st_mode);