Whamcloud - gitweb
LU-13088 ldlm: Fix sleeping function called in atomic 63/37063/2
authorMr NeilBrown <neilb@suse.de>
Thu, 19 Dec 2019 05:55:35 +0000 (16:55 +1100)
committerOleg Drokin <green@whamcloud.com>
Fri, 10 Jan 2020 07:42:36 +0000 (07:42 +0000)
target_recovery_overseer() can sleep while holding a spinlock, which
triggers a BUG warning.

It is easily fixed by dropping the spinlock before waiting.  In the
case where the task waits, no useful information that could be
protected by the spinlock is held, so nothing can be lost by dropping

Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: I8bb3d02523b5dcfadac19f01ccb736d7b7f28239
Reviewed-on: https://review.whamcloud.com/37063
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Mike Pershin <mpershin@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

index b70bd26..5ee714e 100644 (file)
@@ -2118,11 +2118,13 @@ repeat:
                         * yet, let's wait those threads stopped
                        if (next_update_transno == 0) {
+                               spin_unlock(&obd->obd_recovery_task_lock);
                                        == 0);
+                               spin_lock(&obd->obd_recovery_task_lock);
                                next_update_transno =