Whamcloud - gitweb
LU-4799 llite: Do not rate limit dirty page discard warning 52/9752/2
authorRyan Haasken <haasken@cray.com>
Fri, 21 Mar 2014 17:02:07 +0000 (12:02 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 4 Apr 2014 03:28:57 +0000 (03:28 +0000)
Messages which are printed by ll_dirty_page_discard_warn() should not
be rate limited.  If they are rate limited, some files which may be
corrupted on client eviction will not be reported to the user.

This patch changes the CWARN to a CDEBUG to disable console message
rate limiting for this message.  The dirty page discard warnings are
already limited on a per-file basis by the function vvp_vmpage_error
which calls ll_dirty_page_discard_warn only if the ccc_object's
cob_discard_page_warned == 0.

Signed-off-by: Ryan Haasken <haasken@cray.com>
Change-Id: Ia8a13c7add89c890014170254e462ae861de0fc5
Reviewed-on: http://review.whamcloud.com/9752
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Cory Spitz <spitzcor@cray.com>
Reviewed-by: Ann Koehler <amk@cray.com>
Reviewed-by: Chris Horn <hornc@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/llite/llite_lib.c

index 1acce03..4da09da 100644 (file)
@@ -2753,11 +2753,12 @@ void ll_dirty_page_discard_warn(struct page *page, int ioret)
                        path = ll_d_path(dentry, buf, PAGE_SIZE);
        }
 
-       CWARN("%s: dirty page discard: %s/fid: "DFID"/%s may get corrupted "
-             "(rc %d)\n", ll_get_fsname(page->mapping->host->i_sb, NULL, 0),
-             s2lsi(page->mapping->host->i_sb)->lsi_lmd->lmd_dev,
-             PFID(&obj->cob_header.coh_lu.loh_fid),
-             (path && !IS_ERR(path)) ? path : "", ioret);
+       CDEBUG(D_WARNING,
+              "%s: dirty page discard: %s/fid: "DFID"/%s may get corrupted "
+              "(rc %d)\n", ll_get_fsname(page->mapping->host->i_sb, NULL, 0),
+              s2lsi(page->mapping->host->i_sb)->lsi_lmd->lmd_dev,
+              PFID(&obj->cob_header.coh_lu.loh_fid),
+              (path && !IS_ERR(path)) ? path : "", ioret);
 
        if (dentry != NULL)
                dput(dentry);