Whamcloud - gitweb
LU-16249 sec: krb5_decrypt_bulk calls decryption primitive 07/48907/2
authorSebastien Buisson <sbuisson@ddn.com>
Tue, 18 Oct 2022 15:19:01 +0000 (17:19 +0200)
committerOleg Drokin <green@whamcloud.com>
Wed, 2 Nov 2022 07:11:47 +0000 (07:11 +0000)
krb5_decrypt_bulk() was mistakenly calling an encryption primitive
instead of a decryption primitive for the confounder.

Test-Parameters: trivial
Fixes: 0a65279121 ("LU-13344 gss: Update crypto to use sync_skcipher")
Signed-off-by: Sebastien Buisson <sbuisson@ddn.com>
Change-Id: I9251172644ed6baa3bb06a59dbe7c1bab401d817
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/48907
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Petros Koutoupis <petros.koutoupis@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/ptlrpc/gss/gss_krb5_mech.c

index a544e8b..d959249 100644 (file)
@@ -840,7 +840,7 @@ int krb5_decrypt_bulk(struct crypto_sync_skcipher *tfm,
        skcipher_request_set_crypt(req, sg_src.sgl, sg_dst.sgl,
                                   blocksize, local_iv);
 
-       rc = crypto_skcipher_encrypt_iv(req, sg_dst.sgl, sg_src.sgl, blocksize);
+       rc = crypto_skcipher_decrypt_iv(req, sg_dst.sgl, sg_src.sgl, blocksize);
 
        gss_teardown_sgtable(&sg_dst);
        gss_teardown_sgtable(&sg_src);