Whamcloud - gitweb
LU-12678 lnet: discard LNET_MD_PHYS 01/39301/2
authorMr NeilBrown <neilb@suse.de>
Mon, 6 Jul 2020 12:34:42 +0000 (08:34 -0400)
committerOleg Drokin <green@whamcloud.com>
Fri, 26 Feb 2021 22:12:05 +0000 (22:12 +0000)
This macro has no value and is never set.
It claims "compatibility with Cray Portals", yet cray-dvs
   git://github.com/glennklockwood/cray-dvs.git
does not use it in any non-trivial way.

Much has changed in lnet and lib-md since 2007 when this
value was added - it seems likely that this really
is dead.

So remove it.  If/when this results in problems, it can
easily be re-added and more details can be provided at
that time.

Test-Parameters: trivial testlist=sanity-lnet
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: Idef9389f4c0993adbdf088d0ccd9a0dc1449e86e
Reviewed-on: https://review.whamcloud.com/39301
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Alexey Lyashkov <alexey.lyashkov@hpe.com>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/include/uapi/linux/lnet/lnet-types.h
lustre/ptlrpc/pers.c

index f8be3e2..3b1698f 100644 (file)
@@ -355,9 +355,6 @@ struct lnet_md {
 /** See struct lnet_md::options. */
 #define LNET_MD_NO_TRACK_RESPONSE    (1 << 11)
 
 /** See struct lnet_md::options. */
 #define LNET_MD_NO_TRACK_RESPONSE    (1 << 11)
 
-/* For compatibility with Cray Portals */
-#define LNET_MD_PHYS                        0
-
 /** Infinite threshold on MD operations. See struct lnet_md::threshold */
 #define LNET_MD_THRESH_INF      (-1)
 
 /** Infinite threshold on MD operations. See struct lnet_md::threshold */
 #define LNET_MD_THRESH_INF      (-1)
 
index 14e11a6..1009fd5 100644 (file)
@@ -50,7 +50,6 @@ void ptlrpc_fill_bulk_md(struct lnet_md *md, struct ptlrpc_bulk_desc *desc,
 
        LASSERT(mdidx < desc->bd_md_max_brw);
        LASSERT(desc->bd_iov_count <= PTLRPC_MAX_BRW_PAGES);
 
        LASSERT(mdidx < desc->bd_md_max_brw);
        LASSERT(desc->bd_iov_count <= PTLRPC_MAX_BRW_PAGES);
-       LASSERT(!(md->options & (LNET_MD_KIOV | LNET_MD_PHYS)));
 
        /* just send a lnet header */
        if (mdidx >= desc->bd_md_count) {
 
        /* just send a lnet header */
        if (mdidx >= desc->bd_md_count) {