Whamcloud - gitweb
b=22847 separate format and content in ext[34]_warning()
authorBrian J. Murrell <brian@sun.com>
Tue, 25 May 2010 17:48:13 +0000 (13:48 -0400)
committerRobert Read <robert.read@oracle.com>
Tue, 25 May 2010 20:35:18 +0000 (13:35 -0700)
ext{3,4}_warning should not try to overload the message into the format
but should instead, pass a "%s" as the format and the string as an argument
for the %s.

i=panda
i=whitebear

ldiskfs/kernel_patches/patches/ext3-mmp-2.6-rhel4.patch
ldiskfs/kernel_patches/patches/ext3-mmp-2.6-sles10.patch
ldiskfs/kernel_patches/patches/ext3-mmp-2.6.18-vanilla.patch
ldiskfs/kernel_patches/patches/ext3-mmp-2.6.22-vanilla.patch
ldiskfs/kernel_patches/patches/ext4-mmp-rhel5.patch
ldiskfs/kernel_patches/patches/ext4-mmp-sles11.patch

index e7b8329..4428ba0 100644 (file)
@@ -92,7 +92,7 @@ Index: linux-2.6.9-67.0.22/fs/ext3/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext3_warning(sb, function, msg);
++      ext3_warning(sb, function, "%s", msg);
 +      ext3_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),
index c5c50ff..0a4f9db 100644 (file)
@@ -137,7 +137,7 @@ Index: linux-stage/fs/ext3/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext3_warning(sb, function, msg);
++      ext3_warning(sb, function, "%s", msg);
 +      ext3_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),
index 2f0654c..c608907 100644 (file)
@@ -137,7 +137,7 @@ Index: linux-stage/fs/ext3/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext3_warning(sb, function, msg);
++      ext3_warning(sb, function, "%s", msg);
 +      ext3_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),
index 527b928..12c90a0 100644 (file)
@@ -92,7 +92,7 @@ Index: linux-2.6.22.14/fs/ext3/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext3_warning(sb, function, msg);
++      ext3_warning(sb, function, "%s", msg);
 +      ext3_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),
index 22da428..201c450 100644 (file)
@@ -92,7 +92,7 @@ Index: linux-stage/fs/ext4/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext4_warning(sb, function, msg);
++      ext4_warning(sb, function, "%s", msg);
 +      ext4_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),
index 37923b2..756263d 100644 (file)
@@ -98,7 +98,7 @@ Index: linux-stage/fs/ext4/super.c
 +static void dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp,
 +                       const char *function, const char *msg)
 +{
-+      ext4_warning(sb, function, msg);
++      ext4_warning(sb, function, "%s", msg);
 +      ext4_warning(sb, function, "MMP failure info: last update time: %llu, "
 +                   "last update node: %s, last update device: %s\n",
 +                   (long long unsigned int)le64_to_cpu(mmp->mmp_time),