Whamcloud - gitweb
LU-4423 obdecho: bitwise vs logical typo 10/11410/3
authorOleg Drokin <oleg.drokin@intel.com>
Tue, 12 Aug 2014 12:34:23 +0000 (08:34 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 14 Aug 2014 15:44:42 +0000 (15:44 +0000)
Bitwise AND was intended here obviously.

From upstream kernel commit 96d4b0d5636b1810042eabedf766f35b548f1672

Change-Id: I5f05d14843910c2288c14c55e62615f030a7f445
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/11410
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
lustre/obdecho/echo.c

index 5ece81d..122eb70 100644 (file)
@@ -127,10 +127,10 @@ static int echo_create(const struct lu_env *env, struct obd_export *exp,
                 return -EINVAL;
         }
 
-        if (!(oa->o_mode && S_IFMT)) {
-                CERROR("echo obd: no type!\n");
-                return -ENOENT;
-        }
+       if (!(oa->o_mode & S_IFMT)) {
+               CERROR("echo obd: no type!\n");
+               return -ENOENT;
+       }
 
         if (!(oa->o_valid & OBD_MD_FLTYPE)) {
                 CERROR("invalid o_valid "LPX64"\n", oa->o_valid);