summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
f0137d8)
Don't return "rc" when it is known that this will always be "0".
This confuses the reader into thinking that this is an error path
when it is in fact a no-op shortcut that returns success.
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Ie4571226b3e90c866b958cf6ab65f6077abcab07
Reviewed-on: http://review.whamcloud.com/12727
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
{
struct lu_seq_range range = { 0 };
struct lu_server_fld *server_fld;
{
struct lu_seq_range range = { 0 };
struct lu_server_fld *server_fld;
ENTRY;
if (!fid_is_sane(fid)) {
ENTRY;
if (!fid_is_sane(fid)) {
if (fid_is_idif(fid)) {
*tgt = fid_idif_ost_idx(fid);
*type = LU_SEQ_RANGE_OST;
if (fid_is_idif(fid)) {
*tgt = fid_idif_ost_idx(fid);
*type = LU_SEQ_RANGE_OST;
}
if (!lod->lod_initialized || (!fid_seq_in_fldb(fid_seq(fid)))) {
}
if (!lod->lod_initialized || (!fid_seq_in_fldb(fid_seq(fid)))) {
*tgt = lu_site2seq(lod2lu_dev(lod)->ld_site)->ss_node_id;
*type = LU_SEQ_RANGE_MDT;
*tgt = lu_site2seq(lod2lu_dev(lod)->ld_site)->ss_node_id;
*type = LU_SEQ_RANGE_MDT;
}
server_fld = lu_site2seq(lod2lu_dev(lod)->ld_site)->ss_server_fld;
fld_range_set_type(&range, *type);
rc = fld_server_lookup(env, server_fld, fid_seq(fid), &range);
}
server_fld = lu_site2seq(lod2lu_dev(lod)->ld_site)->ss_server_fld;
fld_range_set_type(&range, *type);
rc = fld_server_lookup(env, server_fld, fid_seq(fid), &range);
RETURN(rc);
*tgt = range.lsr_index;
*type = range.lsr_flags;
RETURN(rc);
*tgt = range.lsr_index;
*type = range.lsr_flags;
- CDEBUG(D_INFO, "LOD: got tgt %x for sequence: "
- LPX64"\n", *tgt, fid_seq(fid));
+ CDEBUG(D_INFO, "%s: got tgt %x for sequence: "LPX64"\n",
+ lod2obd(lod)->obd_name, *tgt, fid_seq(fid));
}
extern struct lu_object_operations lod_lu_obj_ops;
}
extern struct lu_object_operations lod_lu_obj_ops;