Whamcloud - gitweb
LU-8058 lnet: Remove old commented out code 14/20414/4
authorBen Evans <bevans@cray.com>
Tue, 14 Jun 2016 18:15:34 +0000 (14:15 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Wed, 22 Jun 2016 02:55:35 +0000 (02:55 +0000)
These #if 0 blocks have been in place for years. Assume
they are not used and remove them

Signed-off-by: Ben Evans <bevans@cray.com>
Change-Id: I3840513cc68786ded878ba8be6b92f0a180507a2
Reviewed-on: http://review.whamcloud.com/20414
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lnet/klnds/socklnd/socklnd.c
lnet/klnds/socklnd/socklnd_cb.c
lnet/lnet/lib-msg.c

index 5530b7a..e7f9071 100644 (file)
@@ -1439,11 +1439,6 @@ ksocknal_close_conn_locked (ksock_conn_t *conn, int error)
 
                conn->ksnc_route = NULL;
 
-#if 0          /* irrelevent with only eager routes */
-               /* make route least favourite */
-               list_del(&route->ksnr_list);
-               list_add_tail(&route->ksnr_list, &peer->ksnp_routes);
-#endif
                ksocknal_route_decref(route);   /* drop conn's ref on route */
        }
 
index ee29f8a..77dde23 100644 (file)
@@ -1987,13 +1987,6 @@ ksocknal_connect (ksock_route_t *route)
                list_splice_init(&peer->ksnp_tx_queue, &zombies);
         }
 
-#if 0           /* irrelevent with only eager routes */
-        if (!route->ksnr_deleted) {
-                /* make this route least-favourite for re-selection */
-               list_del(&route->ksnr_list);
-               list_add_tail(&route->ksnr_list, &peer->ksnp_routes);
-        }
-#endif
        write_unlock_bh(&ksocknal_data.ksnd_global_lock);
 
         ksocknal_peer_failed(peer);
index 82c625e..d21a1d6 100644 (file)
@@ -447,23 +447,7 @@ lnet_finalize(lnet_ni_t *ni, lnet_msg_t *msg, int status)
 
        if (msg == NULL)
                return;
-#if 0
-        CDEBUG(D_WARNING, "%s msg->%s Flags:%s%s%s%s%s%s%s%s%s%s%s txp %s rxp %s\n",
-               lnet_msgtyp2str(msg->msg_type), libcfs_id2str(msg->msg_target),
-               msg->msg_target_is_router ? "t" : "",
-               msg->msg_routing ? "X" : "",
-               msg->msg_ack ? "A" : "",
-               msg->msg_sending ? "S" : "",
-               msg->msg_receiving ? "R" : "",
-               msg->msg_delayed ? "d" : "",
-               msg->msg_txcredit ? "C" : "",
-               msg->msg_peertxcredit ? "c" : "",
-               msg->msg_rtrcredit ? "F" : "",
-               msg->msg_peerrtrcredit ? "f" : "",
-               msg->msg_onactivelist ? "!" : "",
-               msg->msg_txpeer == NULL ? "<none>" : libcfs_nid2str(msg->msg_txpeer->lp_nid),
-               msg->msg_rxpeer == NULL ? "<none>" : libcfs_nid2str(msg->msg_rxpeer->lp_nid));
-#endif
+
         msg->msg_ev.status = status;
 
        if (msg->msg_md != NULL) {