Whamcloud - gitweb
b=22310 add a little more comment.
authorEric Mei <eric.mei@oracle.com>
Fri, 23 Apr 2010 18:48:07 +0000 (12:48 -0600)
committerRobert Read <robert.read@oracle.com>
Sun, 25 Apr 2010 02:23:00 +0000 (19:23 -0700)
r=adilger

lustre/llite/rw.c

index df40ae6..1884c01 100644 (file)
@@ -747,7 +747,14 @@ int ll_readahead(const struct lu_env *env, struct cl_io *io,
         }
         if (end != 0) {
                 unsigned long tmp_end;
-                /* Align RA window to optimal RPC boundary */
+                /*
+                 * Align RA window to an optimal boundary.
+                 *
+                 * XXX This would be better to align to cl_max_pages_per_rpc
+                 * instead of PTLRPC_MAX_BRW_PAGES, because the RPC size may
+                 * be aligned to the RAID stripe size in the future and that
+                 * is more important than the RPC size.
+                 */
                 tmp_end = ((end + 1) & (~(PTLRPC_MAX_BRW_PAGES - 1))) - 1;
                 if (tmp_end > start)
                         end = tmp_end;