Whamcloud - gitweb
LU-13273 tests: run_ior() parameters order fix 51/37651/3
authorElena Gryaznova <elena.gryaznova@hpe.com>
Thu, 20 Feb 2020 18:22:55 +0000 (21:22 +0300)
committerOleg Drokin <green@whamcloud.com>
Tue, 17 Mar 2020 03:40:45 +0000 (03:40 +0000)
IOR requires particular options to be specified
before script file option. Otherwise those options
make no effect.

After script file processing any options which
change initialTestParams values have no effect
because test set is already created based on
initialTestParams initialized and modified with
preceding options.

To have initialTestParams->testFileName equal to
<testFile> the parameters order should be:
   -o <testFile> -f <scriptFile>
With the order
   -f <scriptFile> -o <testFile>
initialTestParams->testFileName is equal to default
value "testFile" set in init_IOR_Param_t.

Fixes: 2d7419478e79 (LU-11078 tests: customise run_ior())
Test-Parameters: trivial
Test-Parameters: testlist=parallel-scale envdefinitions=ONLY=iorssf
Cray-bug-id: LUS-7734
Signed-off-by: Elena Gryaznova <elena.gryaznova@hpe.com>
Reviewed-by: Vladimir Saveliev <vladimir.saveliev@hpe.com>
Reviewed-by: Vitaly Fertman <vitaly.fertman@hpe.com>
Change-Id: I16a797466355c69e655259aaf8d9a3ae69d4a31d
Reviewed-on: https://review.whamcloud.com/37651
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Vladimir Saveliev <c17830@cray.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

index 50ff899..4df176a 100644 (file)
@@ -645,7 +645,7 @@ run_ior() {
        local cmd
        if [ -n "$ior_custom_params" ]; then
-               cmd="$IOR $ior_custom_params -o $testdir/iorData"
+               cmd="$IOR -o $testdir/iorData $ior_custom_params"
                cmd="$IOR -a $ior_type -b ${ior_blockSize}${ior_blockUnit} \
                -o $testdir/iorData -t $ior_xferSize -v -C -w -r -W \