Whamcloud - gitweb
LU-6142 fld: remove function typedefs 40/37740/3
authorMr NeilBrown <neilb@suse.de>
Thu, 27 Feb 2020 02:59:27 +0000 (13:59 +1100)
committerOleg Drokin <green@whamcloud.com>
Tue, 24 Mar 2020 05:16:05 +0000 (05:16 +0000)
typedefs a generally discouraged in upstream linux.
fld_hash_func_t and fld_scan_func_t are only used
once immediately after the definition, so having them
doesn't help readability or maintainability at all.

So remove them.

Test-Parameters: trivial
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: I37288238f375d5673b7cb8d68d30102f43e44107
Reviewed-on: https://review.whamcloud.com/37740
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/fld/fld_internal.h

index 9579cfe..b8e9590 100644 (file)
@@ -64,15 +64,12 @@ struct fld_stats {
         __u64   fst_cache;
 };
 
         __u64   fst_cache;
 };
 
-typedef int (*fld_hash_func_t) (struct lu_client_fld *, __u64);
-
-typedef struct lu_fld_target *
-(*fld_scan_func_t) (struct lu_client_fld *, __u64);
-
 struct lu_fld_hash {
 struct lu_fld_hash {
-        const char              *fh_name;
-        fld_hash_func_t          fh_hash_func;
-        fld_scan_func_t          fh_scan_func;
+       const char              *fh_name;
+       int                     (*fh_hash_func)(struct lu_client_fld *fld,
+                                               __u64 seq);
+       struct lu_fld_target *  (*fh_scan_func)(struct lu_client_fld *fld,
+                                               __u64 seq);
 };
 
 struct fld_cache_entry {
 };
 
 struct fld_cache_entry {