Whamcloud - gitweb
LU-532 mdt: improve xattr ctime warning message
authorAndreas Dilger <adilger@whamcloud.com>
Thu, 28 Jul 2011 22:13:53 +0000 (16:13 -0600)
committerOleg Drokin <green@whamcloud.com>
Tue, 1 Nov 2011 03:34:41 +0000 (23:34 -0400)
Print out which xattr is not getting OBD_MD_FLCTIME set so that it
is possible to track down what code path on the client is failing.

Change-Id: I1918d2e8e0a1e03d8437846e823bca9df6f89b48
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-on: http://review.whamcloud.com/1161
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Bobi Jam <bobijam@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/mdt/mdt_xattr.c

index 6cfb1e2..f3b5537 100644 (file)
@@ -369,8 +369,11 @@ int mdt_reint_setxattr(struct mdt_thread_info *info,
                 GOTO(out_unlock, rc);
 
         if (unlikely(!(valid & OBD_MD_FLCTIME))) {
-                CWARN("client miss to set OBD_MD_FLCTIME when "
-                      "setxattr: [object "DFID"] [valid "LPU64"]\n",
+                /* This isn't strictly an error, but all current clients
+                 * should set OBD_MD_FLCTIME when setting attributes. */
+                CWARN("%s: client miss to set OBD_MD_FLCTIME when "
+                      "setxattr %s: [object "DFID"] [valid "LPU64"]\n",
+                      info->mti_exp->exp_obd->obd_name, xattr_name,
                       PFID(rr->rr_fid1), valid);
                 attr->la_ctime = cfs_time_current_sec();
         }