Whamcloud - gitweb
LU-6557 llite: remove unused ll_max_rw_chunk 57/14657/2
authorOleg Drokin <oleg.drokin@intel.com>
Mon, 4 May 2015 02:17:43 +0000 (22:17 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Wed, 20 May 2015 17:38:02 +0000 (17:38 +0000)
ll_max_rw_chunk seems to be unused ever since we implemented CLIO in 2.0,
so remove it and all supporting infrastructure.

Change-Id: Ie4d4142c3b70aa4fa757770b03b220de2253a681
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/14657
Tested-by: Jenkins
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
lustre/llite/llite_internal.h
lustre/llite/llite_lib.c
lustre/llite/lproc_llite.c

index 910e968..c839528 100644 (file)
@@ -521,9 +521,6 @@ struct ll_sb_info {
         unsigned int              ll_namelen;
         struct file_operations   *ll_fop;
 
         unsigned int              ll_namelen;
         struct file_operations   *ll_fop;
 
-        /* =0 - hold lock over whole read/write
-         * >0 - max. chunk to be read/written w/o lock re-acquiring */
-        unsigned long             ll_max_rw_chunk;
        unsigned int              ll_md_brw_pages; /* readdir pages per RPC */
 
         struct lu_site           *ll_site;
        unsigned int              ll_md_brw_pages; /* readdir pages per RPC */
 
         struct lu_site           *ll_site;
@@ -558,8 +555,6 @@ struct ll_sb_info {
        struct root_squash_info   ll_squash;
 };
 
        struct root_squash_info   ll_squash;
 };
 
-#define LL_DEFAULT_MAX_RW_CHUNK      (32 * 1024 * 1024)
-
 /*
  * per file-descriptor read-ahead data.
  */
 /*
  * per file-descriptor read-ahead data.
  */
index 42a5f6c..381fdc4 100644 (file)
@@ -334,7 +334,6 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
         sb->s_magic = LL_SUPER_MAGIC;
         sb->s_maxbytes = MAX_LFS_FILESIZE;
         sbi->ll_namelen = osfs->os_namelen;
         sb->s_magic = LL_SUPER_MAGIC;
         sb->s_maxbytes = MAX_LFS_FILESIZE;
         sbi->ll_namelen = osfs->os_namelen;
-        sbi->ll_max_rw_chunk = LL_DEFAULT_MAX_RW_CHUNK;
 
         if ((sbi->ll_flags & LL_SBI_USER_XATTR) &&
             !(data->ocd_connect_flags & OBD_CONNECT_XATTR)) {
 
         if ((sbi->ll_flags & LL_SBI_USER_XATTR) &&
             !(data->ocd_connect_flags & OBD_CONNECT_XATTR)) {
index 1e3739b..7e84cfe 100644 (file)
@@ -570,29 +570,6 @@ static ssize_t ll_checksum_seq_write(struct file *file,
 }
 LPROC_SEQ_FOPS(ll_checksum);
 
 }
 LPROC_SEQ_FOPS(ll_checksum);
 
-static int ll_max_rw_chunk_seq_show(struct seq_file *m, void *v)
-{
-       struct super_block *sb = m->private;
-
-       return seq_printf(m, "%lu\n", ll_s2sbi(sb)->ll_max_rw_chunk);
-}
-
-static ssize_t ll_max_rw_chunk_seq_write(struct file *file,
-                                        const char __user *buffer,
-                                        size_t count, loff_t *off)
-{
-       struct seq_file *m = file->private_data;
-       struct super_block *sb = m->private;
-        int rc, val;
-
-        rc = lprocfs_write_helper(buffer, count, &val);
-        if (rc)
-                return rc;
-        ll_s2sbi(sb)->ll_max_rw_chunk = val;
-        return count;
-}
-LPROC_SEQ_FOPS(ll_max_rw_chunk);
-
 static int ll_rd_track_id(struct seq_file *m, enum stats_track_type type)
 {
        struct super_block *sb = m->private;
 static int ll_rd_track_id(struct seq_file *m, enum stats_track_type type)
 {
        struct super_block *sb = m->private;
@@ -1023,8 +1000,6 @@ struct lprocfs_vars lprocfs_llite_obd_vars[] = {
          .fops =       &ll_max_cached_mb_fops                  },
        { .name =       "checksum_pages",
          .fops =       &ll_checksum_fops                       },
          .fops =       &ll_max_cached_mb_fops                  },
        { .name =       "checksum_pages",
          .fops =       &ll_checksum_fops                       },
-       { .name =       "max_rw_chunk",
-         .fops =       &ll_max_rw_chunk_fops                   },
        { .name =       "stats_track_pid",
          .fops =       &ll_track_pid_fops                      },
        { .name =       "stats_track_ppid",
        { .name =       "stats_track_pid",
          .fops =       &ll_track_pid_fops                      },
        { .name =       "stats_track_ppid",