Whamcloud - gitweb
LU-16346 utils: fix lctl stack smashing 54/49254/4
authorArtem Blagodarenko <ablagodarenko@ddn.com>
Fri, 25 Nov 2022 12:01:06 +0000 (12:01 +0000)
committerOleg Drokin <green@whamcloud.com>
Tue, 13 Dec 2022 16:09:23 +0000 (16:09 +0000)
on aarch64 architecture:
... 
exec lustre/utils/.libs/lctl dl
*** stack smashing detected ***: terminated
Aborted (core dumped)

genlmsg_parse() was misused in yaml_netlink_msg_parse().
It requires passing maxtype+1 elements, but maxtype+1 as a number
of elements passed actually. Should be maxtype actually.

Signed-off-by: Artem Blagodarenko <ablagodarenko@ddn.com>
Change-Id: Ic9cd0de35a028ca28bdd112700296d21e04a1cc5
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49254
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
lnet/utils/lnetconfig/liblnetconfig_netlink.c

index aac8a16..65bea40 100644 (file)
@@ -761,7 +761,7 @@ static int yaml_netlink_msg_parse(struct nl_msg *msg, void *arg)
                struct genlmsghdr *ghdr = genlmsg_hdr(nlh);
                struct nlattr *attrs[LN_SCALAR_MAX + 1];
 
-               if (genlmsg_parse(nlh, 0, attrs, LN_SCALAR_MAX + 1,
+               if (genlmsg_parse(nlh, 0, attrs, LN_SCALAR_MAX,
                                  scalar_attr_policy))
                        return NL_SKIP;