Whamcloud - gitweb
LU-3086 build: fix 'uninitialized variables' errors
authorSebastien Buisson <sebastien.buisson@bull.net>
Tue, 2 Apr 2013 12:14:18 +0000 (14:14 +0200)
committerOleg Drokin <oleg.drokin@intel.com>
Wed, 1 May 2013 06:25:30 +0000 (02:25 -0400)
Fix 'uninitialized variables' defects found by Coverity version 6.5.1:
Uninitialized scalar variable (UNINIT)
Using uninitialized value.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: I8df7c60823e392b37880ca5ddb1ea107554784e6
Reviewed-on: http://review.whamcloud.com/5916
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: John Hammond <johnlockwoodhammond@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/mdt/mdt_open.c
lustre/obdclass/cl_page.c
lustre/osc/osc_request.c
lustre/osd-ldiskfs/osd_quota.c

index 3359d5e..456f403 100644 (file)
@@ -1276,7 +1276,7 @@ int mdt_open_by_fid_lock(struct mdt_thread_info *info, struct ldlm_reply *rep,
         struct mdt_object       *parent= NULL;
         struct mdt_object       *o;
         int                      rc;
-       __u64                    ibits;
+       __u64                    ibits = 0;
         ENTRY;
 
        if (md_should_create(flags) && !(flags & MDS_OPEN_HAS_EA)) {
index a9d8146..da98d9f 100644 (file)
@@ -325,7 +325,7 @@ static struct cl_page *cl_page_alloc(const struct lu_env *env,
        OBD_ALLOC_GFP(page, cl_object_header(o)->coh_page_bufsize,
                        CFS_ALLOC_IO);
        if (page != NULL) {
-               int result;
+               int result = 0;
                cfs_atomic_set(&page->cp_ref, 1);
                if (type == CPT_CACHEABLE) /* for radix tree */
                        cfs_atomic_inc(&page->cp_ref);
index 881ab54..4092d93 100644 (file)
@@ -1214,8 +1214,8 @@ static obd_count osc_checksum_bulk(int nob, obd_count pg_count,
                cfs_crypto_hash_update_page(hdesc, pga[i]->pg,
                                  pga[i]->off & ~CFS_PAGE_MASK,
                                  count);
-               LL_CDEBUG_PAGE(D_PAGE, pga[i]->pg, "off %d checksum %x\n",
-                              (int)(pga[i]->off & ~CFS_PAGE_MASK), cksum);
+               LL_CDEBUG_PAGE(D_PAGE, pga[i]->pg, "off %d\n",
+                              (int)(pga[i]->off & ~CFS_PAGE_MASK));
 
                nob -= pga[i]->count;
                pg_count--;
index 39059f0..f85bef7 100644 (file)
@@ -968,7 +968,7 @@ int osd_quota_migration(const struct lu_env *env, struct dt_object *dt,
        struct dt_object        *root, *parent = NULL, *admin = NULL;
        dt_obj_version_t         version;
        char                    *fname;
-       bool                     isblk, converted = false;
+       bool                     isblk = false, converted = false;
        int                      rc;
        ENTRY;