Whamcloud - gitweb
LU-14553 changelog: eliminate mdd_changelog_clear warning 55/43555/2
authorOlaf Faaland <faaland1@llnl.gov>
Thu, 25 Mar 2021 01:35:10 +0000 (18:35 -0700)
committerOleg Drokin <green@whamcloud.com>
Sat, 29 May 2021 00:12:14 +0000 (00:12 +0000)
When handling a changelog_clear request, the user may specify a
range of indices which do not exist.  Similarly, the user may
specify a changelog user which does not exist.  Neither indicates
a problem within Lustre that justifies a a console warning.

Change those cases to CDEBUG.

Lustre-change: https://review.whamcloud.com/43125
Lustre-commit: 6b183927e19715d093c80a35ebc42a1cda5e70e2

Test-Parameters: trivial
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Change-Id: I64bab12ef4978c4bf7139f5f36a39f9b109616fb
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Signed-off-by: Minh Diep <mdiep@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/43555
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/mdd/mdd_device.c

index 622d9d5..faf548d 100644 (file)
@@ -1806,7 +1806,11 @@ static int mdd_changelog_clear(const struct lu_env *env,
                              mdd_changelog_clear_cb, (void *)&mcuc,
                              0, 0);
 
-       if (rc < 0) {
+       if (rc == -EINVAL) {
+               CDEBUG(D_IOCTL, "%s: No changelog recnum <= %llu to clear\n",
+                      mdd2obd_dev(mdd)->obd_name, (unsigned long long) endrec);
+               RETURN(-EINVAL);
+       } else if (rc < 0) {
                CWARN("%s: Failure to clear the changelog for user %d: %d\n",
                      mdd2obd_dev(mdd)->obd_name, id, rc);
        } else if (mcuc.mcuc_flush) {
@@ -1821,7 +1825,7 @@ static int mdd_changelog_clear(const struct lu_env *env,
                                                      mcuc.mcuc_minrec);
                }
        } else {
-               CWARN("%s: No entry for user %d\n",
+               CDEBUG(D_IOCTL, "%s: No entry for user %d\n",
                      mdd2obd_dev(mdd)->obd_name, id);
                rc = -ENOENT;
        }