Whamcloud - gitweb
LU-14093 lnet: annotate LNET_WIRE_HANDLE_COOKIE_NONE as u64 13/43713/6
authorDominique Martinet <asmadeus@codewreck.org>
Sat, 15 May 2021 22:32:56 +0000 (07:32 +0900)
committerOleg Drokin <green@whamcloud.com>
Thu, 8 Jul 2021 02:06:04 +0000 (02:06 +0000)
Fix the following warning on new gcc with -Wextra when including
lustre_idl.h on external project:

.../include/linux/lnet/lnet-types.h: In function LNetMDHandleIsInvalid:
.../include/linux/lnet/lnet-types.h:355:46:
   error: comparison of integer expressions of different signedness:
   int and __u64 {aka long long unsigned int} [-Werror=sign-compare]
        return (LNET_WIRE_HANDLE_COOKIE_NONE == h.cookie);
                                             ^~

Change-Id: I05f21dcca5fe9dd15d1e0b6cb9a29c3999bcd807
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Reviewed-on: https://review.whamcloud.com/43713
Reviewed-by: Neil Brown <neilb@suse.de>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lnet/include/uapi/linux/lnet/lnet-types.h

index d40fb9e..69dc893 100644 (file)
@@ -135,7 +135,7 @@ struct lnet_counters {
  * 'me' for match entry). Each type of object is given a unique handle type
  * to enhance type checking.
  */
  * 'me' for match entry). Each type of object is given a unique handle type
  * to enhance type checking.
  */
-#define LNET_WIRE_HANDLE_COOKIE_NONE   (-1)
+#define LNET_WIRE_HANDLE_COOKIE_NONE   (~0ULL)
 
 struct lnet_handle_md {
        __u64   cookie;
 
 struct lnet_handle_md {
        __u64   cookie;