Whamcloud - gitweb
LU-6822 nrs: remove obsolete assertion in nrs_orr_start() 40/15540/2
authorEmoly Liu <emoly.liu@intel.com>
Thu, 9 Jul 2015 08:13:39 +0000 (16:13 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 21 Jul 2015 17:43:58 +0000 (17:43 +0000)
kmem_cache_destroy() doesn't return any value, so we should remove
this obsolete assertion, otherwise LBUG will happen when orr policy
is enabled.

Signed-off-by: Emoly Liu <emoly.liu@intel.com>
Change-Id: I240e7bd660a6960b1e29da3575388a966ce8dca9
Reviewed-on: http://review.whamcloud.com/15540
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Hongchao Zhang <hongchao.zhang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/ptlrpc/nrs_orr.c

index 3a949a4..97be950 100644 (file)
@@ -693,10 +693,8 @@ static int nrs_orr_start(struct ptlrpc_nrs_policy *policy, char *arg)
        RETURN(rc);
 
 failed:
-       if (orrd->od_cache) {
+       if (orrd->od_cache)
                kmem_cache_destroy(orrd->od_cache);
-               LASSERTF(rc == 0, "Could not destroy od_cache slab\n");
-       }
        if (orrd->od_binheap != NULL)
                cfs_binheap_destroy(orrd->od_binheap);