Whamcloud - gitweb
LU-7766 lnet: Don't call roundup_pow_of_two on zero in LNetEQAlloc 70/18370/2
authorOleg Drokin <oleg.drokin@intel.com>
Tue, 9 Feb 2016 18:19:11 +0000 (13:19 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Sat, 20 Feb 2016 20:57:28 +0000 (20:57 +0000)
commite3705effd8d94be11493da754c5678de5523c877
tree99ab990fccee52ec6239b312fb79a0530e45693a
parentd2c33f43a62e6c5d71288e2895b9668c76c06f9b
LU-7766 lnet: Don't call roundup_pow_of_two on zero in LNetEQAlloc

roundup_pow_of_two return when called on a zero argument is
undefined, so don't call it like that.

This fixes a problem introduced by commit http://review.whamcloud.com/16914
since 0 is a valid count parameter for LNetEQAlloc. Also manifesting
itself as an annoying kernel warning:
LNet: 3486:0:(lib-eq.c:85:LNetEQAlloc()) EQ callback is guaranteed to get every event, do you still want to set eqcount 1 for polling event which will have locking overhead? Please contact with developer to confirm

Change-Id: I9874d50807fff7bb3a039aa9c2eb4f9ca8565242
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/18370
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
lnet/lnet/lib-eq.c