Whamcloud - gitweb
LU-3498 kernel: remove uses of IS_ERR_VALUE() 59/6759/8
authorJohn L. Hammond <john.hammond@intel.com>
Mon, 24 Jun 2013 20:39:51 +0000 (15:39 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Sun, 20 Apr 2014 03:38:16 +0000 (03:38 +0000)
commit5cd7c3f2ab53a07cf98aef83685dafddb13077ed
treed9d08bbc653960080306f03a4e7d8f8a01306658
parent19326174e264802b91fb4dfc0c1ea16d8bf3ef7e
LU-3498 kernel: remove uses of IS_ERR_VALUE()

Remove most uses of IS_ERR_VALUE(). This macro was often given an int
argument coming from PTR_ERR(). This invokes implementation defined
behavior since the long value gotten by applying PTR_ERR() to a kernel
pointer will usually not be representable as an int. Moreover it may
be just plain wrong to do this since the expressions IS_ERR(p) and
IS_ERR_VALUE((int) PTR_ERR(p)) are not equivalent for a general
pointer p.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Ib76592a1fc491539d28a51668c7f06347e988f9f
Reviewed-on: http://review.whamcloud.com/6759
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
13 files changed:
lnet/lnet/acceptor.c
lnet/lnet/router.c
lnet/ulnds/socklnd/usocklnd.c
lustre/ldlm/ldlm_lockd.c
lustre/llite/statahead.c
lustre/mdc/mdc_request.c
lustre/mgc/mgc_request.c
lustre/obdclass/llog.c
lustre/osd-ldiskfs/osd_scrub.c
lustre/osp/osp_sync.c
lustre/ptlrpc/pinger.c
lustre/ptlrpc/service.c
lustre/quota/qsd_reint.c