Whamcloud - gitweb
LU-12542 ldlm: don't access l_resource when not locked. 84/35484/5
authorMr NeilBrown <neilb@suse.de>
Thu, 27 Feb 2020 15:15:16 +0000 (10:15 -0500)
committerOleg Drokin <green@whamcloud.com>
Thu, 5 Mar 2020 22:35:50 +0000 (22:35 +0000)
commit74f4393c74da4eac8bfcfe2a53b8621847701fd6
tree052fada78fd06f5e06794e90343f8fb8c3220eff
parent2835d8f8e6c4fc7aa25ada85247facf735e3196c
LU-12542 ldlm: don't access l_resource when not locked.

lock->l_resource can (sometimes) change when the resource
isn't locked.
So dereferencing lock->l_resource and then locking the
resource looks wrong.
As lock_res_and_lock() returns the locked resource, this
code can easily be more obviously correct by using
that return value.

Change-Id: Iced0bf1af4fa8ddedffa817e00f1c6a02b035d76
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Reviewed-on: https://review.whamcloud.com/35484
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/ldlm/ldlm_lock.c