Whamcloud - gitweb
LU-10030 clio: don't use spare bits in iattr.ia_valid 25/32825/15
authorJames Simmons <uja.ornl@yahoo.com>
Fri, 21 Sep 2018 02:18:09 +0000 (22:18 -0400)
committerOleg Drokin <green@whamcloud.com>
Fri, 5 Oct 2018 22:26:44 +0000 (22:26 +0000)
commit3a6bbda28826ec1eda59ecb9f442a31f87bb409c
tree5739f8033577d30437f571c32c8c7c871736ba18
parentcbc083467e8475dfdfc7ee47ececb8182345113d
LU-10030 clio: don't use spare bits in iattr.ia_valid

Using spare bits in iattr.ia_valid is not safe as the
bits might get used for some other purpose without
us noticing.

Lustre currently used 4 spare bit, but they are all
defined in different places so this isn't immediately
obvious.

This patch brings all those bit definitions together
and defined a new op_data field (op_xvalid) to hold
the extra validity bits.

It also replaces sa_valid in struct cl_setattr_io
with sa_avalid and sa_xvalid.  Changing the name is
helpful as sa_valid already has another use within
lustre.

Modified version of:
Linux-commit: 599b9fb8d424c7907325037b5a862221b1232526

Change-Id: I475a16d557143c0741472e5873c83d71968d7cb8
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: https://review.whamcloud.com/32825
Reviewed-by: Wang Shilong <wshilong@ddn.com>
Tested-by: Jenkins
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
14 files changed:
lustre/include/cl_object.h
lustre/include/lustre_compat.h
lustre/include/lustre_patchless_compat.h
lustre/include/obd.h
lustre/llite/file.c
lustre/llite/lcommon_cl.c
lustre/llite/llite_internal.h
lustre/llite/llite_lib.c
lustre/llite/vvp_io.c
lustre/lmv/lmv_obd.c
lustre/lov/lov_io.c
lustre/mdc/mdc_dev.c
lustre/mdc/mdc_lib.c
lustre/osc/osc_io.c