Whamcloud - gitweb
LU-3433 clio: wrong cl_lock usage 30/8530/2
authorVitaly Fertman <vitaly_fertman@xyratex.com>
Tue, 10 Dec 2013 16:09:45 +0000 (00:09 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 17 Dec 2013 05:39:11 +0000 (05:39 +0000)
commit1a04ba1a772659cc35f806210551ebf542c6365e
tree357bf2d5e16a7712972bca1cc7435ee1531fd3d3
parente78d358341552e2127f226a4ceedc3800ea5903e
LU-3433 clio: wrong cl_lock usage

granted lock is moved to HELD state in cl_wait_try() only which is
done after upcall for non-agl locks. as the result, lock unuse moves
cl_lock not to CACHED state, but to NEW state. A parallel thread
gets this lock and tries to enqueue it - instead of re-using a
cached lock, cl_enqueue_try() initiates a new enqueue and gets to
osc_lock_enqueue() where it asserts:

LASSERTF(ols->ols_state == OLS_NEW, ...);

the state of osc lock is RELEASED already - moved here by unuse.

This patch is back-ported from the following one:
Lustre-commit: 521335cefe670efa2dc34c5db522a283f318447e
Lustre-change: http://review.whamcloud.com/6709

Signed-off-by: Vitaly Fertman <vitaly_fertman@xyratex.com>
Change-Id: I27904bb6198efd5ff98e01f2f74767beabf03a45
Signed-off-by: Jian Yu <jian.yu@intel.com>
Reviewed-on: http://review.whamcloud.com/8530
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/osc/osc_lock.c