Whamcloud - gitweb
LU-455 Replace DIST_SOURCES with EXTRA_DIST
authorChristopher J. Morrone <morrone2@llnl.gov>
Fri, 22 Jul 2011 20:28:06 +0000 (13:28 -0700)
committerOleg Drokin <green@whamcloud.com>
Fri, 12 Aug 2011 19:02:50 +0000 (15:02 -0400)
commit88ae427ab69c4984509631e003e04bd4f7c29fc8
tree0f5aa91a53b1d33ad523d536861765a2aba0572a
parentd24dce9f96591cf63d7c1ab22c36b9aed16a4ef2
LU-455 Replace DIST_SOURCES with EXTRA_DIST

Resolve autoconf-2.63 warnings mainly by replacing DIST_SOURCES
with EXTRA_DIST.  Additionally, the non-portable $(shell) contruct
was removed from tests/module.mk and the sources simply enumated.
Finally, the incorrect EXTRA_SOURCES instance was removed from
the top level autoMakefile.am.

  Running automake-1.11 -a -c -W no-portability
  libcfs/libcfs/autoMakefile.am:92:
          variable `DIST_SOURCES' is defined but no program or
  libcfs/libcfs/autoMakefile.am:92:
          library has `DIST' as canonical name (possible typo)
  lnet/klnds/mxlnd/autoMakefile.am:44:
          variable `DIST_SOURCES' is defined but no program or
  lnet/klnds/mxlnd/autoMakefile.am:44:
          library has `DIST' as canonical name (possible typo)
  ...

Also, as a result of the above changes, libcfs/libcfs/autoMakefile.am had to be
modified in order to allow 'make dist' to succeed.

As it turns out, libcfsutils_a_SOURCES was incorrect. That list contained
references to nonexistent 'util/[parser|platform].h' files. The assumption is
it intended to reference libcfs/include/libcfs/util/[parser|platform].h.

To fix the issue, both [parser|platform].h references were removed from the
list. This produces a simple solution that maintains consistency with the rest
of the build system. The caveat being that libcfsutil.a won't automatically be
rebuilt if either of the intended [parser|platform].h files are modified.

Change-Id: Ia81eb1e3fc219f6dac4c7da234f7e736754c5440
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Christopher J. Morrone <morrone2@llnl.gov>
Signed-off-by: Prakash Surya <surya1@llnl.gov>
Reviewed-on: http://review.whamcloud.com/1092
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Richard Henwood <rhenwood@whamcloud.com>
Tested-by: Richard Henwood <rhenwood@whamcloud.com>
Reviewed-by: Brian J. Murrell <brian@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
20 files changed:
autoMakefile.am
build/autoMakefile.am.toplevel
libcfs/libcfs/autoMakefile.am
libsysio/tests/module.mk
lnet/klnds/mxlnd/autoMakefile.am
lnet/klnds/o2iblnd/autoMakefile.am
lnet/klnds/ptllnd/autoMakefile.am
lnet/klnds/qswlnd/autoMakefile.am
lnet/klnds/ralnd/autoMakefile.am
lnet/klnds/socklnd/autoMakefile.am
lnet/lnet/autoMakefile.am
lnet/selftest/autoMakefile.am
lustre/cmm/autoMakefile.am
lustre/fid/autoMakefile.am
lustre/fld/autoMakefile.am
lustre/lmv/autoMakefile.am
lustre/mdd/autoMakefile.am
lustre/mdt/autoMakefile.am
lustre/osd-ldiskfs/autoMakefile.am
lustre/ptlrpc/gss/autoMakefile.am