Whamcloud - gitweb
LU-17000 misc: remove Coverity annotations 93/51793/2
authorTimothy Day <timday@amazon.com>
Fri, 28 Jul 2023 04:49:50 +0000 (04:49 +0000)
committerOleg Drokin <green@whamcloud.com>
Thu, 31 Aug 2023 06:33:46 +0000 (06:33 +0000)
commit05b289450b21f67f3cc0e7c9f91b63cf9c43d177
tree56869331df4ae86d331a4f6a49225178ef88afe8
parent3c0b1fbf34086409f8295a6d7bf68e4dff746966
LU-17000 misc: remove Coverity annotations

These Coverity function annotations were added
around 10 years ago. Since then, Coverity seems
to produce less false positives. Out of about 20
annotations, only 3 warnings get surpressed.
Thus, the applicability of these annotations
should be re-evaluated.

Coverity has more advanced tools now for reducing
false positives. Various Lustre functions and
macros could be modeled rather than using
function annotations. But first, we need to get
a good idea of what kinds of false postives are
being generated.

https://scan.coverity.com/tune

Test-Parameters: trivial
Signed-off-by: Timothy Day <timday@amazon.com>
Change-Id: Ibcb9cf55574675e20b13a4f7a1b9142a3b75e262
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51793
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
12 files changed:
libcfs/libcfs/debug.c
lustre/ldlm/ldlm_lock.c
lustre/ldlm/ldlm_lockd.c
lustre/ldlm/ldlm_request.c
lustre/lod/lod_lov.c
lustre/lod/lod_qos.c
lustre/lov/lov_obd.c
lustre/lov/lov_object.c
lustre/mdt/mdt_open.c
lustre/obdecho/echo_client.c
lustre/ptlrpc/client.c
lustre/utils/obd.c