Whamcloud - gitweb
LU-13855 tests: remove the need for libiberty 02/40802/11
authorAndreas Dilger <adilger@whamcloud.com>
Mon, 30 Nov 2020 20:35:46 +0000 (13:35 -0700)
committerOleg Drokin <green@whamcloud.com>
Sun, 13 Dec 2020 08:23:46 +0000 (08:23 +0000)
commit8b02ade2818d86f29965dae61918456330f38d55
treea90abce8224bac8e42bdb18d69bcefa325ebdbab
parentb6eb0c84a3e8ada2dff1d32a3b8bcf80e6ebd246
LU-13855 tests: remove the need for libiberty

The statx.c test program uses a bunch of GNU-specific xstr*
functions that have very little, if any, benefit to the code.
They allocate copies of static format strings, but those
strings are not modified, and are never freed.  Since the
use of xstr* drags in libiberty and associated build issues
on a variety of platforms, instead avoid those functions.

Remove the use of this library completely from the statx.c
test tool, with minimal replacements to keep the build happy.
Remove the corresponding configure checks.

Fixes: 3f7853b31ef6 ("LU-10934 llite: integrate statx() API with Lustre")
Test-Parameters: trivial testlist=sanityn env=ONLY=106 clientdistro=ubuntu2004
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Change-Id: I2c11bac8e2a4b4754ee78caabfa9cbdba98bffff
Reviewed-on: https://review.whamcloud.com/40802
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Yingjin Qian <qian@ddn.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
config/lustre-build.m4
debian/control
debian/control.main
lustre/tests/Makefile.am
lustre/tests/statx.c