X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lustre%2Futils%2Flfs.c;h=20f2d6031a752cdba8cda798a7fa37eb0fc1d22c;hp=6de2f290140dc49c70e5ba71b88df41a4aded9b4;hb=a9650116ab7ccea22a5a8852e7894f28d17edabd;hpb=00d783456c551aa990e911c075f8cc0db0c45f96 diff --git a/lustre/utils/lfs.c b/lustre/utils/lfs.c index 6de2f29..20f2d60 100644 --- a/lustre/utils/lfs.c +++ b/lustre/utils/lfs.c @@ -26,7 +26,7 @@ * GPL HEADER END */ /* - * Copyright 2008 Sun Microsystems, Inc. All rights reserved + * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved. * Use is subject to license terms. */ /* @@ -117,33 +117,33 @@ command_t cmdlist[] = { "Create a new file with a specific striping pattern or\n" "set the default striping pattern on an existing directory or\n" "delete the default striping pattern from an existing directory\n" - "usage: setstripe [--size|-s stripe_size] [--offset|-o start_ost]\n" - " [--count|-c stripe_count] [--pool|-p ]\n" - " \n" + "usage: setstripe [--size|-s stripe_size] [--count|-c stripe_count]\n" + " [--index|-i|--offset|-o start_ost_index]\n" + " [--pool|-p ] \n" " or \n" " setstripe -d (to delete default striping)\n" "\tstripe_size: Number of bytes on each OST (0 filesystem default)\n" "\t Can be specified with k, m or g (in KB, MB and GB\n" "\t respectively)\n" - "\tstart_ost: OST index of first stripe (-1 filesystem default)\n" + "\tstart_ost_index: OST index of first stripe (-1 filesystem default)\n" "\tstripe_count: Number of OSTs to stripe over (0 default, -1 all)\n" "\tpool: Name of OST pool"}, {"getstripe", lfs_getstripe, 0, "To list the striping info for a given file or files in a\n" "directory or recursively for all files in a directory tree.\n" "usage: getstripe [--obd|-O ] [--quiet | -q] [--verbose | -v]\n" - " [--count | -c ] [--size | -s ] [--index | -i ]\n" - " [--offset | -o ] [--pool | -p ] [--directory | -d]\n" + " [--count | -c ] [--index | -i | --offset | -o ]\n" + " [--size | -s ] [--pool | -p ] [--directory | -d]\n" " [--mdt | -M] [--recursive | -r] ..."}, {"pool_list", lfs_poollist, 0, "List pools or pool OSTs\n" "usage: pool_list [.] | \n"}, {"find", lfs_find, 0, "To find files that match given parameters recursively in a directory tree.\n" - "usage: find ... \n" + "usage: find ...\n" " [[!] --atime|-A [+-]N] [[!] --mtime|-M [+-]N] [[!] --ctime|-C [+-]N]\n" " [--maxdepth|-D N] [[!] --name|-n ] [--print0|-P]\n" - " [--print|-p] [--obd|-O ] [[!] --size|-s [+-]N[bkMGTP]]\n" + " [--print|-p] [[!] --obd|-O ] [[!] --size|-s [+-]N[bkMGTP]]\n" " [[!] --type|-t ] [[!] --gid|-g|--group|-G |]\n" " [[!] --uid|-u|--user|-U |]\n" " [[!] --pool ]\n" @@ -162,7 +162,8 @@ command_t cmdlist[] = { {"join", lfs_join, 0, "join two lustre files into one.\n" "obsolete, HEAD does not support it anymore.\n"}, - {"osts", lfs_osts, 0, "osts"}, + {"osts", lfs_osts, 0, "list OSTs connected to client " + "[for specified path only]\n" "usage: osts [path]"}, {"df", lfs_df, 0, "report filesystem disk space usage or inodes usage" "of each MDS and all OSDs or a batch belonging to a specific pool .\n" @@ -198,9 +199,9 @@ command_t cmdlist[] = { " -i can be used instead of --inode-softlimit/--inode-grace\n" " -I can be used instead of --inode-hardlimit"}, {"quota", lfs_quota, 0, "Display disk usage and limits.\n" - "usage: quota [-v] [-o obd_uuid|-i mdt_idx|-I ost_idx]\n" + "usage: quota [-q] [-v] [-o |-i |-I ]\n" " [<-u|-g> |||] \n" - " quota [-o obd_uuid|-i mdt_idx|-I ost_idx] -t <-u|-g> "}, + " quota [-o |-i |-I ] -t <-u|-g> "}, {"quotainv", lfs_quotainv, 0, "Invalidate quota data.\n" "usage: quotainv [-u|-g] "}, #endif @@ -291,18 +292,12 @@ static int lfs_setstripe(int argc, char **argv) st_offset = -1; st_count = 0; -#if LUSTRE_VERSION < OBD_OCD_VERSION(2,1,0,0) +#if LUSTRE_VERSION < OBD_OCD_VERSION(2,4,50,0) if (argc == 5 && argv[1][0] != '-' && isnumber(argv[2]) && isnumber(argv[3]) && isnumber(argv[4])) { - fprintf(stderr, "warning: deprecated usage of setstripe " + fprintf(stderr, "error: obsolete usage of setstripe " "positional parameters. Use -c, -i, -s instead.\n"); - /* for compatibility with the existing positional parameter - * usage */ - fname = argv[1]; - stripe_size_arg = argv[2]; - stripe_off_arg = argv[3]; - stripe_count_arg = argv[4]; - optind = 4; + return CMD_HELP; } else #else #warning "remove obsolete positional parameter code" @@ -371,7 +366,7 @@ static int lfs_setstripe(int argc, char **argv) } /* get the stripe offset */ if (stripe_off_arg != NULL) { - st_offset = strtoul(stripe_off_arg, &end, 0); + st_offset = strtol(stripe_off_arg, &end, 0); if (*end != '\0') { fprintf(stderr, "error: %s: bad stripe offset '%s'\n", argv[0], stripe_off_arg); @@ -499,7 +494,6 @@ static int lfs_find(int argc, char **argv) int c, ret; time_t t; struct find_param param = { .maxdepth = -1 }; - char str[1024]; struct option long_opts[] = { /* New find options. */ {"atime", required_argument, 0, 'A'}, @@ -581,29 +575,20 @@ static int lfs_find(int argc, char **argv) case 'A': xtime = ¶m.atime; xsign = ¶m.asign; + param.exclude_atime = !!neg_opt; case 'C': if (c == 'C') { xtime = ¶m.ctime; xsign = ¶m.csign; + param.exclude_ctime = !!neg_opt; } case 'M': if (c == 'M') { xtime = ¶m.mtime; xsign = ¶m.msign; + param.exclude_mtime = !!neg_opt; } new_fashion = 1; - if (neg_opt) { - if (optarg[0] == '-') - optarg[0] = '+'; - else if (optarg[0] == '+') - optarg[0] = '-'; - else { - str[0] = '-'; - str[1] = '\0'; - strcat(str, optarg); - optarg = str; - } - } ret = set_time(&t, xtime, optarg); if (ret == INT_MAX) return -1; @@ -625,7 +610,7 @@ static int lfs_find(int argc, char **argv) "be found.\n", optarg); return -1; } - } + } param.exclude_gid = !!neg_opt; param.check_gid = 1; break; @@ -675,6 +660,8 @@ static int lfs_find(int argc, char **argv) return -ENOMEM; strcpy(buf, (char *)optarg); + param.exclude_obd = !!neg_opt; + if (param.num_alloc_obds == 0) { param.obduuid = malloc(FIND_MAX_OSTS * sizeof(struct obd_uuid)); @@ -732,18 +719,6 @@ static int lfs_find(int argc, char **argv) }; break; case 's': - if (neg_opt) { - if (optarg[0] == '-') - optarg[0] = '+'; - else if (optarg[0] == '+') - optarg[0] = '-'; - else { - str[0] = '-'; - str[1] = '\0'; - strcat(str, optarg); - optarg = str; - } - } if (optarg[0] == '+') param.size_sign = -1; else if (optarg[0] == '-') @@ -758,6 +733,8 @@ static int lfs_find(int argc, char **argv) optarg); return ret; } + param.check_size = 1; + param.exclude_size = !!neg_opt; break; case 'v': new_fashion = 0; @@ -877,7 +854,10 @@ static int lfs_getstripe(int argc, char **argv) } break; case 'p': - param.verbose |= VERBOSE_POOL; + if (!(param.verbose & VERBOSE_DETAIL)) { + param.verbose |= VERBOSE_POOL; + param.maxdepth = 0; + } break; case 'M': param.get_mdt_index = 1; @@ -914,20 +894,33 @@ static int lfs_getstripe(int argc, char **argv) static int lfs_osts(int argc, char **argv) { - char mntdir[PATH_MAX] = {'\0'}; + char mntdir[PATH_MAX] = {'\0'}, path[PATH_MAX] = {'\0'}; struct find_param param; int index = 0, rc=0; - if (argc != 1) + if (argc > 2) return CMD_HELP; - while (llapi_search_mounts(NULL, index++, mntdir, NULL) == 0) { + if (argc == 2 && !realpath(argv[1], path)) { + rc = -errno; + fprintf(stderr, "error: invalid path '%s': %s\n", + argv[1], strerror(-rc)); + return rc; + } + + while (!llapi_search_mounts(path, index++, mntdir, NULL)) { + /* Check if we have a mount point */ + if (mntdir[0] == '\0') + continue; + memset(¶m, 0, sizeof(param)); rc = llapi_ostlist(mntdir, ¶m); if (rc) { fprintf(stderr, "error: %s: failed on %s\n", argv[0], mntdir); } + if (path[0] != '\0') + break; memset(mntdir, 0, PATH_MAX); } @@ -944,12 +937,11 @@ static int lfs_osts(int argc, char **argv) radix; \ }) #define UUF "%-20s" -#define CSF "%9s" -#define CDF "%9llu" -#define HSF "%8s" -#define HDF "%6.1f" -#define RSF "%5s" -#define RDF "%4d%%" +#define CSF "%11s" +#define CDF "%11llu" +#define HDF "%8.1f%c" +#define RSF "%4s" +#define RDF "%3d%%" static int showdf(char *mntdir, struct obd_statfs *stat, char *uuid, int ishow, int cooked, @@ -979,8 +971,8 @@ static int showdf(char *mntdir, struct obd_statfs *stat, total = (stat->os_blocks * stat->os_bsize) >> shift; } - if (total > 0) - ratio = (double)used / (double)total; + if ((used + avail) > 0) + ratio = (double)used / (double)(used + avail); if (cooked) { int i; @@ -989,21 +981,21 @@ static int showdf(char *mntdir, struct obd_statfs *stat, cook_val = (double)total; i = COOK(cook_val); if (i > 0) - sprintf(tbuf, HDF"%c", cook_val, suffix[i - 1]); + sprintf(tbuf, HDF, cook_val, suffix[i - 1]); else sprintf(tbuf, CDF, total); cook_val = (double)used; i = COOK(cook_val); if (i > 0) - sprintf(ubuf, HDF"%c", cook_val, suffix[i - 1]); + sprintf(ubuf, HDF, cook_val, suffix[i - 1]); else sprintf(ubuf, CDF, used); cook_val = (double)avail; i = COOK(cook_val); if (i > 0) - sprintf(abuf, HDF"%c", cook_val, suffix[i - 1]); + sprintf(abuf, HDF, cook_val, suffix[i - 1]); else sprintf(abuf, CDF, avail); } else { @@ -1012,7 +1004,7 @@ static int showdf(char *mntdir, struct obd_statfs *stat, sprintf(abuf, CDF, avail); } - sprintf(rbuf, RDF, (int)(ratio * 100)); + sprintf(rbuf, RDF, (int)(ratio * 100 + 0.5)); printf(UUF" "CSF" "CSF" "CSF" "RSF" %-s", uuid, tbuf, ubuf, abuf, rbuf, mntdir); if (type) @@ -1032,11 +1024,20 @@ static int showdf(char *mntdir, struct obd_statfs *stat, return 0; } +struct ll_stat_type { + int st_op; + char *st_name; +}; + static int mntdf(char *mntdir, char *fsname, char *pool, int ishow, int cooked) { struct obd_statfs stat_buf, sum = { .os_bsize = 1 }; struct obd_uuid uuid_buf; char *poolname = NULL; + struct ll_stat_type types[] = { { LL_STATFS_MDC, "MDT" }, + { LL_STATFS_LOV, "OST" }, + { 0, NULL } }; + struct ll_stat_type *tp; __u32 index; int rc; @@ -1061,78 +1062,61 @@ static int mntdf(char *mntdir, char *fsname, char *pool, int ishow, int cooked) "UUID", cooked ? "bytes" : "1K-blocks", "Used", "Available", "Use%", "Mounted on"); - for (index = 0; ; index++) { - memset(&stat_buf, 0, sizeof(struct obd_statfs)); - memset(&uuid_buf, 0, sizeof(struct obd_uuid)); - rc = llapi_obd_statfs(mntdir, LL_STATFS_MDC, index, - &stat_buf, &uuid_buf); - if (rc == -ENODEV) - break; - - if (rc == -EAGAIN) - continue; - - if (rc == -ENOTCONN || rc == -ETIMEDOUT || rc == -EIO || - rc == -ENODATA || rc == 0) { - showdf(mntdir, &stat_buf, obd_uuid2str(&uuid_buf), - ishow, cooked, "MDT", index, rc); - } else { - fprintf(stderr, - "error: llapi_obd_statfs(%s): %s (%d)\n", - obd_uuid2str(&uuid_buf), strerror(-rc), rc); - return rc; - } - if (rc == 0) { - sum.os_ffree += stat_buf.os_ffree; - sum.os_files += stat_buf.os_files; - } - } - - for (index = 0; ; index++) { - memset(&stat_buf, 0, sizeof(struct obd_statfs)); - memset(&uuid_buf, 0, sizeof(struct obd_uuid)); - rc = llapi_obd_statfs(mntdir, LL_STATFS_LOV, index, - &stat_buf, &uuid_buf); - if (rc == -ENODEV) - break; - - if (rc == -EAGAIN) - continue; + for (tp = types; tp->st_name != NULL; tp++) { + for (index = 0; ; index++) { + memset(&stat_buf, 0, sizeof(struct obd_statfs)); + memset(&uuid_buf, 0, sizeof(struct obd_uuid)); + rc = llapi_obd_statfs(mntdir, tp->st_op, index, + &stat_buf, &uuid_buf); + if (rc == -ENODEV) + break; - if (llapi_search_ost(fsname, poolname, - obd_uuid2str(&uuid_buf)) != 1) - continue; + if (poolname && tp->st_op == LL_STATFS_LOV && + llapi_search_ost(fsname, poolname, + obd_uuid2str(&uuid_buf)) != 1) + continue; - if (rc == -ENOTCONN || rc == -ETIMEDOUT || rc == -EIO || - rc == -ENODATA || rc == 0) { - showdf(mntdir, &stat_buf, obd_uuid2str(&uuid_buf), - ishow, cooked, "OST", index, rc); - } else { - fprintf(stderr, - "error: llapi_obd_statfs failed: %s (%d)\n", - strerror(-rc), rc); - return rc; - } - if (rc == 0) { - sum.os_blocks += stat_buf.os_blocks * stat_buf.os_bsize; - sum.os_bfree += stat_buf.os_bfree * stat_buf.os_bsize; - sum.os_bavail += stat_buf.os_bavail * stat_buf.os_bsize; + /* the llapi_obd_statfs() call may have returned with + * an error, but if it filled in uuid_buf we will at + * lease use that to print out a message for that OBD. + * If we didn't get anything in the uuid_buf, then fill + * it in so that we can print an error message. */ + if (uuid_buf.uuid[0] == '\0') + sprintf(uuid_buf.uuid, "%s%04x", + tp->st_name, index); + showdf(mntdir,&stat_buf,obd_uuid2str(&uuid_buf), + ishow, cooked, tp->st_name, index, rc); + + if (rc == 0) { + if (tp->st_op == LL_STATFS_MDC) { + sum.os_ffree += stat_buf.os_ffree; + sum.os_files += stat_buf.os_files; + } else /* if (tp->st_op == LL_STATFS_LOV) */ { + sum.os_blocks += stat_buf.os_blocks * + stat_buf.os_bsize; + sum.os_bfree += stat_buf.os_bfree * + stat_buf.os_bsize; + sum.os_bavail += stat_buf.os_bavail * + stat_buf.os_bsize; + } + } else if (rc == -EINVAL || rc == -EFAULT) { + break; + } } } printf("\n"); showdf(mntdir, &sum, "filesystem summary:", ishow, cooked, NULL, 0,0); - + printf("\n"); return 0; } static int lfs_df(int argc, char **argv) { - char *path = NULL; - char *mntdir = NULL; + char mntdir[PATH_MAX] = {'\0'}, path[PATH_MAX] = {'\0'}; int ishow = 0, cooked = 0; - int c, rc = 0; - char fsname[PATH_MAX], *pool_name = NULL; + int c, rc = 0, index = 0; + char fsname[PATH_MAX] = "", *pool_name = NULL; struct option long_opts[] = { {"pool", required_argument, 0, 'p'}, {0, 0, 0, 0} @@ -1154,44 +1138,25 @@ static int lfs_df(int argc, char **argv) return CMD_HELP; } } - if (optind < argc ) - path = argv[optind]; - - if ((mntdir = malloc(PATH_MAX)) == NULL) { - fprintf(stderr, "error: cannot allocate %d bytes\n", - PATH_MAX); - return -ENOMEM; + if (optind < argc && !realpath(argv[optind], path)) { + rc = -errno; + fprintf(stderr, "error: invalid path '%s': %s\n", + argv[optind], strerror(-rc)); + return rc; } - memset(mntdir, 0, PATH_MAX); - if (path) { - char rpath[PATH_MAX] = {'\0'}; - - if (!realpath(path, rpath)) { - rc = -errno; - fprintf(stderr, "error: invalid path '%s': %s\n", - path, strerror(-rc)); - } else { - rc = llapi_search_mounts(rpath, 0, mntdir, fsname); - if (rc == 0 && mntdir[0] != '\0') { - rc = mntdf(mntdir, fsname, pool_name, - ishow, cooked); - printf("\n"); - } - } - } else { - int index = 0; + while (!llapi_search_mounts(path, index++, mntdir, fsname)) { + /* Check if we have a mount point */ + if (mntdir[0] == '\0') + continue; - while (llapi_search_mounts(NULL, index++, mntdir, fsname)==0) { - rc = mntdf(mntdir, fsname, pool_name, - ishow, cooked); - if (rc) - break; - printf("\n"); - } + rc = mntdf(mntdir, fsname, pool_name, ishow, cooked); + if (rc || path[0] != '\0') + break; + fsname[0] = '\0'; /* avoid matching in next loop */ + mntdir[0] = '\0'; /* avoid matching in next loop */ } - free(mntdir); return rc; } @@ -1411,9 +1376,6 @@ static int lfs_quotaon(int argc, char **argv) rc = llapi_quotactl(mnt, &qctl); if (rc) { if (errno == EALREADY) { - fprintf(stderr, "\n%s quotas are enabled already.\n", - qctl.qc_type == 0x02 ? "user/group" : - (qctl.qc_type == 0x00 ? "user" : "group")); rc = 0; } else if (errno == ENOENT) { fprintf(stderr, "error: cannot find quota database, " @@ -1470,9 +1432,6 @@ static int lfs_quotaoff(int argc, char **argv) rc = llapi_quotactl(mnt, &qctl); if (rc) { if (errno == EALREADY) { - fprintf(stderr, "\n%s quotas are disabled already.\n", - qctl.qc_type == 0x02 ? "user/group" : - (qctl.qc_type == 0x00 ? "user" : "group")); rc = 0; } else { if (*obd_type) @@ -1553,8 +1512,8 @@ do { \ * 2. specifiers may be encountered multiple times (2s3s is 5 seconds) * 3. empty integer value is interpreted as 0 */ - -static unsigned long str2sec(const char* timestr) { +static unsigned long str2sec(const char* timestr) +{ const char spec[] = "smhdw"; const unsigned long mult[] = {1, 60, 60*60, 24*60*60, 7*24*60*60}; unsigned long val = 0; @@ -1754,7 +1713,7 @@ int lfs_setquota(int argc, char **argv) qctl.qc_id = strtoul(optarg, &endptr, 10); if (*endptr != '\0') { fprintf(stderr, "error: can't find id " - "for name %s\n", optarg); + "for name %s\n", optarg); return CMD_HELP; } } @@ -1860,7 +1819,6 @@ static inline char *type2name(int check_type) return "unknown"; } - /* Converts seconds value into format string * result is returned in buf * Notes: @@ -1868,12 +1826,12 @@ static inline char *type2name(int check_type) * 2. zero fields are not filled (except for p. 3): 5d1s * 3. zero seconds value is presented as "0s" */ -static void sec2str(time_t seconds, char *buf) +static char * __sec2str(time_t seconds, char *buf) { const char spec[] = "smhdw"; const unsigned long mult[] = {1, 60, 60*60, 24*60*60, 7*24*60*60}; unsigned long c; - char* tail = buf; + char *tail = buf; int i; for (i = sizeof(mult) / sizeof(mult[0]) - 1 ; i >= 0; i--) { @@ -1884,8 +1842,24 @@ static void sec2str(time_t seconds, char *buf) seconds %= mult[i]; } + + return tail; } +static void sec2str(time_t seconds, char *buf, int rc) +{ + char *tail = buf; + + if (rc) + *tail++ = '['; + + tail = __sec2str(seconds, tail); + + if (rc && tail - buf < 39) { + *tail++ = ']'; + *tail++ = 0; + } +} static void diff2str(time_t seconds, char *buf, time_t now) { @@ -1897,7 +1871,7 @@ static void diff2str(time_t seconds, char *buf, time_t now) strcpy(buf, "none"); return; } - sec2str(seconds - now, buf); + __sec2str(seconds - now, buf); } static void print_quota_title(char *name, struct if_quotactl *qctl) @@ -1972,12 +1946,12 @@ static void print_quota(char *mnt, struct if_quotactl *qctl, int type, int rc) ? LPU64 : "["LPU64"]", dqb->dqb_bsoftlimit); else - sprintf(numbuf[1], "%s", ""); + sprintf(numbuf[1], "%s", "-"); sprintf(numbuf[2], (dqb->dqb_valid & QIF_BLIMITS) ? LPU64 : "["LPU64"]", dqb->dqb_bhardlimit); printf(" %7s%c %6s %7s %7s", numbuf[0], bover ? '*' : ' ', numbuf[1], - numbuf[2], bover > 1 ? timebuf : ""); + numbuf[2], bover > 1 ? timebuf : "-"); if (iover) diff2str(dqb->dqb_itime, timebuf, now); @@ -1989,13 +1963,15 @@ static void print_quota(char *mnt, struct if_quotactl *qctl, int type, int rc) ? LPU64 : "["LPU64"]", dqb->dqb_isoftlimit); else - sprintf(numbuf[1], "%s", ""); + sprintf(numbuf[1], "%s", "-"); sprintf(numbuf[2], (dqb->dqb_valid & QIF_ILIMITS) ? LPU64 : "["LPU64"]", dqb->dqb_ihardlimit); if (type != QC_OSTIDX) printf(" %7s%c %6s %7s %7s", numbuf[0], iover ? '*' : ' ', numbuf[1], - numbuf[2], iover > 1 ? timebuf : ""); + numbuf[2], iover > 1 ? timebuf : "-"); + else + printf(" %7s %7s %7s %7s", "-", "-", "-", "-"); printf("\n"); } } else if (qctl->qc_cmd == LUSTRE_Q_GETINFO || @@ -2003,8 +1979,8 @@ static void print_quota(char *mnt, struct if_quotactl *qctl, int type, int rc) char bgtimebuf[40]; char igtimebuf[40]; - sec2str(qctl->qc_dqinfo.dqi_bgrace, bgtimebuf); - sec2str(qctl->qc_dqinfo.dqi_igrace, igtimebuf); + sec2str(qctl->qc_dqinfo.dqi_bgrace, bgtimebuf, rc); + sec2str(qctl->qc_dqinfo.dqi_igrace, igtimebuf, rc); printf("Block grace time: %s; Inode grace time: %s\n", bgtimebuf, igtimebuf); } @@ -2055,12 +2031,13 @@ static int lfs_quota(int argc, char **argv) .qc_type = UGQUOTA }; char *obd_type = (char *)qctl.obd_type; char *obd_uuid = (char *)qctl.obd_uuid.uuid; - int rc, rc1 = 0, rc2 = 0, rc3 = 0, verbose = 0, pass = 0; + int rc, rc1 = 0, rc2 = 0, rc3 = 0, + verbose = 0, pass = 0, quiet = 0, inacc; char *endptr; __u32 valid = QC_GENERAL, idx = 0; optind = 0; - while ((c = getopt(argc, argv, "ugto:i:I:v")) != -1) { + while ((c = getopt(argc, argv, "ugto:i:I:qv")) != -1) { switch (c) { case 'u': if (qctl.qc_type != UGQUOTA) { @@ -2094,6 +2071,9 @@ static int lfs_quota(int argc, char **argv) case 'v': verbose = 1; break; + case 'q': + quiet = 1; + break; default: fprintf(stderr, "error: %s: option '-%c' " "unrecognized\n", argv[0], c); @@ -2144,23 +2124,38 @@ ug_output: return CMD_HELP; } - if (qctl.qc_cmd == LUSTRE_Q_GETQUOTA) - print_quota_title(name, &qctl); - mnt = argv[optind]; rc1 = llapi_quotactl(mnt, &qctl); - if (rc1 == -1 && errno == EALREADY) { - fprintf(stderr, "\n%s quotas are not enabled.\n", - qctl.qc_type == USRQUOTA ? "user" : "group"); - goto out; + if (rc1 == -1) { + switch (errno) { + case ESRCH: + fprintf(stderr, "%s quotas are not enabled.\n", + qctl.qc_type == USRQUOTA ? "user" : "group"); + goto out; + case EPERM: + fprintf(stderr, "Permission denied.\n"); + case ENOENT: + /* We already got a "No such file..." message. */ + goto out; + default: + fprintf(stderr, "Unexpected quotactl error: %s\n", + strerror(errno)); + } } + + if (qctl.qc_cmd == LUSTRE_Q_GETQUOTA && !quiet) + print_quota_title(name, &qctl); + if (rc1 && *obd_type) fprintf(stderr, "%s %s ", obd_type, obd_uuid); if (qctl.qc_valid != QC_GENERAL) mnt = ""; + inacc = (qctl.qc_cmd == LUSTRE_Q_GETQUOTA) && + ((qctl.qc_dqblk.dqb_valid&(QIF_LIMITS|QIF_USAGE))!=(QIF_LIMITS|QIF_USAGE)); + print_quota(mnt, &qctl, QC_GENERAL, rc1); if (qctl.qc_valid == QC_GENERAL && qctl.qc_cmd != LUSTRE_Q_GETINFO && verbose) { @@ -2168,7 +2163,7 @@ ug_output: rc3 = print_obd_quota(mnt, &qctl, 0); } - if (rc1 || rc2 || rc3) + if (rc1 || rc2 || rc3 || inacc) printf("Some errors happened when getting quota info. " "Some devices may be not working or deactivated. " "The data in \"[]\" is inaccurate.\n"); @@ -2177,7 +2172,7 @@ out: if (pass == 1) goto ug_output; - return 0; + return rc1; } #endif /* HAVE_SYS_QUOTA_H! */ @@ -2357,10 +2352,14 @@ static int lfs_changelog(int argc, char **argv) time_t secs; struct tm ts; - if (endrec && rec->cr_index > endrec) + if (endrec && rec->cr_index > endrec) { + llapi_changelog_free(&rec); break; - if (rec->cr_index < startrec) + } + if (rec->cr_index < startrec) { + llapi_changelog_free(&rec); continue; + } secs = rec->cr_time >> 30; gmtime_r(&secs, &ts); @@ -2464,9 +2463,15 @@ static int lfs_fid2path(int argc, char **argv) } if (printcur) - fprintf(stdout, "%lld %s\n", rectmp, path); - else - fprintf(stdout, "%s\n", path); + fprintf(stdout, "%lld ", rectmp); + if (device[0] == '/') { + fprintf(stdout, "%s", device); + if (device[strlen(device) - 1] != '/') + fprintf(stdout, "/"); + } else if (path[0] == '\0') { + fprintf(stdout, "/"); + } + fprintf(stdout, "%s\n", path); if (linkno >= 0) /* specified linkno */