X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lustre%2Ftarget%2Ftgt_handler.c;h=4558c37405192f8b061a1c9709ec7fd881958466;hp=027b05d5e299f17284bb3d116294697fc0e43b42;hb=f44413717eaf5cb938d9c9b2b62d312f064d282a;hpb=4c3864cf97711d73b12905fea720570cf814d179 diff --git a/lustre/target/tgt_handler.c b/lustre/target/tgt_handler.c index 027b05d..4558c37 100644 --- a/lustre/target/tgt_handler.c +++ b/lustre/target/tgt_handler.c @@ -35,10 +35,10 @@ #define DEBUG_SUBSYSTEM S_CLASS #include -#ifdef HAVE_UIDGID_HEADER -# include -#endif +#include +#include +#include #include #include #include @@ -320,11 +320,15 @@ static int tgt_request_preprocess(struct tgt_session_info *tsi, h->th_fmt != NULL)); if (h->th_fmt != NULL) { req_capsule_set(pill, h->th_fmt); - if (req_capsule_has_field(pill, &RMF_MDT_BODY, RCL_CLIENT)) { + if (req_capsule_has_field(pill, &RMF_MDT_BODY, RCL_CLIENT) && + req_capsule_field_present(pill, &RMF_MDT_BODY, + RCL_CLIENT)) { rc = tgt_mdt_body_unpack(tsi, flags); if (rc < 0) RETURN(rc); } else if (req_capsule_has_field(pill, &RMF_OST_BODY, + RCL_CLIENT) && + req_capsule_field_present(pill, &RMF_OST_BODY, RCL_CLIENT)) { rc = tgt_ost_body_unpack(tsi, flags); if (rc < 0) @@ -415,6 +419,11 @@ static int tgt_handle_request0(struct tgt_session_info *tsi, OBD_FAIL_CHECK(OBD_FAIL_MDS_REINT_MULTI_NET))) RETURN(0); + /* drop OUT_UPDATE rpc */ + if (unlikely(lustre_msg_get_opc(req->rq_reqmsg) == OUT_UPDATE && + OBD_FAIL_CHECK(OBD_FAIL_OUT_UPDATE_DROP))) + RETURN(0); + rc = tgt_request_preprocess(tsi, h, req); /* pack reply if reply format is fixed */ if (rc == 0 && h->th_flags & HAS_REPLY) { @@ -442,7 +451,8 @@ static int tgt_handle_request0(struct tgt_session_info *tsi, req_capsule_set_size(tsi->tsi_pill, &RMF_SHORT_IO, RCL_SERVER, - (body->oa.o_flags & OBD_FL_SHORT_IO) ? + (body->oa.o_valid & OBD_MD_FLFLAGS && + body->oa.o_flags & OBD_FL_SHORT_IO) ? remote_nb[0].rnb_len : 0); } @@ -460,8 +470,8 @@ static int tgt_handle_request0(struct tgt_session_info *tsi, rc = h->th_act(tsi); if (!is_serious(rc) && !req->rq_no_reply && req->rq_reply_state == NULL) { - DEBUG_REQ(D_ERROR, req, "%s \"handler\" %s did not " - "pack reply and returned 0 error\n", + DEBUG_REQ(D_ERROR, req, + "%s: %s handler did not pack reply but returned no error", tgt_name(tsi->tsi_tgt), h->th_name); LBUG(); } @@ -517,6 +527,7 @@ static int tgt_filter_recovery_request(struct ptlrpc_request *req, case MDS_HSM_PROGRESS: case MDS_HSM_STATE_SET: case MDS_HSM_REQUEST: + case OST_FALLOCATE: *process = target_queue_recovery_request(req, obd); RETURN(0); @@ -552,12 +563,12 @@ static int tgt_handle_recovery(struct ptlrpc_request *req, int reply_fail_id) /* sanity check: if the xid matches, the request must be marked as a * resent or replayed */ - if (req_can_reconstruct(req, NULL)) { + if (req_can_reconstruct(req, NULL) == 1) { if (!(lustre_msg_get_flags(req->rq_reqmsg) & (MSG_RESENT | MSG_REPLAY))) { - DEBUG_REQ(D_WARNING, req, "rq_xid %llu matches " - "saved xid, expected REPLAY or RESENT flag " - "(%x)", req->rq_xid, + DEBUG_REQ(D_WARNING, req, + "rq_xid=%llu matches saved XID, expected REPLAY or RESENT flag (%x)", + req->rq_xid, lustre_msg_get_flags(req->rq_reqmsg)); req->rq_status = -ENOTCONN; RETURN(-ENOTCONN); @@ -600,7 +611,7 @@ static struct tgt_handler *tgt_handler_find_check(struct ptlrpc_request *req) tgt = class_exp2tgt(req->rq_export); if (unlikely(tgt == NULL)) { - DEBUG_REQ(D_ERROR, req, "%s: No target for connected export\n", + DEBUG_REQ(D_ERROR, req, "%s: no target for connected export", class_exp2obd(req->rq_export)->obd_name); RETURN(ERR_PTR(-EINVAL)); } @@ -629,18 +640,20 @@ static struct tgt_handler *tgt_handler_find_check(struct ptlrpc_request *req) static int process_req_last_xid(struct ptlrpc_request *req) { __u64 last_xid; + int rc = 0; + struct obd_export *exp = req->rq_export; + struct tg_export_data *ted = &exp->exp_target_data; + bool need_lock = tgt_is_multimodrpcs_client(exp); ENTRY; + if (need_lock) + mutex_lock(&ted->ted_lcd_lock); /* check request's xid is consistent with export's last_xid */ last_xid = lustre_msg_get_last_xid(req->rq_reqmsg); - if (last_xid > req->rq_export->exp_last_xid) - req->rq_export->exp_last_xid = last_xid; - - if (req->rq_xid == 0 || - (req->rq_xid <= req->rq_export->exp_last_xid)) { - DEBUG_REQ(D_ERROR, req, "Unexpected xid %llx vs. " - "last_xid %llx\n", req->rq_xid, - req->rq_export->exp_last_xid); + if (last_xid > exp->exp_last_xid) + exp->exp_last_xid = last_xid; + + if (req->rq_xid == 0 || req->rq_xid <= exp->exp_last_xid) { /* Some request is allowed to be sent during replay, * such as OUT update requests, FLD requests, so it * is possible that replay requests has smaller XID @@ -657,7 +670,13 @@ static int process_req_last_xid(struct ptlrpc_request *req) * - The former RPC got chance to be processed; */ if (!(lustre_msg_get_flags(req->rq_reqmsg) & MSG_REPLAY)) - RETURN(-EPROTO); + rc = -EPROTO; + + DEBUG_REQ(D_WARNING, req, + "unexpected xid=%llx != exp_last_xid=%llx, rc = %d", + req->rq_xid, exp->exp_last_xid, rc); + if (rc) + GOTO(out, rc); } /* The "last_xid" is the minimum xid among unreplied requests, @@ -670,19 +689,27 @@ static int process_req_last_xid(struct ptlrpc_request *req) * replay request will have the larger xid than "exp_last_xid" */ if (req->rq_export->exp_conn_cnt > - lustre_msg_get_conn_cnt(req->rq_reqmsg)) - RETURN(-ESTALE); + lustre_msg_get_conn_cnt(req->rq_reqmsg)) { + CDEBUG(D_RPCTRACE, + "Dropping request %llu from an old epoch %u/%u\n", + req->rq_xid, + lustre_msg_get_conn_cnt(req->rq_reqmsg), + req->rq_export->exp_conn_cnt); + req->rq_no_reply = 1; + GOTO(out, rc = -ESTALE); + } /* try to release in-memory reply data */ - if (tgt_is_multimodrpcs_client(req->rq_export)) { - tgt_handle_received_xid(req->rq_export, - lustre_msg_get_last_xid(req->rq_reqmsg)); - if (!(lustre_msg_get_flags(req->rq_reqmsg) & - (MSG_RESENT | MSG_REPLAY))) - tgt_handle_tag(req->rq_export, - lustre_msg_get_tag(req->rq_reqmsg)); + if (tgt_is_multimodrpcs_client(exp)) { + tgt_handle_received_xid(exp, last_xid); + rc = tgt_handle_tag(req); } - RETURN(0); + +out: + if (need_lock) + mutex_unlock(&ted->ted_lcd_lock); + + RETURN(rc); } int tgt_request_handle(struct ptlrpc_request *req) @@ -703,18 +730,12 @@ int tgt_request_handle(struct ptlrpc_request *req) if (cfs_fail_val == 0 && lustre_msg_get_opc(msg) != OBD_PING && lustre_msg_get_flags(msg) & MSG_REQ_REPLAY_DONE) { - struct l_wait_info lwi = { 0 }; - cfs_fail_val = 1; cfs_race_state = 0; - l_wait_event(cfs_race_waitq, (cfs_race_state == 1), - &lwi); + wait_event_idle(cfs_race_waitq, (cfs_race_state == 1)); } } - /* Refill the context, to make sure all thread keys are allocated */ - lu_env_refill(req->rq_svc_thread->t_env); - req_capsule_init(&req->rq_pill, req, RCL_SERVER); tsi->tsi_pill = &req->rq_pill; tsi->tsi_env = req->rq_svc_thread->t_env; @@ -760,7 +781,7 @@ int tgt_request_handle(struct ptlrpc_request *req) tsi->tsi_jobid = NULL; if (tgt == NULL) { - DEBUG_REQ(D_ERROR, req, "%s: No target for connected export\n", + DEBUG_REQ(D_ERROR, req, "%s: No target for connected export", class_exp2obd(req->rq_export)->obd_name); req->rq_status = -EINVAL; rc = ptlrpc_error(req); @@ -776,7 +797,7 @@ int tgt_request_handle(struct ptlrpc_request *req) /* reset the exp_last_xid on each connection. */ req->rq_export->exp_last_xid = 0; } else if (obd->obd_recovery_data.trd_processing_task != - current_pid()) { + current->pid) { rc = process_req_last_xid(req); if (rc) { req->rq_status = rc; @@ -804,9 +825,10 @@ int tgt_request_handle(struct ptlrpc_request *req) rc = lustre_msg_check_version(msg, h->th_version); if (unlikely(rc)) { - DEBUG_REQ(D_ERROR, req, "%s: drop mal-formed request, version" - " %08x, expecting %08x\n", tgt_name(tgt), - lustre_msg_get_version(msg), h->th_version); + DEBUG_REQ(D_ERROR, req, + "%s: drop malformed request version=%08x expect=%08x", + tgt_name(tgt), lustre_msg_get_version(msg), + h->th_version); req->rq_status = -EINVAL; rc = ptlrpc_error(req); GOTO(out, rc); @@ -878,9 +900,9 @@ EXPORT_SYMBOL(tgt_counter_incr); int tgt_connect_check_sptlrpc(struct ptlrpc_request *req, struct obd_export *exp) { - struct lu_target *tgt = class_exp2tgt(exp); - struct sptlrpc_flavor flvr; - int rc = 0; + struct lu_target *tgt = class_exp2tgt(exp); + struct sptlrpc_flavor flvr; + int rc = 0; LASSERT(tgt); LASSERT(tgt->lut_obd); @@ -905,13 +927,13 @@ int tgt_connect_check_sptlrpc(struct ptlrpc_request *req, struct obd_export *exp exp->exp_sp_peer = req->rq_sp_from; exp->exp_flvr = flvr; - /* when on mgs, if no restriction is set, or if client - * is loopback, allow any flavor */ + /* when on mgs, if no restriction is set, or if the client + * NID is on the local node, allow any flavor + */ if ((strcmp(exp->exp_obd->obd_type->typ_name, LUSTRE_MGS_NAME) == 0) && (exp->exp_flvr.sf_rpc == SPTLRPC_FLVR_NULL || - LNET_NETTYP(LNET_NIDNET(exp->exp_connection->c_peer.nid)) - == LOLND)) + LNetIsPeerLocal(exp->exp_connection->c_peer.nid))) exp->exp_flvr.sf_rpc = SPTLRPC_FLVR_ANY; if (exp->exp_flvr.sf_rpc != SPTLRPC_FLVR_ANY && @@ -1002,6 +1024,27 @@ int tgt_connect(struct tgt_session_info *tsi) rc = req_check_sepol(tsi->tsi_pill); if (rc) GOTO(out, rc); + + if (reply->ocd_connect_flags & OBD_CONNECT_FLAGS2 && + reply->ocd_connect_flags2 & OBD_CONNECT2_ENCRYPT && + tsi->tsi_pill->rc_req->rq_export) { + bool forbid_encrypt = true; + struct lu_nodemap *nm = + nodemap_get_from_exp(tsi->tsi_pill->rc_req->rq_export); + + if (!nm) { + /* nodemap_get_from_exp returns NULL in case + * nodemap is not active, so we do not forbid + */ + forbid_encrypt = false; + } else if (!IS_ERR(nm)) { + forbid_encrypt = nm->nmf_forbid_encryption; + nodemap_putref(nm); + } + + if (forbid_encrypt) + GOTO(out, rc = -EACCES); + } } RETURN(0); @@ -1060,19 +1103,27 @@ int tgt_obd_log_cancel(struct tgt_session_info *tsi) int tgt_send_buffer(struct tgt_session_info *tsi, struct lu_rdbuf *rdbuf) { - struct tgt_thread_info *tti = tgt_th_info(tsi->tsi_env); struct ptlrpc_request *req = tgt_ses_req(tsi); struct obd_export *exp = req->rq_export; struct ptlrpc_bulk_desc *desc; - struct l_wait_info *lwi = &tti->tti_u.update.tti_wait_info; int i; int rc; + int pages = 0; ENTRY; - desc = ptlrpc_prep_bulk_exp(req, rdbuf->rb_nbufs, 1, - PTLRPC_BULK_PUT_SOURCE | PTLRPC_BULK_BUF_KVEC, - MDS_BULK_PORTAL, &ptlrpc_bulk_kvec_ops); + for (i = 0; i < rdbuf->rb_nbufs; i++) { + unsigned int offset; + + offset = (unsigned long)rdbuf->rb_bufs[i].lb_buf & ~PAGE_MASK; + pages += DIV_ROUND_UP(rdbuf->rb_bufs[i].lb_len + offset, + PAGE_SIZE); + } + + desc = ptlrpc_prep_bulk_exp(req, pages, 1, + PTLRPC_BULK_PUT_SOURCE, + MDS_BULK_PORTAL, + &ptlrpc_bulk_kiov_nopin_ops); if (desc == NULL) RETURN(-ENOMEM); @@ -1081,7 +1132,7 @@ int tgt_send_buffer(struct tgt_session_info *tsi, struct lu_rdbuf *rdbuf) rdbuf->rb_bufs[i].lb_buf, rdbuf->rb_bufs[i].lb_len); - rc = target_bulk_io(exp, desc, lwi); + rc = target_bulk_io(exp, desc); ptlrpc_free_bulk(desc); RETURN(rc); } @@ -1089,11 +1140,9 @@ EXPORT_SYMBOL(tgt_send_buffer); int tgt_sendpage(struct tgt_session_info *tsi, struct lu_rdpg *rdpg, int nob) { - struct tgt_thread_info *tti = tgt_th_info(tsi->tsi_env); struct ptlrpc_request *req = tgt_ses_req(tsi); struct obd_export *exp = req->rq_export; struct ptlrpc_bulk_desc *desc; - struct l_wait_info *lwi = &tti->tti_u.rdpg.tti_wait_info; int tmpcount; int tmpsize; int i; @@ -1102,8 +1151,7 @@ int tgt_sendpage(struct tgt_session_info *tsi, struct lu_rdpg *rdpg, int nob) ENTRY; desc = ptlrpc_prep_bulk_exp(req, rdpg->rp_npages, 1, - PTLRPC_BULK_PUT_SOURCE | - PTLRPC_BULK_BUF_KIOV, + PTLRPC_BULK_PUT_SOURCE, MDS_BULK_PORTAL, &ptlrpc_bulk_kiov_pin_ops); if (desc == NULL) @@ -1122,7 +1170,7 @@ int tgt_sendpage(struct tgt_session_info *tsi, struct lu_rdpg *rdpg, int nob) } LASSERT(desc->bd_nob == nob); - rc = target_bulk_io(exp, desc, lwi); + rc = target_bulk_io(exp, desc); ptlrpc_free_bulk(desc); RETURN(rc); } @@ -1180,7 +1228,7 @@ static int tgt_obd_idx_read(struct tgt_session_info *tsi) rdpg->rp_npages = (rdpg->rp_count + PAGE_SIZE - 1) >> PAGE_SHIFT; /* allocate pages to store the containers */ - OBD_ALLOC(rdpg->rp_pages, rdpg->rp_npages * sizeof(rdpg->rp_pages[0])); + OBD_ALLOC_PTR_ARRAY(rdpg->rp_pages, rdpg->rp_npages); if (rdpg->rp_pages == NULL) GOTO(out, rc = -ENOMEM); for (i = 0; i < rdpg->rp_npages; i++) { @@ -1207,8 +1255,7 @@ out: for (i = 0; i < rdpg->rp_npages; i++) if (rdpg->rp_pages[i]) __free_page(rdpg->rp_pages[i]); - OBD_FREE(rdpg->rp_pages, - rdpg->rp_npages * sizeof(rdpg->rp_pages[0])); + OBD_FREE_PTR_ARRAY(rdpg->rp_pages, rdpg->rp_npages); } return rc; } @@ -1278,8 +1325,8 @@ static int tgt_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc, if (flag == LDLM_CB_CANCELING && (lock->l_granted_mode & (LCK_EX | LCK_PW | LCK_GROUP)) && - (tgt->lut_sync_lock_cancel == ALWAYS_SYNC_ON_CANCEL || - (tgt->lut_sync_lock_cancel == BLOCKING_SYNC_ON_CANCEL && + (tgt->lut_sync_lock_cancel == SYNC_LOCK_CANCEL_ALWAYS || + (tgt->lut_sync_lock_cancel == SYNC_LOCK_CANCEL_BLOCKING && ldlm_is_cbpending(lock))) && ((exp_connect_flags(lock->l_export) & OBD_CONNECT_MDS_MDS) || lock->l_resource->lr_type == LDLM_EXTENT)) { @@ -1631,13 +1678,6 @@ int tgt_mdt_data_lock(struct ldlm_namespace *ns, struct ldlm_res_id *res_id, } EXPORT_SYMBOL(tgt_mdt_data_lock); -void tgt_mdt_data_unlock(struct lustre_handle *lh, enum ldlm_mode mode) -{ - LASSERT(lustre_handle_is_used(lh)); - ldlm_lock_decref(lh, mode); -} -EXPORT_SYMBOL(tgt_mdt_data_unlock); - /** * Helper function for getting server side [start, start+count] DLM lock * if asked by client. @@ -1675,30 +1715,41 @@ int tgt_extent_lock(const struct lu_env *env, struct ldlm_namespace *ns, } EXPORT_SYMBOL(tgt_extent_lock); -void tgt_extent_unlock(struct lustre_handle *lh, enum ldlm_mode mode) +static int tgt_data_lock(const struct lu_env *env, struct obd_export *exp, + struct ldlm_res_id *res_id, __u64 start, __u64 end, + struct lustre_handle *lh, enum ldlm_mode mode) +{ + struct ldlm_namespace *ns = exp->exp_obd->obd_namespace; + __u64 flags = 0; + + /* MDT IO for data-on-mdt */ + if (exp->exp_connect_data.ocd_connect_flags & OBD_CONNECT_IBITS) + return tgt_mdt_data_lock(ns, res_id, lh, mode, &flags); + + return tgt_extent_lock(env, ns, res_id, start, end, lh, mode, &flags); +} + +void tgt_data_unlock(struct lustre_handle *lh, enum ldlm_mode mode) { LASSERT(lustre_handle_is_used(lh)); ldlm_lock_decref(lh, mode); } -EXPORT_SYMBOL(tgt_extent_unlock); +EXPORT_SYMBOL(tgt_data_unlock); static int tgt_brw_lock(const struct lu_env *env, struct obd_export *exp, struct ldlm_res_id *res_id, struct obd_ioobj *obj, struct niobuf_remote *nb, struct lustre_handle *lh, enum ldlm_mode mode) { - struct ldlm_namespace *ns = exp->exp_obd->obd_namespace; - __u64 flags = 0; - int nrbufs = obj->ioo_bufcnt; - int i; - int rc; + int nrbufs = obj->ioo_bufcnt; + int i; ENTRY; LASSERT(mode == LCK_PR || mode == LCK_PW); LASSERT(!lustre_handle_is_used(lh)); - if (ns->ns_obd->obd_recovering) + if (exp->exp_obd->obd_recovering) RETURN(0); if (nrbufs == 0 || !(nb[0].rnb_flags & OBD_BRW_SRVLOCK)) @@ -1708,31 +1759,27 @@ static int tgt_brw_lock(const struct lu_env *env, struct obd_export *exp, if (!(nb[i].rnb_flags & OBD_BRW_SRVLOCK)) RETURN(-EFAULT); - /* MDT IO for data-on-mdt */ - if (exp->exp_connect_data.ocd_connect_flags & OBD_CONNECT_IBITS) - rc = tgt_mdt_data_lock(ns, res_id, lh, mode, &flags); - else - rc = tgt_extent_lock(env, ns, res_id, nb[0].rnb_offset, - nb[nrbufs - 1].rnb_offset + - nb[nrbufs - 1].rnb_len - 1, - lh, mode, &flags); - RETURN(rc); + return tgt_data_lock(env, exp, res_id, nb[0].rnb_offset, + nb[nrbufs - 1].rnb_offset + + nb[nrbufs - 1].rnb_len - 1, lh, mode); } -static void tgt_brw_unlock(struct obd_ioobj *obj, struct niobuf_remote *niob, +static void tgt_brw_unlock(struct obd_export *exp, struct obd_ioobj *obj, + struct niobuf_remote *niob, struct lustre_handle *lh, enum ldlm_mode mode) { ENTRY; LASSERT(mode == LCK_PR || mode == LCK_PW); - LASSERT((obj->ioo_bufcnt > 0 && - (niob[0].rnb_flags & OBD_BRW_SRVLOCK)) == + LASSERT((!exp->exp_obd->obd_recovering && obj->ioo_bufcnt && + niob[0].rnb_flags & OBD_BRW_SRVLOCK) == lustre_handle_is_used(lh)); if (lustre_handle_is_used(lh)) - tgt_extent_unlock(lh, mode); + tgt_data_unlock(lh, mode); EXIT; } + static int tgt_checksum_niobuf(struct lu_target *tgt, struct niobuf_local *local_nb, int npages, int opc, enum cksum_types cksum_type, @@ -1761,13 +1808,12 @@ static int tgt_checksum_niobuf(struct lu_target *tgt, struct page *np = tgt_page_to_corrupt; if (np) { - char *ptr = ll_kmap_atomic(local_nb[i].lnb_page, - KM_USER0); + char *ptr = kmap_atomic(local_nb[i].lnb_page); char *ptr2 = page_address(np); memcpy(ptr2 + off, ptr + off, len); memcpy(ptr2 + off, "bad3", min(4, len)); - ll_kunmap_atomic(ptr, KM_USER0); + kunmap_atomic(ptr); /* LU-8376 to preserve original index for * display in dump_all_bulk_pages() */ @@ -1794,13 +1840,12 @@ static int tgt_checksum_niobuf(struct lu_target *tgt, struct page *np = tgt_page_to_corrupt; if (np) { - char *ptr = ll_kmap_atomic(local_nb[i].lnb_page, - KM_USER0); + char *ptr = kmap_atomic(local_nb[i].lnb_page); char *ptr2 = page_address(np); memcpy(ptr2 + off, ptr + off, len); memcpy(ptr2 + off, "bad4", min(4, len)); - ll_kunmap_atomic(ptr, KM_USER0); + kunmap_atomic(ptr); /* LU-8376 to preserve original index for * display in dump_all_bulk_pages() */ @@ -1882,7 +1927,6 @@ static void dump_all_bulk_pages(struct obdo *oa, int count, if (rc) CERROR("%s: sync returns %d\n", dbgcksum_file_name, rc); filp_close(filp, NULL); - return; } static int check_read_checksum(struct niobuf_local *local_nb, int npages, @@ -1950,9 +1994,9 @@ static int tgt_pages2shortio(struct niobuf_local *local, int npages, if (len > size) return -EINVAL; - ptr = ll_kmap_atomic(local[i].lnb_page, KM_USER0); - memcpy(buf + off, ptr, len); - ll_kunmap_atomic(ptr, KM_USER0); + ptr = kmap_atomic(local[i].lnb_page); + memcpy(buf, ptr + off, len); + kunmap_atomic(ptr); buf += len; size -= len; } @@ -2005,13 +2049,12 @@ static int tgt_checksum_niobuf_t10pi(struct lu_target *tgt, struct page *np = tgt_page_to_corrupt; if (np) { - char *ptr = ll_kmap_atomic(local_nb[i].lnb_page, - KM_USER0); + char *ptr = kmap_atomic(local_nb[i].lnb_page); char *ptr2 = page_address(np); memcpy(ptr2 + off, ptr + off, len); memcpy(ptr2 + off, "bad3", min(4, len)); - ll_kunmap_atomic(ptr, KM_USER0); + kunmap_atomic(ptr); /* LU-8376 to preserve original index for * display in dump_all_bulk_pages() */ @@ -2031,6 +2074,7 @@ static int tgt_checksum_niobuf_t10pi(struct lu_target *tgt, * whole page */ if (t10_cksum_type && opc == OST_READ && + local_nb[i].lnb_len == PAGE_SIZE && local_nb[i].lnb_guard_disk) { used = DIV_ROUND_UP(local_nb[i].lnb_len, sector_size); if (used > (guard_number - used_number)) { @@ -2086,13 +2130,12 @@ static int tgt_checksum_niobuf_t10pi(struct lu_target *tgt, struct page *np = tgt_page_to_corrupt; if (np) { - char *ptr = ll_kmap_atomic(local_nb[i].lnb_page, - KM_USER0); + char *ptr = kmap_atomic(local_nb[i].lnb_page); char *ptr2 = page_address(np); memcpy(ptr2 + off, ptr + off, len); memcpy(ptr2 + off, "bad4", min(4, len)); - ll_kunmap_atomic(ptr, KM_USER0); + kunmap_atomic(ptr); /* LU-8376 to preserve original index for * display in dump_all_bulk_pages() */ @@ -2156,7 +2199,6 @@ int tgt_brw_read(struct tgt_session_info *tsi) struct niobuf_local *local_nb; struct obd_ioobj *ioo; struct ost_body *body, *repbody; - struct l_wait_info lwi; struct lustre_handle lockh = { 0 }; int npages, nob = 0, rc, i, no_reply = 0, npages_read; @@ -2186,10 +2228,9 @@ int tgt_brw_read(struct tgt_session_info *tsi) * finish */ if (unlikely(atomic_read(&exp->exp_obd->obd_evict_inprogress))) { /* We do not care how long it takes */ - lwi = LWI_INTR(NULL, NULL); - rc = l_wait_event(exp->exp_obd->obd_evict_inprogress_waitq, - !atomic_read(&exp->exp_obd->obd_evict_inprogress), - &lwi); + wait_event_idle( + exp->exp_obd->obd_evict_inprogress_waitq, + !atomic_read(&exp->exp_obd->obd_evict_inprogress)); } /* There must be big cache in current thread to process this request @@ -2237,12 +2278,12 @@ int tgt_brw_read(struct tgt_session_info *tsi) if (rc != 0) GOTO(out_lock, rc); - if (body->oa.o_flags & OBD_FL_SHORT_IO) { + if (body->oa.o_valid & OBD_MD_FLFLAGS && + body->oa.o_flags & OBD_FL_SHORT_IO) { desc = NULL; } else { desc = ptlrpc_prep_bulk_exp(req, npages, ioobj_max_brw_get(ioo), - PTLRPC_BULK_PUT_SOURCE | - PTLRPC_BULK_BUF_KIOV, + PTLRPC_BULK_PUT_SOURCE, OST_BULK_PORTAL, &ptlrpc_bulk_kiov_nopin_ops); if (desc == NULL) @@ -2278,9 +2319,6 @@ int tgt_brw_read(struct tgt_session_info *tsi) break; } } - if (OBD_FAIL_CHECK(OBD_FAIL_OST_READ_SIZE) && - nob != cfs_fail_val) - rc = -E2BIG; if (body->oa.o_valid & OBD_MD_FLCKSUM) { u32 flag = body->oa.o_valid & OBD_MD_FLFLAGS ? @@ -2316,7 +2354,8 @@ int tgt_brw_read(struct tgt_session_info *tsi) /* Check if client was evicted while we were doing i/o before touching * network */ if (rc == 0) { - if (body->oa.o_flags & OBD_FL_SHORT_IO) { + if (body->oa.o_valid & OBD_MD_FLFLAGS && + body->oa.o_flags & OBD_FL_SHORT_IO) { unsigned char *short_io_buf; int short_io_size; @@ -2333,11 +2372,12 @@ int tgt_brw_read(struct tgt_session_info *tsi) RCL_SERVER); rc = rc > 0 ? 0 : rc; } else if (!CFS_FAIL_PRECHECK(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2)) { - rc = target_bulk_io(exp, desc, &lwi); + rc = target_bulk_io(exp, desc); } no_reply = rc != 0; } else { - if (body->oa.o_flags & OBD_FL_SHORT_IO) + if (body->oa.o_valid & OBD_MD_FLFLAGS && + body->oa.o_flags & OBD_FL_SHORT_IO) req_capsule_shrink(&req->rq_pill, &RMF_SHORT_IO, 0, RCL_SERVER); } @@ -2347,7 +2387,7 @@ out_commitrw: rc = obd_commitrw(tsi->tsi_env, OBD_BRW_READ, exp, &repbody->oa, 1, ioo, remote_nb, npages, local_nb, rc); out_lock: - tgt_brw_unlock(ioo, remote_nb, &lockh, LCK_PR); + tgt_brw_unlock(exp, ioo, remote_nb, &lockh, LCK_PR); if (desc && !CFS_FAIL_PRECHECK(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2)) ptlrpc_free_bulk(desc); @@ -2371,15 +2411,10 @@ out_lock: * to reorder. */ if (unlikely(CFS_FAIL_PRECHECK(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2)) && desc) { - wait_queue_head_t waitq; - struct l_wait_info lwi1; - CDEBUG(D_INFO, "reorder BULK\n"); - init_waitqueue_head(&waitq); - lwi1 = LWI_TIMEOUT_INTR(cfs_time_seconds(3), NULL, NULL, NULL); - l_wait_event(waitq, 0, &lwi1); - target_bulk_io(exp, desc, &lwi); + ssleep(3); + target_bulk_io(exp, desc); ptlrpc_free_bulk(desc); } @@ -2402,11 +2437,11 @@ static int tgt_shortio2pages(struct niobuf_local *local, int npages, CDEBUG(D_PAGE, "index %d offset = %d len = %d left = %d\n", i, off, len, size); - ptr = ll_kmap_atomic(local[i].lnb_page, KM_USER0); + ptr = kmap_atomic(local[i].lnb_page); if (ptr == NULL) return -EINVAL; memcpy(ptr + off, buf, len < size ? len : size); - ll_kunmap_atomic(ptr, KM_USER0); + kunmap_atomic(ptr); buf += len; size -= len; } @@ -2469,7 +2504,6 @@ int tgt_brw_write(struct tgt_session_info *tsi) struct niobuf_local *local_nb; struct obd_ioobj *ioo; struct ost_body *body, *repbody; - struct l_wait_info lwi; struct lustre_handle lockh = {0}; __u32 *rcs; int objcount, niocount, npages; @@ -2479,6 +2513,8 @@ int tgt_brw_write(struct tgt_session_info *tsi) struct tgt_thread_big_cache *tbc = req->rq_svc_thread->t_data; bool wait_sync = false; const char *obd_name = exp->exp_obd->obd_name; + /* '1' for consistency with code that checks !mpflag to restore */ + unsigned int mpflags = 1; ENTRY; @@ -2507,6 +2543,9 @@ int tgt_brw_write(struct tgt_session_info *tsi) CFS_FAIL_TIMEOUT(OBD_FAIL_OST_BRW_PAUSE_BULK, cfs_fail_val > 0 ? cfs_fail_val : (obd_timeout + 1) / 4); + /* Delay write commit to show stale size information */ + CFS_FAIL_TIMEOUT(OBD_FAIL_OSC_NO_SIZE_DATA, cfs_fail_val); + /* There must be big cache in current thread to process this request * if it is NULL then something went wrong and it wasn't allocated, * report -ENOMEM in that case */ @@ -2534,7 +2573,7 @@ int tgt_brw_write(struct tgt_session_info *tsi) if ((remote_nb[0].rnb_flags & OBD_BRW_MEMALLOC) && ptlrpc_connection_is_local(exp->exp_connection)) - memory_pressure_set(); + mpflags = memalloc_noreclaim_save(); req_capsule_set_size(&req->rq_pill, &RMF_RCS, RCL_SERVER, niocount * sizeof(*rcs)); @@ -2585,7 +2624,8 @@ int tgt_brw_write(struct tgt_session_info *tsi) objcount, ioo, remote_nb, &npages, local_nb); if (rc < 0) GOTO(out_lock, rc); - if (body->oa.o_flags & OBD_FL_SHORT_IO) { + if (body->oa.o_valid & OBD_MD_FLFLAGS && + body->oa.o_flags & OBD_FL_SHORT_IO) { unsigned int short_io_size; unsigned char *short_io_buf; @@ -2603,8 +2643,7 @@ int tgt_brw_write(struct tgt_session_info *tsi) desc = NULL; } else { desc = ptlrpc_prep_bulk_exp(req, npages, ioobj_max_brw_get(ioo), - PTLRPC_BULK_GET_SINK | - PTLRPC_BULK_BUF_KIOV, + PTLRPC_BULK_GET_SINK, OST_BULK_PORTAL, &ptlrpc_bulk_kiov_nopin_ops); if (desc == NULL) @@ -2621,7 +2660,7 @@ int tgt_brw_write(struct tgt_session_info *tsi) if (rc != 0) GOTO(skip_transfer, rc); - rc = target_bulk_io(exp, desc, &lwi); + rc = target_bulk_io(exp, desc); } no_reply = rc != 0; @@ -2662,6 +2701,8 @@ skip_transfer: } } + OBD_FAIL_TIMEOUT(OBD_FAIL_OST_BRW_PAUSE_BULK2, cfs_fail_val); + out_commitrw: /* Must commit after prep above in all cases */ rc = obd_commitrw(tsi->tsi_env, OBD_BRW_WRITE, exp, &repbody->oa, @@ -2707,7 +2748,7 @@ out_commitrw: ptlrpc_lprocfs_brw(req, nob); } out_lock: - tgt_brw_unlock(ioo, remote_nb, &lockh, LCK_PW); + tgt_brw_unlock(exp, ioo, remote_nb, &lockh, LCK_PW); if (desc) ptlrpc_free_bulk(desc); out: @@ -2722,20 +2763,89 @@ out: obd_uuid2str(&exp->exp_client_uuid), obd_export_nid2str(exp), rc); } - memory_pressure_clr(); + + if (mpflags) + memalloc_noreclaim_restore(mpflags); + RETURN(rc); } EXPORT_SYMBOL(tgt_brw_write); +/** + * Common request handler for OST_SEEK RPC. + * + * Unified request handling for OST_SEEK RPC. + * It takes object by its FID, does needed lseek and packs result + * into reply. Only SEEK_HOLE and SEEK_DATA are supported. + * + * \param[in] tsi target session environment for this request + * + * \retval 0 if successful + * \retval negative value on error + */ +int tgt_lseek(struct tgt_session_info *tsi) +{ + struct lustre_handle lh = { 0 }; + struct dt_object *dob; + struct ost_body *repbody; + loff_t offset = tsi->tsi_ost_body->oa.o_size; + int whence = tsi->tsi_ost_body->oa.o_mode; + bool srvlock; + int rc = 0; + + ENTRY; + + if (whence != SEEK_HOLE && whence != SEEK_DATA) + RETURN(-EPROTO); + + /* Negative offset is prohibited on wire and must be handled on client + * prior sending RPC. + */ + if (offset < 0) + RETURN(-EPROTO); + + repbody = req_capsule_server_get(tsi->tsi_pill, &RMF_OST_BODY); + if (repbody == NULL) + RETURN(-ENOMEM); + repbody->oa = tsi->tsi_ost_body->oa; + + srvlock = tsi->tsi_ost_body->oa.o_valid & OBD_MD_FLFLAGS && + tsi->tsi_ost_body->oa.o_flags & OBD_FL_SRVLOCK; + if (srvlock) { + rc = tgt_data_lock(tsi->tsi_env, tsi->tsi_exp, &tsi->tsi_resid, + offset, OBD_OBJECT_EOF, &lh, LCK_PR); + if (rc) + RETURN(rc); + } + + dob = dt_locate(tsi->tsi_env, tsi->tsi_tgt->lut_bottom, &tsi->tsi_fid); + if (IS_ERR(dob)) + GOTO(out, rc = PTR_ERR(dob)); + + if (!dt_object_exists(dob)) + GOTO(obj_put, rc = -ENOENT); + + repbody->oa.o_size = dt_lseek(tsi->tsi_env, dob, offset, whence); + rc = 0; +obj_put: + dt_object_put(tsi->tsi_env, dob); +out: + if (srvlock) + tgt_data_unlock(&lh, LCK_PR); + + RETURN(rc); +} +EXPORT_SYMBOL(tgt_lseek); + /* Check if request can be reconstructed from saved reply data * A copy of the reply data is returned in @trd if the pointer is not NULL */ -bool req_can_reconstruct(struct ptlrpc_request *req, +int req_can_reconstruct(struct ptlrpc_request *req, struct tg_reply_data *trd) { struct tg_export_data *ted = &req->rq_export->exp_target_data; struct lsd_client_data *lcd = ted->ted_lcd; - bool found; + int found; if (tgt_is_multimodrpcs_client(req->rq_export)) return tgt_lookup_reply(req, trd);