X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lustre%2Fmdt%2Fmdt_xattr.c;h=a7c69cfa8d5c4e8dfd8e1fd1cdde48dc3b08a7cd;hp=8185a558d0446cbbf653361029b26efbea2fb3b5;hb=b046468f58a1f40e85cb59ed9abf75fd2fd5ea5a;hpb=08aa217ce49aba1ded52e0f7adb8a607035123fd diff --git a/lustre/mdt/mdt_xattr.c b/lustre/mdt/mdt_xattr.c index 8185a55..a7c69cf 100644 --- a/lustre/mdt/mdt_xattr.c +++ b/lustre/mdt/mdt_xattr.c @@ -27,7 +27,7 @@ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved. * Use is subject to license terms. * - * Copyright (c) 2011, Intel Corporation. + * Copyright (c) 2011, 2014, Intel Corporation. */ /* * This file is part of Lustre, http://www.lustre.org/ @@ -45,6 +45,9 @@ #define DEBUG_SUBSYSTEM S_MDS +#include +#include +#include #include #include "mdt_internal.h" @@ -55,7 +58,7 @@ static int mdt_getxattr_pack_reply(struct mdt_thread_info * info) struct req_capsule *pill = info->mti_pill ; struct ptlrpc_request *req = mdt_info_req(info); char *xattr_name; - __u64 valid = info->mti_body->valid; + __u64 valid; static const char user_string[] = "user."; int size, rc; ENTRY; @@ -63,41 +66,48 @@ static int mdt_getxattr_pack_reply(struct mdt_thread_info * info) if (OBD_FAIL_CHECK(OBD_FAIL_MDS_GETXATTR_PACK)) RETURN(-ENOMEM); + valid = info->mti_body->mbo_valid & (OBD_MD_FLXATTR | OBD_MD_FLXATTRLS); + /* Determine how many bytes we need */ - if (valid & OBD_MD_FLXATTR) { + if (valid == OBD_MD_FLXATTR) { xattr_name = req_capsule_client_get(pill, &RMF_NAME); if (!xattr_name) RETURN(-EFAULT); - if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR) && - !strncmp(xattr_name, user_string, sizeof(user_string) - 1)) - RETURN(-EOPNOTSUPP); + if (!(exp_connect_flags(req->rq_export) & OBD_CONNECT_XATTR) && + !strncmp(xattr_name, user_string, sizeof(user_string) - 1)) + RETURN(-EOPNOTSUPP); size = mo_xattr_get(info->mti_env, mdt_object_child(info->mti_object), &LU_BUF_NULL, xattr_name); - } else if (valid & OBD_MD_FLXATTRLS) { + } else if (valid == OBD_MD_FLXATTRLS) { size = mo_xattr_list(info->mti_env, mdt_object_child(info->mti_object), &LU_BUF_NULL); - } else { - CDEBUG(D_INFO, "Valid bits: "LPX64"\n", info->mti_body->valid); + } else if (valid == OBD_MD_FLXATTRALL) { + /* N.B. eadatasize = 0 is not valid for FLXATTRALL */ + /* We could calculate accurate sizes, but this would + * introduce a lot of overhead, let's do it later... */ + size = info->mti_body->mbo_eadatasize; + req_capsule_set_size(pill, &RMF_EAVALS, RCL_SERVER, size); + req_capsule_set_size(pill, &RMF_EAVALS_LENS, RCL_SERVER, size); + } else { + CDEBUG(D_INFO, "Valid bits: "LPX64"\n", + info->mti_body->mbo_valid); RETURN(-EINVAL); } - if (size == -ENODATA) { - size = 0; - } else if (size < 0) { - CERROR("Error geting EA size: %d\n", size); - RETURN(size); - } - - if (info->mti_body->eadatasize != 0 && - info->mti_body->eadatasize < size) - RETURN(-ERANGE); + if (size == -ENODATA) { + size = 0; + } else if (size < 0) { + if (size != -EOPNOTSUPP) + CERROR("Error geting EA size: %d\n", size); + RETURN(size); + } req_capsule_set_size(pill, &RMF_EADATA, RCL_SERVER, - info->mti_body->eadatasize == 0 ? 0 : size); + info->mti_body->mbo_eadatasize == 0 ? 0 : size); rc = req_capsule_server_pack(pill); if (rc) { LASSERT(rc < 0); @@ -107,11 +117,118 @@ static int mdt_getxattr_pack_reply(struct mdt_thread_info * info) RETURN(size); } -int mdt_getxattr(struct mdt_thread_info *info) +static int +mdt_getxattr_one(struct mdt_thread_info *info, + char *xattr_name, struct md_object *next, + struct lu_buf *buf, struct mdt_export_data *med, + struct lu_ucred *uc) { - struct ptlrpc_request *req = mdt_info_req(info); - struct mdt_export_data *med = mdt_req2med(req); + __u32 remote = exp_connect_rmtclient(info->mti_exp); + int flags = CFS_IC_NOTHING, rc; + + ENTRY; + + CDEBUG(D_INODE, "getxattr %s\n", xattr_name); + + rc = mo_xattr_get(info->mti_env, next, buf, xattr_name); + if (rc < 0) + GOTO(out, rc); + + if (info->mti_body->mbo_valid & + (OBD_MD_FLRMTLSETFACL | OBD_MD_FLRMTLGETFACL)) + flags = CFS_IC_ALL; + else if (info->mti_body->mbo_valid & OBD_MD_FLRMTRGETFACL) + flags = CFS_IC_MAPPED; + + if (rc > 0 && flags != CFS_IC_NOTHING) { + int rc1; + + if (unlikely(!remote)) + GOTO(out, rc = -EINVAL); + + rc1 = lustre_posix_acl_xattr_id2client(uc, + med->med_idmap, + (posix_acl_xattr_header *)(buf->lb_buf), + rc, flags); + if (unlikely(rc1 < 0)) + rc = rc1; + } + +out: + return rc; +} + +static int mdt_getxattr_all(struct mdt_thread_info *info, + struct mdt_body *reqbody, struct mdt_body *repbody, + struct lu_buf *buf, struct md_object *next) +{ + const struct lu_env *env = info->mti_env; + struct ptlrpc_request *req = mdt_info_req(info); + struct mdt_export_data *med = mdt_req2med(req); struct lu_ucred *uc = mdt_ucred(info); + char *v, *b, *eadatahead, *eadatatail; + __u32 *sizes; + int eadatasize, eavallen = 0, eavallens = 0, rc; + + ENTRY; + + /* + * The format of the pill is the following: + * EADATA: attr1\0attr2\0...attrn\0 + * EAVALS: val1val2...valn + * EAVALS_LENS: 4,4,...4 + */ + + eadatahead = buf->lb_buf; + + /* Fill out EADATA first */ + rc = mo_xattr_list(env, next, buf); + if (rc < 0) + GOTO(out_shrink, rc); + + eadatasize = rc; + eadatatail = eadatahead + eadatasize; + + v = req_capsule_server_get(info->mti_pill, &RMF_EAVALS); + sizes = req_capsule_server_get(info->mti_pill, &RMF_EAVALS_LENS); + + /* Fill out EAVALS and EAVALS_LENS */ + for (b = eadatahead; b < eadatatail; b += strlen(b) + 1, v += rc) { + buf->lb_buf = v; + buf->lb_len = reqbody->mbo_eadatasize - eavallen; + rc = mdt_getxattr_one(info, b, next, buf, med, uc); + if (rc < 0) + GOTO(out_shrink, rc); + + sizes[eavallens] = rc; + eavallens++; + eavallen += rc; + } + +out_shrink: + if (rc < 0) { + eadatasize = 0; + eavallens = 0; + eavallen = 0; + } + repbody->mbo_aclsize = eavallen; + repbody->mbo_max_mdsize = eavallens; + + req_capsule_shrink(info->mti_pill, &RMF_EAVALS, eavallen, RCL_SERVER); + req_capsule_shrink(info->mti_pill, &RMF_EAVALS_LENS, + eavallens * sizeof(__u32), RCL_SERVER); + req_capsule_shrink(info->mti_pill, &RMF_EADATA, eadatasize, RCL_SERVER); + + if (rc >= 0) + RETURN(eadatasize); + return rc; +} + +int mdt_getxattr(struct mdt_thread_info *info) +{ + struct ptlrpc_request *req = mdt_info_req(info); + struct mdt_export_data *med = mdt_req2med(req); + struct lu_ucred *uc = lu_ucred(info->mti_env); struct mdt_body *reqbody; struct mdt_body *repbody = NULL; struct md_object *next; @@ -119,12 +236,13 @@ int mdt_getxattr(struct mdt_thread_info *info) __u32 remote = exp_connect_rmtclient(info->mti_exp); __u32 perm; int easize, rc; + u64 valid; ENTRY; LASSERT(info->mti_object != NULL); - LASSERT(lu_object_assert_exists(&info->mti_object->mot_obj.mo_lu)); + LASSERT(lu_object_assert_exists(&info->mti_object->mot_obj)); - CDEBUG(D_INODE, "getxattr "DFID"\n", PFID(&info->mti_body->fid1)); + CDEBUG(D_INODE, "getxattr "DFID"\n", PFID(&info->mti_body->mbo_fid1)); reqbody = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY); if (reqbody == NULL) @@ -136,7 +254,7 @@ int mdt_getxattr(struct mdt_thread_info *info) next = mdt_object_child(info->mti_object); - if (info->mti_body->valid & OBD_MD_FLRMTRGETFACL) { + if (info->mti_body->mbo_valid & OBD_MD_FLRMTRGETFACL) { if (unlikely(!remote)) GOTO(out, rc = err_serious(-EINVAL)); @@ -159,63 +277,40 @@ int mdt_getxattr(struct mdt_thread_info *info) LASSERT(repbody != NULL); /* No need further getxattr. */ - if (easize == 0 || reqbody->eadatasize == 0) - GOTO(out, rc = easize); - - - buf = &info->mti_buf; - buf->lb_buf = req_capsule_server_get(info->mti_pill, &RMF_EADATA); - buf->lb_len = easize; - - if (info->mti_body->valid & OBD_MD_FLXATTR) { - int flags = CFS_IC_NOTHING; - char *xattr_name = req_capsule_client_get(info->mti_pill, - &RMF_NAME); - CDEBUG(D_INODE, "getxattr %s\n", xattr_name); - - rc = mo_xattr_get(info->mti_env, next, buf, xattr_name); - if (rc < 0) { - CERROR("getxattr failed: %d\n", rc); - GOTO(out, rc); - } - - if (info->mti_body->valid & - (OBD_MD_FLRMTLSETFACL | OBD_MD_FLRMTLGETFACL)) - flags = CFS_IC_ALL; - else if (info->mti_body->valid & OBD_MD_FLRMTRGETFACL) - flags = CFS_IC_MAPPED; - - if (rc > 0 && flags != CFS_IC_NOTHING) { - int rc1; - - if (unlikely(!remote)) - GOTO(out, rc = -EINVAL); - - rc1 = lustre_posix_acl_xattr_id2client(uc, - med->med_idmap, - (posix_acl_xattr_header *)(buf->lb_buf), - rc, flags); - if (unlikely(rc1 < 0)) - rc = rc1; - } - } else if (info->mti_body->valid & OBD_MD_FLXATTRLS) { - CDEBUG(D_INODE, "listxattr\n"); - - rc = mo_xattr_list(info->mti_env, next, buf); - if (rc < 0) - CDEBUG(D_INFO, "listxattr failed: %d\n", rc); - } else - LBUG(); - - EXIT; + if (easize == 0 || reqbody->mbo_eadatasize == 0) + GOTO(out, rc = easize); + + buf = &info->mti_buf; + buf->lb_buf = req_capsule_server_get(info->mti_pill, &RMF_EADATA); + buf->lb_len = easize; + + valid = info->mti_body->mbo_valid & (OBD_MD_FLXATTR | OBD_MD_FLXATTRLS); + + if (valid == OBD_MD_FLXATTR) { + char *xattr_name = req_capsule_client_get(info->mti_pill, + &RMF_NAME); + rc = mdt_getxattr_one(info, xattr_name, next, buf, med, uc); + } else if (valid == OBD_MD_FLXATTRLS) { + CDEBUG(D_INODE, "listxattr\n"); + + rc = mo_xattr_list(info->mti_env, next, buf); + if (rc < 0) + CDEBUG(D_INFO, "listxattr failed: %d\n", rc); + } else if (valid == OBD_MD_FLXATTRALL) { + rc = mdt_getxattr_all(info, reqbody, repbody, + buf, next); + } else + LBUG(); + + EXIT; out: - if (rc >= 0) { + if (rc >= 0) { mdt_counter_incr(req, LPROC_MDT_GETXATTR); - repbody->eadatasize = rc; - rc = 0; - } - mdt_exit_ucred(info); - return rc; + repbody->mbo_eadatasize = rc; + rc = 0; + } + mdt_exit_ucred(info); + return rc; } static int mdt_rmtlsetfacl(struct mdt_thread_info *info, @@ -268,34 +363,37 @@ _out: int mdt_reint_setxattr(struct mdt_thread_info *info, struct mdt_lock_handle *unused) { - struct ptlrpc_request *req = mdt_info_req(info); - struct lu_ucred *uc = mdt_ucred(info); - struct mdt_lock_handle *lh; - const struct lu_env *env = info->mti_env; - struct lu_buf *buf = &info->mti_buf; - struct mdt_reint_record *rr = &info->mti_rr; - struct md_attr *ma = &info->mti_attr; - struct lu_attr *attr = &info->mti_attr.ma_attr; - struct mdt_object *obj; - struct md_object *child; - __u64 valid = attr->la_valid; - const char *xattr_name = rr->rr_name; - int xattr_len = rr->rr_eadatalen; - __u64 lockpart; - int rc; - posix_acl_xattr_header *new_xattr = NULL; - __u32 remote = exp_connect_rmtclient(info->mti_exp); - __u32 perm; - ENTRY; - - CDEBUG(D_INODE, "setxattr for "DFID"\n", PFID(rr->rr_fid1)); + struct ptlrpc_request *req = mdt_info_req(info); + struct lu_ucred *uc = lu_ucred(info->mti_env); + struct mdt_lock_handle *lh; + const struct lu_env *env = info->mti_env; + struct lu_buf *buf = &info->mti_buf; + struct mdt_reint_record *rr = &info->mti_rr; + struct md_attr *ma = &info->mti_attr; + struct lu_attr *attr = &info->mti_attr.ma_attr; + struct mdt_object *obj; + struct md_object *child; + struct obd_export *exp = info->mti_exp; + struct lu_nodemap *nodemap = exp->exp_target_data.ted_nodemap; + __u64 valid = attr->la_valid; + const char *xattr_name = rr->rr_name.ln_name; + int xattr_len = rr->rr_eadatalen; + __u64 lockpart; + int rc; + posix_acl_xattr_header *new_xattr = NULL; + __u32 remote = exp_connect_rmtclient(info->mti_exp); + __u32 perm; + ENTRY; + + CDEBUG(D_INODE, "setxattr for "DFID": %s %s\n", PFID(rr->rr_fid1), + valid & OBD_MD_FLXATTR ? "set" : "remove", xattr_name); + + if (info->mti_dlm_req) + ldlm_request_cancel(req, info->mti_dlm_req, 0, LATF_SKIP); if (OBD_FAIL_CHECK(OBD_FAIL_MDS_SETXATTR)) RETURN(err_serious(-ENOMEM)); - CDEBUG(D_INODE, "%s xattr %s\n", - valid & OBD_MD_FLXATTR ? "set" : "remove", xattr_name); - rc = mdt_init_ucred_reint(info); if (rc != 0) RETURN(rc); @@ -306,29 +404,52 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, perm = mdt_identity_get_perm(uc->uc_identity, remote, req->rq_peer.nid); - if (!(perm & CFS_RMTACL_PERM)) - GOTO(out, rc = err_serious(-EPERM)); - } - - if (strncmp(xattr_name, XATTR_USER_PREFIX, - sizeof(XATTR_USER_PREFIX) - 1) == 0) { - if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR)) - GOTO(out, rc = -EOPNOTSUPP); - if (strcmp(xattr_name, XATTR_NAME_LOV) == 0) - GOTO(out, rc = -EACCES); - if (strcmp(xattr_name, XATTR_NAME_LMA) == 0) - GOTO(out, rc = 0); - if (strcmp(xattr_name, XATTR_NAME_LINK) == 0) - GOTO(out, rc = 0); - } else if ((valid & OBD_MD_FLXATTR) && - (strncmp(xattr_name, XATTR_NAME_ACL_ACCESS, - sizeof(XATTR_NAME_ACL_ACCESS) - 1) == 0 || - strncmp(xattr_name, XATTR_NAME_ACL_DEFAULT, - sizeof(XATTR_NAME_ACL_DEFAULT) - 1) == 0)) { - /* currently lustre limit acl access size */ - if (xattr_len > LUSTRE_POSIX_ACL_MAX_SIZE) - GOTO(out, -ERANGE); - } + if (!(perm & CFS_RMTACL_PERM)) + GOTO(out, rc = err_serious(-EPERM)); + } + + if (strncmp(xattr_name, XATTR_USER_PREFIX, + sizeof(XATTR_USER_PREFIX) - 1) == 0) { + if (!(exp_connect_flags(req->rq_export) & OBD_CONNECT_XATTR)) + GOTO(out, rc = -EOPNOTSUPP); + } else if (strncmp(xattr_name, XATTR_TRUSTED_PREFIX, + sizeof(XATTR_TRUSTED_PREFIX) - 1) == 0) { + + if (!md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN)) + GOTO(out, rc = -EPERM); + + if (strcmp(xattr_name, XATTR_NAME_LOV) == 0 || + strcmp(xattr_name, XATTR_NAME_LMA) == 0 || + strcmp(xattr_name, XATTR_NAME_LMV) == 0 || + strcmp(xattr_name, XATTR_NAME_LINK) == 0 || + strcmp(xattr_name, XATTR_NAME_FID) == 0 || + strcmp(xattr_name, XATTR_NAME_VERSION) == 0 || + strcmp(xattr_name, XATTR_NAME_SOM) == 0 || + strcmp(xattr_name, XATTR_NAME_HSM) == 0 || + strcmp(xattr_name, XATTR_NAME_LFSCK_NAMESPACE) == 0) + GOTO(out, rc = 0); + +#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 8, 53, 0) + if (strcmp(xattr_name, XATTR_NAME_LFSCK_NAMESPACE_OLD) == 0) + GOTO(out, rc = 0); +#endif + } else if ((valid & OBD_MD_FLXATTR) && + (strcmp(xattr_name, XATTR_NAME_ACL_ACCESS) == 0 || + strcmp(xattr_name, XATTR_NAME_ACL_DEFAULT) == 0)) { + + /* currently lustre limit acl access size */ + if (xattr_len > LUSTRE_POSIX_ACL_MAX_SIZE) + GOTO(out, rc = -ERANGE); + + rc = nodemap_map_acl(nodemap, rr->rr_eadata, xattr_len, + NODEMAP_CLIENT_TO_FS); + if (rc < 0) + GOTO(out, rc); + + /* ACLs were mapped out, return an error so the user knows */ + if (rc != xattr_len) + GOTO(out, rc = -EPERM); + } lockpart = MDS_INODELOCK_UPDATE; /* Revoke all clients' lookup lock, since the access @@ -337,71 +458,71 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, * not change the access permissions of this inode, nor any * other existing inodes. It is setting the ACLs inherited * by new directories/files at create time. */ + /* We need revoke both LOOKUP|PERM lock here, see mdt_attr_set. */ if (!strcmp(xattr_name, XATTR_NAME_ACL_ACCESS)) - lockpart |= MDS_INODELOCK_LOOKUP; + lockpart |= MDS_INODELOCK_PERM | MDS_INODELOCK_LOOKUP; + /* We need to take the lock on behalf of old clients so that newer + * clients flush their xattr caches */ + else + lockpart |= MDS_INODELOCK_XATTR; lh = &info->mti_lh[MDT_LH_PARENT]; /* ACLs were sent to clients under LCK_CR locks, so taking LCK_EX * to cancel them. */ mdt_lock_reg_init(lh, LCK_EX); obj = mdt_object_find_lock(info, rr->rr_fid1, lh, lockpart); - if (IS_ERR(obj)) - GOTO(out, rc = PTR_ERR(obj)); - - info->mti_mos = obj; - rc = mdt_version_get_check_save(info, obj, 0); - if (rc) - GOTO(out_unlock, rc); - - if (unlikely(!(valid & OBD_MD_FLCTIME))) { - /* This isn't strictly an error, but all current clients - * should set OBD_MD_FLCTIME when setting attributes. */ - CWARN("%s: client miss to set OBD_MD_FLCTIME when " - "setxattr %s: [object "DFID"] [valid "LPU64"]\n", - info->mti_exp->exp_obd->obd_name, xattr_name, - PFID(rr->rr_fid1), valid); - attr->la_ctime = cfs_time_current_sec(); - } - attr->la_valid = LA_CTIME; - child = mdt_object_child(obj); - if (valid & OBD_MD_FLXATTR) { - char *xattr = (void *)rr->rr_eadata; - - if (xattr_len > 0) { - int flags = 0; - - if (valid & OBD_MD_FLRMTLSETFACL) { - if (unlikely(!remote)) - GOTO(out_unlock, rc = -EINVAL); - - xattr_len = mdt_rmtlsetfacl(info, child, - xattr_name, - (ext_acl_xattr_header *)xattr, - &new_xattr); - if (xattr_len < 0) - GOTO(out_unlock, rc = xattr_len); - - xattr = (char *)new_xattr; - } - - if (attr->la_flags & XATTR_REPLACE) - flags |= LU_XATTR_REPLACE; - - if (attr->la_flags & XATTR_CREATE) - flags |= LU_XATTR_CREATE; - - mdt_fail_write(env, info->mti_mdt->mdt_bottom, - OBD_FAIL_MDS_SETXATTR_WRITE); - - buf->lb_buf = xattr; - buf->lb_len = xattr_len; - rc = mo_xattr_set(env, child, buf, xattr_name, flags); - /* update ctime after xattr changed */ - if (rc == 0) { - ma->ma_attr_flags |= MDS_PERM_BYPASS; - mo_attr_set(env, child, ma); - } - } + if (IS_ERR(obj)) + GOTO(out, rc = PTR_ERR(obj)); + + tgt_vbr_obj_set(env, mdt_obj2dt(obj)); + rc = mdt_version_get_check_save(info, obj, 0); + if (rc) + GOTO(out_unlock, rc); + + if (unlikely(!(valid & OBD_MD_FLCTIME))) { + /* This isn't strictly an error, but all current clients + * should set OBD_MD_FLCTIME when setting attributes. */ + CWARN("%s: client miss to set OBD_MD_FLCTIME when " + "setxattr %s: [object "DFID"] [valid "LPU64"]\n", + mdt_obd_name(info->mti_mdt), xattr_name, + PFID(rr->rr_fid1), valid); + attr->la_ctime = cfs_time_current_sec(); + } + attr->la_valid = LA_CTIME; + child = mdt_object_child(obj); + if (valid & OBD_MD_FLXATTR) { + void *xattr = rr->rr_eadata; + int flags = 0; + + if (valid & OBD_MD_FLRMTLSETFACL) { + if (unlikely(!remote)) + GOTO(out_unlock, rc = -EINVAL); + + xattr_len = mdt_rmtlsetfacl(info, child, xattr_name, + xattr, &new_xattr); + if (xattr_len < 0) + GOTO(out_unlock, rc = xattr_len); + + xattr = new_xattr; + } + + if (attr->la_flags & XATTR_REPLACE) + flags |= LU_XATTR_REPLACE; + + if (attr->la_flags & XATTR_CREATE) + flags |= LU_XATTR_CREATE; + + mdt_fail_write(env, info->mti_mdt->mdt_bottom, + OBD_FAIL_MDS_SETXATTR_WRITE); + + buf->lb_buf = xattr; + buf->lb_len = xattr_len; + rc = mo_xattr_set(env, child, buf, xattr_name, flags); + /* update ctime after xattr changed */ + if (rc == 0) { + ma->ma_attr_flags |= MDS_PERM_BYPASS; + mo_attr_set(env, child, ma); + } } else if (valid & OBD_MD_FLXATTRRM) { rc = mo_xattr_del(env, child, xattr_name); /* update ctime after xattr changed */