X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lustre%2Fmdt%2Fmdt_identity.c;h=e8ec709c39092fbee075f4edaaeca52a04adbfc1;hp=235444c678b0eea23e52f36c642b3119a80ad1fa;hb=d1b47781a3acd449473884f42e71ece2a7789670;hpb=9d06de39731ae16d030cda672ae771496d4f0952 diff --git a/lustre/mdt/mdt_identity.c b/lustre/mdt/mdt_identity.c index 235444c..e8ec709 100644 --- a/lustre/mdt/mdt_identity.c +++ b/lustre/mdt/mdt_identity.c @@ -15,11 +15,7 @@ * * You should have received a copy of the GNU General Public License * version 2 along with this program; If not, see - * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf - * - * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, - * CA 95054 USA or visit www.sun.com if you need additional information or - * have any questions. + * http://www.gnu.org/licenses/gpl-2.0.html * * GPL HEADER END */ @@ -27,7 +23,7 @@ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved. * Use is subject to license terms. * - * Copyright (c) 2011, 2012, Intel Corporation. + * Copyright (c) 2011, 2016, Intel Corporation. */ /* * This file is part of Lustre, http://www.lustre.org/ @@ -106,14 +102,14 @@ static int mdt_identity_do_upcall(struct upcall_cache *cache, [1] = "PATH=/sbin:/usr/sbin", [2] = NULL }; - struct timeval start, end; + ktime_t start, end; int rc; ENTRY; /* There is race condition: * "uc_upcall" was changed just after "is_identity_get_disabled" check. */ - read_lock(&cache->uc_upcall_rwlock); + down_read(&cache->uc_upcall_rwsem); CDEBUG(D_INFO, "The upcall is: '%s'\n", cache->uc_upcall); if (unlikely(!strcmp(cache->uc_upcall, "NONE"))) { @@ -121,28 +117,26 @@ static int mdt_identity_do_upcall(struct upcall_cache *cache, GOTO(out, rc = -EREMCHG); } - argv[0] = cache->uc_upcall; - snprintf(keystr, sizeof(keystr), LPU64, entry->ue_key); + argv[0] = cache->uc_upcall; + snprintf(keystr, sizeof(keystr), "%llu", entry->ue_key); - do_gettimeofday(&start); + start = ktime_get(); rc = call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC); - do_gettimeofday(&end); + end = ktime_get(); if (rc < 0) { - CERROR("%s: error invoking upcall %s %s %s: rc %d; " - "check /proc/fs/lustre/mdt/%s/identity_upcall, " - "time %ldus\n", - cache->uc_name, argv[0], argv[1], argv[2], rc, - cache->uc_name, cfs_timeval_sub(&end, &start, NULL)); - } else { - CDEBUG(D_HA, "%s: invoked upcall %s %s %s, time %ldus\n", - cache->uc_name, argv[0], argv[1], argv[2], - cfs_timeval_sub(&end, &start, NULL)); - rc = 0; - } - EXIT; + CERROR("%s: error invoking upcall %s %s %s: rc %d; check /proc/fs/lustre/mdt/%s/identity_upcall, time %ldus\n", + cache->uc_name, argv[0], argv[1], argv[2], rc, + cache->uc_name, (long)ktime_us_delta(end, start)); + } else { + CDEBUG(D_HA, "%s: invoked upcall %s %s %s, time %ldus\n", + cache->uc_name, argv[0], argv[1], argv[2], + (long)ktime_us_delta(end, start)); + rc = 0; + } + EXIT; out: - read_unlock(&cache->uc_upcall_rwlock); - return rc; + up_read(&cache->uc_upcall_rwsem); + return rc; } static int mdt_identity_parse_downcall(struct upcall_cache *cache,