X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lnet%2Flnet%2Frouter_proc.c;h=5f85792f0a091fac3b849f154557d52ab52fa554;hp=e1c5055fdd0561150c7325dce2407614acbcfd60;hb=a07e9d350b3e500c7be877f6dcf54380b86a9cbe;hpb=e3a7c58aebafce40323db54bf6056029e5af4a70 diff --git a/lnet/lnet/router_proc.c b/lnet/lnet/router_proc.c index e1c5055..5f85792 100644 --- a/lnet/lnet/router_proc.c +++ b/lnet/lnet/router_proc.c @@ -52,40 +52,52 @@ enum { #define PSDEV_LNET_NIS CTL_UNNUMBERED #endif +#define LNET_LOFFT_BITS (sizeof(loff_t) * 8) /* - * NB: we don't use the highest bit of *ppos because it's signed; - * next 9 bits is used to stash idx (assuming that - * LNET_PEER_HASHSIZE < 512) + * NB: max allowed LNET_CPT_BITS is 8 on 64-bit system and 2 on 32-bit system */ -#define LNET_LOFFT_BITS (sizeof(loff_t) * 8) -#define LNET_VERSION_BITS MAX(((MIN(LNET_LOFFT_BITS, 64)) / 4), 8) -#define LNET_PHASH_IDX_BITS 9 -#define LNET_PHASH_NUM_BITS (LNET_LOFFT_BITS - 1 -\ - LNET_VERSION_BITS - LNET_PHASH_IDX_BITS) -#define LNET_PHASH_BITS (LNET_PHASH_IDX_BITS + LNET_PHASH_NUM_BITS) - -#define LNET_VERSION_BITMASK ((1ULL << LNET_VERSION_BITS) - 1) -#define LNET_PHASH_IDX_BITMASK ((1ULL << LNET_PHASH_IDX_BITS) - 1) -#define LNET_PHASH_NUM_BITMASK ((1ULL << LNET_PHASH_NUM_BITS) - 1) - -#define LNET_VERSION_MASK (LNET_VERSION_BITMASK << LNET_PHASH_BITS) -#define LNET_PHASH_IDX_MASK (LNET_PHASH_IDX_BITMASK << LNET_PHASH_NUM_BITS) -#define LNET_PHASH_NUM_MASK (LNET_PHASH_NUM_BITMASK) - -#define LNET_VERSION_GET(pos) (int)(((pos) & LNET_VERSION_MASK) >> \ - LNET_PHASH_BITS) -#define LNET_PHASH_IDX_GET(pos) (int)(((pos) & LNET_PHASH_IDX_MASK) >> \ - LNET_PHASH_NUM_BITS) -#define LNET_PHASH_NUM_GET(pos) (int)((pos) & LNET_PHASH_NUM_MASK) -#define LNET_VERSION_VALID_MASK(ver) \ - (unsigned int)((ver) & \ - LNET_VERSION_BITMASK) -#define LNET_PHASH_POS_MAKE(ver, idx, num) \ - (((((loff_t)(ver)) & LNET_VERSION_BITMASK) << \ - LNET_PHASH_BITS) | \ - ((((loff_t)(idx)) & LNET_PHASH_IDX_BITMASK) <<\ - LNET_PHASH_NUM_BITS) | \ - ((num) & LNET_PHASH_NUM_BITMASK)) +#define LNET_PROC_CPT_BITS LNET_CPT_BITS +/* change version, 16 bits or 8 bits */ +#define LNET_PROC_VER_BITS MAX(((MIN(LNET_LOFFT_BITS, 64)) / 4), 8) + +#define LNET_PROC_HASH_BITS LNET_PEER_HASH_BITS +/* + * bits for peer hash offset + * NB: we don't use the highest bit of *ppos because it's signed + */ +#define LNET_PROC_HOFF_BITS (LNET_LOFFT_BITS - \ + LNET_PROC_CPT_BITS - \ + LNET_PROC_VER_BITS - \ + LNET_PROC_HASH_BITS - 1) +/* bits for hash index + position */ +#define LNET_PROC_HPOS_BITS (LNET_PROC_HASH_BITS + LNET_PROC_HOFF_BITS) +/* bits for peer hash table + hash version */ +#define LNET_PROC_VPOS_BITS (LNET_PROC_HPOS_BITS + LNET_PROC_VER_BITS) + +#define LNET_PROC_CPT_MASK ((1ULL << LNET_PROC_CPT_BITS) - 1) +#define LNET_PROC_VER_MASK ((1ULL << LNET_PROC_VER_BITS) - 1) +#define LNET_PROC_HASH_MASK ((1ULL << LNET_PROC_HASH_BITS) - 1) +#define LNET_PROC_HOFF_MASK ((1ULL << LNET_PROC_HOFF_BITS) - 1) + +#define LNET_PROC_CPT_GET(pos) \ + (int)(((pos) >> LNET_PROC_VPOS_BITS) & LNET_PROC_CPT_MASK) + +#define LNET_PROC_VER_GET(pos) \ + (int)(((pos) >> LNET_PROC_HPOS_BITS) & LNET_PROC_VER_MASK) + +#define LNET_PROC_HASH_GET(pos) \ + (int)(((pos) >> LNET_PROC_HOFF_BITS) & LNET_PROC_HASH_MASK) + +#define LNET_PROC_HOFF_GET(pos) \ + (int)((pos) & LNET_PROC_HOFF_MASK) + +#define LNET_PROC_POS_MAKE(cpt, ver, hash, off) \ + (((((loff_t)(cpt)) & LNET_PROC_CPT_MASK) << LNET_PROC_VPOS_BITS) | \ + ((((loff_t)(ver)) & LNET_PROC_VER_MASK) << LNET_PROC_HPOS_BITS) | \ + ((((loff_t)(hash)) & LNET_PROC_HASH_MASK) << LNET_PROC_HOFF_BITS) | \ + ((off) & LNET_PROC_HOFF_MASK)) + +#define LNET_PROC_VERSION(v) ((unsigned int)((v) & LNET_PROC_VER_MASK)) static int __proc_lnet_stats(void *data, int write, loff_t pos, void *buffer, int nob) @@ -97,10 +109,8 @@ static int __proc_lnet_stats(void *data, int write, const int tmpsiz = 256; /* 7 %u and 4 LPU64 */ if (write) { - LNET_LOCK(); - memset(&the_lnet.ln_counters, 0, sizeof(the_lnet.ln_counters)); - LNET_UNLOCK(); - return 0; + lnet_counters_reset(); + return 0; } /* read */ @@ -115,9 +125,7 @@ static int __proc_lnet_stats(void *data, int write, return -ENOMEM; } - LNET_LOCK(); - *ctrs = the_lnet.ln_counters; - LNET_UNLOCK(); + lnet_counters_get(ctrs); len = snprintf(tmpstr, tmpsiz, "%u %u %u %u %u %u %u "LPU64" "LPU64" " @@ -144,18 +152,20 @@ DECLARE_PROC_HANDLER(proc_lnet_stats); int LL_PROC_PROTO(proc_lnet_routes) { - int rc = 0; - char *tmpstr; - char *s; - const int tmpsiz = 256; - int len; - int ver; - int num; + const int tmpsiz = 256; + char *tmpstr; + char *s; + int rc = 0; + int len; + int ver; + int off; - DECLARE_LL_PROC_PPOS_DECL; + DECLARE_LL_PROC_PPOS_DECL; + + CLASSERT(sizeof(loff_t) >= 4); - num = LNET_PHASH_NUM_GET(*ppos); - ver = LNET_VERSION_GET(*ppos); + off = LNET_PROC_HOFF_GET(*ppos); + ver = LNET_PROC_VER_GET(*ppos); LASSERT (!write); @@ -177,21 +187,21 @@ int LL_PROC_PROTO(proc_lnet_routes) "net", "hops", "state", "router"); LASSERT (tmpstr + tmpsiz - s > 0); - LNET_LOCK(); - ver = (unsigned int)the_lnet.ln_remote_nets_version; - LNET_UNLOCK(); - *ppos = LNET_PHASH_POS_MAKE(ver, 0, num); - } else { - cfs_list_t *n; - cfs_list_t *r; - lnet_route_t *route = NULL; - lnet_remotenet_t *rnet = NULL; - int skip = num - 1; - - LNET_LOCK(); - - if (ver != LNET_VERSION_VALID_MASK(the_lnet.ln_remote_nets_version)) { - LNET_UNLOCK(); + lnet_net_lock(0); + ver = (unsigned int)the_lnet.ln_remote_nets_version; + lnet_net_unlock(0); + *ppos = LNET_PROC_POS_MAKE(0, ver, 0, off); + } else { + cfs_list_t *n; + cfs_list_t *r; + lnet_route_t *route = NULL; + lnet_remotenet_t *rnet = NULL; + int skip = off - 1; + + lnet_net_lock(0); + + if (ver != LNET_PROC_VERSION(the_lnet.ln_remote_nets_version)) { + lnet_net_unlock(0); LIBCFS_FREE(tmpstr, tmpsiz); return -ESTALE; } @@ -225,13 +235,15 @@ int LL_PROC_PROTO(proc_lnet_routes) lnet_nid_t nid = route->lr_gateway->lp_nid; int alive = route->lr_gateway->lp_alive; - s += snprintf(s, tmpstr + tmpsiz - s, "%-8s %4u %7s %s\n", - libcfs_net2str(net), hops, - alive ? "up" : "down", libcfs_nid2str(nid)); - LASSERT (tmpstr + tmpsiz - s > 0); - } + s += snprintf(s, tmpstr + tmpsiz - s, + "%-8s %4u %7s %s\n", + libcfs_net2str(net), hops, + alive ? "up" : "down", + libcfs_nid2str(nid)); + LASSERT(tmpstr + tmpsiz - s > 0); + } - LNET_UNLOCK(); + lnet_net_unlock(0); } len = s - tmpstr; /* how many bytes was written */ @@ -242,8 +254,8 @@ int LL_PROC_PROTO(proc_lnet_routes) if (cfs_copy_to_user(buffer, tmpstr, len)) rc = -EFAULT; else { - num += 1; - *ppos = LNET_PHASH_POS_MAKE(ver, 0, num); + off += 1; + *ppos = LNET_PROC_POS_MAKE(0, ver, 0, off); } } @@ -263,12 +275,12 @@ int LL_PROC_PROTO(proc_lnet_routers) const int tmpsiz = 256; int len; int ver; - int num; + int off; - DECLARE_LL_PROC_PPOS_DECL; + DECLARE_LL_PROC_PPOS_DECL; - num = LNET_PHASH_NUM_GET(*ppos); - ver = LNET_VERSION_GET(*ppos); + off = LNET_PROC_HOFF_GET(*ppos); + ver = LNET_PROC_VER_GET(*ppos); LASSERT (!write); @@ -282,25 +294,27 @@ int LL_PROC_PROTO(proc_lnet_routers) s = tmpstr; /* points to current position in tmpstr[] */ if (*ppos == 0) { - s += snprintf(s, tmpstr + tmpsiz - s, - "%-4s %7s %9s %6s %12s %9s %8s %7s %s\n", - "ref", "rtr_ref", "alive_cnt", "state", "last_ping", - "ping_sent", "deadline", "down_ni", "router"); - LASSERT (tmpstr + tmpsiz - s > 0); - - LNET_LOCK(); - ver = (unsigned int)the_lnet.ln_routers_version; - LNET_UNLOCK(); - *ppos = LNET_PHASH_POS_MAKE(ver, 0, num); - } else { - cfs_list_t *r; - lnet_peer_t *peer = NULL; - int skip = num - 1; - - LNET_LOCK(); + s += snprintf(s, tmpstr + tmpsiz - s, + "%-4s %7s %9s %6s %12s %9s %8s %7s %s\n", + "ref", "rtr_ref", "alive_cnt", "state", + "last_ping", "ping_sent", "deadline", + "down_ni", "router"); + LASSERT(tmpstr + tmpsiz - s > 0); + + lnet_net_lock(0); + ver = (unsigned int)the_lnet.ln_routers_version; + lnet_net_unlock(0); + *ppos = LNET_PROC_POS_MAKE(0, ver, 0, off); + } else { + cfs_list_t *r; + struct lnet_peer *peer = NULL; + int skip = off - 1; + + lnet_net_lock(0); + + if (ver != LNET_PROC_VERSION(the_lnet.ln_routers_version)) { + lnet_net_unlock(0); - if (ver != LNET_VERSION_VALID_MASK(the_lnet.ln_routers_version)) { - LNET_UNLOCK(); LIBCFS_FREE(tmpstr, tmpsiz); return -ESTALE; } @@ -331,8 +345,20 @@ int LL_PROC_PROTO(proc_lnet_routers) int pingsent = !peer->lp_ping_notsent; int last_ping = cfs_duration_sec(cfs_time_sub(now, peer->lp_ping_timestamp)); - int down_ni = lnet_router_down_ni(peer, - LNET_NIDNET(LNET_NID_ANY)); + int down_ni = 0; + lnet_route_t *rtr; + + if (peer->lp_ping_version == LNET_PROTO_PING_VERSION) { + cfs_list_for_each_entry(rtr, &peer->lp_routes, + lr_gwlist) { + /* downis on any route should be the + * number of downis on the gateway */ + if (rtr->lr_downis != 0) { + down_ni = rtr->lr_downis; + break; + } + } + } if (deadline == 0) s += snprintf(s, tmpstr + tmpsiz - s, @@ -352,7 +378,7 @@ int LL_PROC_PROTO(proc_lnet_routers) LASSERT (tmpstr + tmpsiz - s > 0); } - LNET_UNLOCK(); + lnet_net_unlock(0); } len = s - tmpstr; /* how many bytes was written */ @@ -363,8 +389,8 @@ int LL_PROC_PROTO(proc_lnet_routers) if (cfs_copy_to_user(buffer, tmpstr, len)) rc = -EFAULT; else { - num += 1; - *ppos = LNET_PHASH_POS_MAKE(ver, 0, num); + off += 1; + *ppos = LNET_PROC_POS_MAKE(0, ver, 0, off); } } @@ -378,27 +404,25 @@ int LL_PROC_PROTO(proc_lnet_routers) int LL_PROC_PROTO(proc_lnet_peers) { - int rc = 0; - char *tmpstr; - char *s; - const int tmpsiz = 256; - int len; - int ver; - int idx; - int num; - - DECLARE_LL_PROC_PPOS_DECL; - - idx = LNET_PHASH_IDX_GET(*ppos); - num = LNET_PHASH_NUM_GET(*ppos); - ver = LNET_VERSION_GET(*ppos); - - CLASSERT ((1ULL << LNET_PHASH_BITS) > LNET_PEER_HASHSIZE); - - LASSERT (!write); - - if (*lenp == 0) - return 0; + const int tmpsiz = 256; + struct lnet_peer_table *ptable; + char *tmpstr; + char *s; + int cpt = LNET_PROC_CPT_GET(*ppos); + int ver = LNET_PROC_VER_GET(*ppos); + int hoff = LNET_PROC_HOFF_GET(*ppos); + int hash = LNET_PROC_HASH_GET(*ppos); + int rc = 0; + int len; + + CLASSERT(LNET_PROC_HASH_BITS >= LNET_PEER_HASH_BITS); + LASSERT(!write); + + if (*lenp == 0) + return 0; + + if (cpt >= LNET_CPT_NUMBER) + return 0; LIBCFS_ALLOC(tmpstr, tmpsiz); if (tmpstr == NULL) @@ -413,30 +437,29 @@ int LL_PROC_PROTO(proc_lnet_peers) "rtr", "min", "tx", "min", "queue"); LASSERT (tmpstr + tmpsiz - s > 0); - LNET_LOCK(); - ver = (unsigned int)the_lnet.ln_peertable_version; - LNET_UNLOCK(); - *ppos = LNET_PHASH_POS_MAKE(ver, idx, num); - - num++; - } else { - cfs_list_t *p = NULL; - lnet_peer_t *peer = NULL; - int skip = num - 1; - - LNET_LOCK(); - - if (ver != LNET_VERSION_VALID_MASK(the_lnet.ln_peertable_version)) { - LNET_UNLOCK(); - LIBCFS_FREE(tmpstr, tmpsiz); - return -ESTALE; - } - - while (idx < LNET_PEER_HASHSIZE) { - if (p == NULL) - p = the_lnet.ln_peer_hash[idx].next; - - while (p != &the_lnet.ln_peer_hash[idx]) { + hoff++; + } else { + struct lnet_peer *peer = NULL; + cfs_list_t *p = NULL; + int skip = hoff - 1; + + again: + lnet_net_lock(cpt); + ptable = the_lnet.ln_peer_tables[cpt]; + if (hoff == 1) + ver = LNET_PROC_VERSION(ptable->pt_version); + + if (ver != LNET_PROC_VERSION(ptable->pt_version)) { + lnet_net_unlock(cpt); + LIBCFS_FREE(tmpstr, tmpsiz); + return -ESTALE; + } + + while (hash < LNET_PEER_HASH_SIZE) { + if (p == NULL) + p = ptable->pt_hash[hash].next; + + while (p != &ptable->pt_hash[hash]) { lnet_peer_t *lp = cfs_list_entry(p, lnet_peer_t, lp_hashlist); if (skip == 0) { @@ -445,12 +468,12 @@ int LL_PROC_PROTO(proc_lnet_peers) /* minor optimization: start from idx+1 * on next iteration if we've just * drained lp_hashlist */ - if (lp->lp_hashlist.next == - &the_lnet.ln_peer_hash[idx]) { - num = 1; - idx++; - } else { - num++; + if (lp->lp_hashlist.next == + &ptable->pt_hash[hash]) { + hoff = 1; + hash++; + } else { + hoff++; } break; @@ -464,8 +487,8 @@ int LL_PROC_PROTO(proc_lnet_peers) break; p = NULL; - num = 1; - idx++; + hoff = 1; + hash++; } if (peer != NULL) { @@ -499,15 +522,26 @@ int LL_PROC_PROTO(proc_lnet_peers) lastalive = 9999; } + lnet_net_unlock(cpt); + s += snprintf(s, tmpstr + tmpsiz - s, "%-24s %4d %5s %5d %5d %5d %5d %5d %5d %d\n", libcfs_nid2str(nid), nrefs, aliveness, lastalive, maxcr, rtrcr, minrtrcr, txcr, mintxcr, txqnob); LASSERT (tmpstr + tmpsiz - s > 0); - } - LNET_UNLOCK(); + } else { /* peer is NULL */ + lnet_net_unlock(cpt); + + if (hash == LNET_PEER_HASH_SIZE && + cpt < LNET_CPT_NUMBER - 1) { + cpt++; + hash = 0; + hoff = 1; + goto again; + } + } } len = s - tmpstr; /* how many bytes was written */ @@ -518,7 +552,7 @@ int LL_PROC_PROTO(proc_lnet_peers) if (cfs_copy_to_user(buffer, tmpstr, len)) rc = -EFAULT; else - *ppos = LNET_PHASH_POS_MAKE(ver, idx, num); + *ppos = LNET_PROC_POS_MAKE(cpt, ver, hash, hoff); } LIBCFS_FREE(tmpstr, tmpsiz); @@ -532,16 +566,18 @@ int LL_PROC_PROTO(proc_lnet_peers) static int __proc_lnet_buffers(void *data, int write, loff_t pos, void *buffer, int nob) { - - int rc; - int len; - char *s; - char *tmpstr; - const int tmpsiz = 64 * (LNET_NRBPOOLS + 1); /* (4 %d) * 4 */ - int idx; - - LASSERT (!write); - + char *s; + char *tmpstr; + int tmpsiz; + int idx; + int len; + int rc; + int i; + + LASSERT(!write); + + /* (4 %d) * 4 * LNET_CPT_NUMBER */ + tmpsiz = 64 * (LNET_NRBPOOLS + 1) * LNET_CPT_NUMBER; LIBCFS_ALLOC(tmpstr, tmpsiz); if (tmpstr == NULL) return -ENOMEM; @@ -553,24 +589,26 @@ static int __proc_lnet_buffers(void *data, int write, "pages", "count", "credits", "min"); LASSERT (tmpstr + tmpsiz - s > 0); - LNET_LOCK(); - - for (idx = 0; idx < LNET_NRBPOOLS; idx++) { - lnet_rtrbufpool_t *rbp = &the_lnet.ln_rtrpools[idx]; - - int npages = rbp->rbp_npages; - int nbuf = rbp->rbp_nbuffers; - int cr = rbp->rbp_credits; - int mincr = rbp->rbp_mincredits; - - s += snprintf(s, tmpstr + tmpsiz - s, - "%5d %5d %7d %7d\n", - npages, nbuf, cr, mincr); - LASSERT (tmpstr + tmpsiz - s > 0); - } - - LNET_UNLOCK(); - + if (the_lnet.ln_rtrpools == NULL) + goto out; /* I'm not a router */ + + for (idx = 0; idx < LNET_NRBPOOLS; idx++) { + lnet_rtrbufpool_t *rbp; + + lnet_net_lock(LNET_LOCK_EX); + cfs_percpt_for_each(rbp, i, the_lnet.ln_rtrpools) { + s += snprintf(s, tmpstr + tmpsiz - s, + "%5d %5d %7d %7d\n", + rbp[idx].rbp_npages, + rbp[idx].rbp_nbuffers, + rbp[idx].rbp_credits, + rbp[idx].rbp_mincredits); + LASSERT(tmpstr + tmpsiz - s > 0); + } + lnet_net_unlock(LNET_LOCK_EX); + } + + out: len = s - tmpstr; if (pos >= min_t(int, len, strlen(tmpstr))) @@ -587,10 +625,10 @@ DECLARE_PROC_HANDLER(proc_lnet_buffers); int LL_PROC_PROTO(proc_lnet_nis) { + int tmpsiz = 128 * LNET_CPT_NUMBER; int rc = 0; char *tmpstr; char *s; - const int tmpsiz = 256; int len; DECLARE_LL_PROC_PPOS_DECL; @@ -617,7 +655,7 @@ int LL_PROC_PROTO(proc_lnet_nis) lnet_ni_t *ni = NULL; int skip = *ppos - 1; - LNET_LOCK(); + lnet_net_lock(0); n = the_lnet.ln_nis.next; @@ -634,36 +672,46 @@ int LL_PROC_PROTO(proc_lnet_nis) } if (ni != NULL) { - cfs_time_t now = cfs_time_current(); - int last_alive = -1; - int maxtxcr = ni->ni_maxtxcredits; - int txcr = ni->ni_txcredits; - int mintxcr = ni->ni_mintxcredits; - int npeertxcr = ni->ni_peertxcredits; - int npeerrtrcr = ni->ni_peerrtrcredits; - lnet_nid_t nid = ni->ni_nid; - int nref = ni->ni_refcount; - char *stat; - - if (the_lnet.ln_routing) - last_alive = cfs_duration_sec(cfs_time_sub(now, - ni->ni_last_alive)); - if (ni->ni_lnd->lnd_type == LOLND) /* @lo forever alive */ - last_alive = 0; - - LASSERT (ni->ni_status != NULL); - stat = (ni->ni_status->ns_status == LNET_NI_STATUS_UP) ? - "up" : "down"; - - s += snprintf(s, tmpstr + tmpsiz - s, - "%-24s %6s %5d %4d %4d %4d %5d %5d %5d\n", - libcfs_nid2str(nid), stat, last_alive, nref, - npeertxcr, npeerrtrcr, maxtxcr, - txcr, mintxcr); - LASSERT (tmpstr + tmpsiz - s > 0); - } - - LNET_UNLOCK(); + char *stat; + struct lnet_tx_queue *tq; + long now = cfs_time_current_sec(); + int last_alive = -1; + int i; + + if (the_lnet.ln_routing) + last_alive = now - ni->ni_last_alive; + + /* @lo forever alive */ + if (ni->ni_lnd->lnd_type == LOLND) + last_alive = 0; + + lnet_ni_lock(ni); + LASSERT(ni->ni_status != NULL); + stat = (ni->ni_status->ns_status == + LNET_NI_STATUS_UP) ? "up" : "down"; + lnet_ni_unlock(ni); + + /* we actually output credits information for + * TX queue of each partition */ + cfs_percpt_for_each(tq, i, ni->ni_tx_queues) { + if (i != 0) + lnet_net_lock(i); + + s += snprintf(s, tmpstr + tmpsiz - s, + "%-24s %6s %5d %4d %4d %4d %5d %5d %5d\n", + libcfs_nid2str(ni->ni_nid), stat, + last_alive, *ni->ni_refs[i], + ni->ni_peertxcredits, + ni->ni_peerrtrcredits, + tq->tq_credits_max, + tq->tq_credits, tq->tq_credits_min); + if (i != 0) + lnet_net_unlock(i); + } + LASSERT(tmpstr + tmpsiz - s > 0); + } + + lnet_net_unlock(0); } len = s - tmpstr; /* how many bytes was written */