X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=blobdiff_plain;f=lnet%2Flnet%2Flib-md.c;h=137299cce8561b8a0101289c13acc0ff06f048b0;hp=6deadb8442403f8c9f8753428e481dae5c10e933;hb=54320d7f52e6dd2b32e64997e2f7ae1ff1060f6f;hpb=191061ee668400324f4505cf498f1ee2d57e4962 diff --git a/lnet/lnet/lib-md.c b/lnet/lnet/lib-md.c index 6deadb8..137299c 100644 --- a/lnet/lnet/lib-md.c +++ b/lnet/lnet/lib-md.c @@ -1,426 +1,425 @@ -/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*- - * vim:expandtab:shiftwidth=8:tabstop=8: +/* + * GPL HEADER START * - * lib/lib-md.c - * Memory Descriptor management routines + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 only, + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License version 2 for more details (a copy is included + * in the LICENSE file that accompanied this code). * - * Copyright (c) 2001-2003 Cluster File Systems, Inc. - * Copyright (c) 2001-2002 Sandia National Laboratories + * You should have received a copy of the GNU General Public License + * version 2 along with this program; If not, see + * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf * - * This file is part of Lustre, http://www.sf.net/projects/lustre/ + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. * - * Lustre is free software; you can redistribute it and/or - * modify it under the terms of version 2 of the GNU General Public - * License as published by the Free Software Foundation. + * GPL HEADER END + */ +/* + * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved. + * Use is subject to license terms. + */ +/* + * This file is part of Lustre, http://www.lustre.org/ + * Lustre is a trademark of Sun Microsystems, Inc. * - * Lustre is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * lnet/lnet/lib-md.c * - * You should have received a copy of the GNU General Public License - * along with Lustre; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * Memory Descriptor management routines */ -#ifndef __KERNEL__ -# include -#else -# define DEBUG_SUBSYSTEM S_PORTALS -# include -#endif +#define DEBUG_SUBSYSTEM S_LNET -#include +#include -/* must be called with state lock held */ +/* must be called with LNET_LOCK held */ void -lib_md_unlink(lib_nal_t *nal, lib_md_t *md) +lnet_md_unlink(lnet_libmd_t *md) { - if ((md->md_flags & PTL_MD_FLAG_ZOMBIE) == 0) { + if ((md->md_flags & LNET_MD_FLAG_ZOMBIE) == 0) { /* first unlink attempt... */ - lib_me_t *me = md->me; + lnet_me_t *me = md->md_me; - md->md_flags |= PTL_MD_FLAG_ZOMBIE; + md->md_flags |= LNET_MD_FLAG_ZOMBIE; /* Disassociate from ME (if any), and unlink it if it was created - * with PTL_UNLINK */ + * with LNET_UNLINK */ if (me != NULL) { - me->md = NULL; - if (me->unlink == PTL_UNLINK) - lib_me_unlink(nal, me); + md->md_me = NULL; + me->me_md = NULL; + if (me->me_unlink == LNET_UNLINK) + lnet_me_unlink(me); } - /* emsure all future handle lookups fail */ - lib_invalidate_handle(nal, &md->md_lh); + /* ensure all future handle lookups fail */ + lnet_res_lh_invalidate(&md->md_lh); } - if (md->pending != 0) { + if (md->md_refcount != 0) { CDEBUG(D_NET, "Queueing unlink of md %p\n", md); return; } CDEBUG(D_NET, "Unlinking md %p\n", md); - if ((md->options & PTL_MD_KIOV) != 0) { - if (nal->libnal_unmap_pages != NULL) - nal->libnal_unmap_pages (nal, - md->md_niov, - md->md_iov.kiov, - &md->md_addrkey); - } else if (nal->libnal_unmap != NULL) { - nal->libnal_unmap (nal, - md->md_niov, md->md_iov.iov, - &md->md_addrkey); - } - - if (md->eq != NULL) { - md->eq->eq_refcount--; - LASSERT (md->eq->eq_refcount >= 0); + if (md->md_eq != NULL) { + md->md_eq->eq_refcount--; + LASSERT (md->md_eq->eq_refcount >= 0); } - list_del (&md->md_list); - lib_md_free(nal, md); + LASSERT (!cfs_list_empty(&md->md_list)); + cfs_list_del_init (&md->md_list); + lnet_md_free_locked(md); } -/* must be called with state lock held */ +/* must be called with LNET_LOCK held */ static int -lib_md_build(lib_nal_t *nal, lib_md_t *lmd, ptl_md_t *umd, int unlink) +lib_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int unlink) { - lib_eq_t *eq = NULL; - int rc; - int i; - int niov; - int total_length = 0; + lnet_eq_t *eq = NULL; + int i; + unsigned int niov; + int total_length = 0; /* NB we are passed an allocated, but uninitialised/active md. - * if we return success, caller may lib_md_unlink() it. - * otherwise caller may only lib_md_free() it. + * if we return success, caller may lnet_md_unlink() it. + * otherwise caller may only lnet_md_free() it. */ - if (!PtlHandleIsEqual (umd->eq_handle, PTL_EQ_NONE)) { - eq = ptl_handle2eq(&umd->eq_handle, nal); + if (!LNetHandleIsInvalid (umd->eq_handle)) { + eq = lnet_handle2eq(&umd->eq_handle); if (eq == NULL) - return PTL_EQ_INVALID; + return -ENOENT; } /* This implementation doesn't know how to create START events or * disable END events. Best to LASSERT our caller is compliant so * we find out quickly... */ - LASSERT (eq == NULL || - ((umd->options & PTL_MD_EVENT_START_DISABLE) != 0 && - (umd->options & PTL_MD_EVENT_END_DISABLE) == 0)); - - lmd->me = NULL; - lmd->start = umd->start; - lmd->offset = 0; - lmd->max_size = umd->max_size; - lmd->options = umd->options; - lmd->user_ptr = umd->user_ptr; - lmd->eq = eq; - lmd->threshold = umd->threshold; - lmd->pending = 0; - lmd->md_flags = (unlink == PTL_UNLINK) ? PTL_MD_FLAG_AUTO_UNLINK : 0; - - if ((umd->options & PTL_MD_IOVEC) != 0) { - - if ((umd->options & PTL_MD_KIOV) != 0) /* Can't specify both */ - return PTL_MD_ILLEGAL; + /* TODO - reevaluate what should be here in light of + * the removal of the start and end events + * maybe there we shouldn't even allow LNET_EQ_NONE!) + LASSERT (eq == NULL); + */ + + lmd->md_me = NULL; + lmd->md_start = umd->start; + lmd->md_offset = 0; + lmd->md_max_size = umd->max_size; + lmd->md_options = umd->options; + lmd->md_user_ptr = umd->user_ptr; + lmd->md_eq = eq; + lmd->md_threshold = umd->threshold; + lmd->md_refcount = 0; + lmd->md_flags = (unlink == LNET_UNLINK) ? LNET_MD_FLAG_AUTO_UNLINK : 0; + + if ((umd->options & LNET_MD_IOVEC) != 0) { + + if ((umd->options & LNET_MD_KIOV) != 0) /* Can't specify both */ + return -EINVAL; lmd->md_niov = niov = umd->length; memcpy(lmd->md_iov.iov, umd->start, niov * sizeof (lmd->md_iov.iov[0])); - for (i = 0; i < niov; i++) { + for (i = 0; i < (int)niov; i++) { /* We take the base address on trust */ if (lmd->md_iov.iov[i].iov_len <= 0) /* invalid length */ - return PTL_MD_ILLEGAL; + return -EINVAL; total_length += lmd->md_iov.iov[i].iov_len; } - lmd->length = total_length; + lmd->md_length = total_length; - if ((umd->options & PTL_MD_MAX_SIZE) != 0 && /* max size used */ - (umd->max_size < 0 || + if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /* max size used */ + (umd->max_size < 0 || umd->max_size > total_length)) // illegal max_size - return PTL_MD_ILLEGAL; + return -EINVAL; - if (nal->libnal_map != NULL) { - rc = nal->libnal_map (nal, niov, lmd->md_iov.iov, - &lmd->md_addrkey); - if (rc != PTL_OK) - return (rc); - } - } else if ((umd->options & PTL_MD_KIOV) != 0) { + } else if ((umd->options & LNET_MD_KIOV) != 0) { #ifndef __KERNEL__ - return PTL_MD_ILLEGAL; -#else - /* Trap attempt to use paged I/O if unsupported early. */ - if (nal->libnal_send_pages == NULL || - nal->libnal_recv_pages == NULL) - return PTL_MD_INVALID; - + return -EINVAL; +#else lmd->md_niov = niov = umd->length; memcpy(lmd->md_iov.kiov, umd->start, niov * sizeof (lmd->md_iov.kiov[0])); - for (i = 0; i < niov; i++) { + for (i = 0; i < (int)niov; i++) { /* We take the page pointer on trust */ - if (lmd->md_iov.kiov[i].kiov_offset + - lmd->md_iov.kiov[i].kiov_len > PAGE_SIZE ) - return PTL_VAL_FAILED; /* invalid length */ + if (lmd->md_iov.kiov[i].kiov_offset + + lmd->md_iov.kiov[i].kiov_len > CFS_PAGE_SIZE ) + return -EINVAL; /* invalid length */ total_length += lmd->md_iov.kiov[i].kiov_len; } - lmd->length = total_length; + lmd->md_length = total_length; - if ((umd->options & PTL_MD_MAX_SIZE) != 0 && /* max size used */ - (umd->max_size < 0 || + if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /* max size used */ + (umd->max_size < 0 || umd->max_size > total_length)) // illegal max_size - return PTL_MD_ILLEGAL; - - if (nal->libnal_map_pages != NULL) { - rc = nal->libnal_map_pages (nal, niov, lmd->md_iov.kiov, - &lmd->md_addrkey); - if (rc != PTL_OK) - return (rc); - } + return -EINVAL; #endif } else { /* contiguous */ - lmd->length = umd->length; + lmd->md_length = umd->length; lmd->md_niov = niov = 1; lmd->md_iov.iov[0].iov_base = umd->start; lmd->md_iov.iov[0].iov_len = umd->length; - if ((umd->options & PTL_MD_MAX_SIZE) != 0 && /* max size used */ - (umd->max_size < 0 || - umd->max_size > umd->length)) // illegal max_size - return PTL_MD_ILLEGAL; - - if (nal->libnal_map != NULL) { - rc = nal->libnal_map (nal, niov, lmd->md_iov.iov, - &lmd->md_addrkey); - if (rc != PTL_OK) - return (rc); - } - } + if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /* max size used */ + (umd->max_size < 0 || + umd->max_size > (int)umd->length)) // illegal max_size + return -EINVAL; + } if (eq != NULL) eq->eq_refcount++; /* It's good; let handle2md succeed and add to active mds */ - lib_initialise_handle (nal, &lmd->md_lh, PTL_COOKIE_TYPE_MD); - list_add (&lmd->md_list, &nal->libnal_ni.ni_active_mds); + lnet_res_lh_initialize(&the_lnet.ln_md_container, &lmd->md_lh); + LASSERT(cfs_list_empty(&lmd->md_list)); + cfs_list_add(&lmd->md_list, &the_lnet.ln_md_container.rec_active); - return PTL_OK; + return 0; } -/* must be called with state lock held */ +/* must be called with LNET_LOCK held */ void -lib_md_deconstruct(lib_nal_t *nal, lib_md_t *lmd, ptl_md_t *umd) +lnet_md_deconstruct(lnet_libmd_t *lmd, lnet_md_t *umd) { /* NB this doesn't copy out all the iov entries so when a * discontiguous MD is copied out, the target gets to know the * original iov pointer (in start) and the number of entries it had * and that's all. */ - umd->start = lmd->start; - umd->length = ((lmd->options & (PTL_MD_IOVEC | PTL_MD_KIOV)) == 0) ? - lmd->length : lmd->md_niov; - umd->threshold = lmd->threshold; - umd->max_size = lmd->max_size; - umd->options = lmd->options; - umd->user_ptr = lmd->user_ptr; - ptl_eq2handle(&umd->eq_handle, nal, lmd->eq); + umd->start = lmd->md_start; + umd->length = ((lmd->md_options & (LNET_MD_IOVEC | LNET_MD_KIOV)) == 0) ? + lmd->md_length : lmd->md_niov; + umd->threshold = lmd->md_threshold; + umd->max_size = lmd->md_max_size; + umd->options = lmd->md_options; + umd->user_ptr = lmd->md_user_ptr; + lnet_eq2handle(&umd->eq_handle, lmd->md_eq); } -int -lib_api_md_attach(nal_t *apinal, ptl_handle_me_t *meh, - ptl_md_t *umd, ptl_unlink_t unlink, - ptl_handle_md_t *handle) +int +lnet_md_validate(lnet_md_t *umd) { - lib_nal_t *nal = apinal->nal_data; - lib_me_t *me; - lib_md_t *md; - unsigned long flags; - int rc; + if (umd->start == NULL && umd->length != 0) { + CERROR("MD start pointer can not be NULL with length %u\n", + umd->length); + return -EINVAL; + } - if ((umd->options & (PTL_MD_KIOV | PTL_MD_IOVEC)) != 0 && - umd->length > PTL_MD_MAX_IOV) /* too many fragments */ - return PTL_IOV_INVALID; + if ((umd->options & (LNET_MD_KIOV | LNET_MD_IOVEC)) != 0 && + umd->length > LNET_MAX_IOV) { + CERROR("Invalid option: too many fragments %u, %d max\n", + umd->length, LNET_MAX_IOV); + return -EINVAL; + } + + return 0; +} - md = lib_md_alloc(nal, umd); +/** + * Create a memory descriptor and attach it to a ME + * + * \param meh A handle for a ME to associate the new MD with. + * \param umd Provides initial values for the user-visible parts of a MD. + * Other than its use for initialization, there is no linkage between this + * structure and the MD maintained by the LNet. + * \param unlink A flag to indicate whether the MD is automatically unlinked + * when it becomes inactive, either because the operation threshold drops to + * zero or because the available memory becomes less than \a umd.max_size. + * (Note that the check for unlinking a MD only occurs after the completion + * of a successful operation on the MD.) The value LNET_UNLINK enables auto + * unlinking; the value LNET_RETAIN disables it. + * \param handle On successful returns, a handle to the newly created MD is + * saved here. This handle can be used later in LNetMDUnlink(). + * + * \retval 0 On success. + * \retval -EINVAL If \a umd is not valid. + * \retval -ENOMEM If new MD cannot be allocated. + * \retval -ENOENT Either \a meh or \a umd.eq_handle does not point to a + * valid object. Note that it's OK to supply a NULL \a umd.eq_handle by + * calling LNetInvalidateHandle() on it. + * \retval -EBUSY If the ME pointed to by \a meh is already associated with + * a MD. + */ +int +LNetMDAttach(lnet_handle_me_t meh, lnet_md_t umd, + lnet_unlink_t unlink, lnet_handle_md_t *handle) +{ + lnet_me_t *me; + lnet_libmd_t *md; + int rc; + + LASSERT (the_lnet.ln_init); + LASSERT (the_lnet.ln_refcount > 0); + + if (lnet_md_validate(&umd) != 0) + return -EINVAL; + + if ((umd.options & (LNET_MD_OP_GET | LNET_MD_OP_PUT)) == 0) { + CERROR("Invalid option: no MD_OP set\n"); + return -EINVAL; + } + + md = lnet_md_alloc(&umd); if (md == NULL) - return PTL_NO_SPACE; + return -ENOMEM; - LIB_LOCK(nal, flags); + LNET_LOCK(); - me = ptl_handle2me(meh, nal); + me = lnet_handle2me(&meh); if (me == NULL) { - rc = PTL_ME_INVALID; - } else if (me->md != NULL) { - rc = PTL_ME_IN_USE; + rc = -ENOENT; + } else if (me->me_md != NULL) { + rc = -EBUSY; } else { - rc = lib_md_build(nal, md, umd, unlink); - if (rc == PTL_OK) { - me->md = md; - md->me = me; + rc = lib_md_build(md, &umd, unlink); + if (rc == 0) { + the_lnet.ln_portals[me->me_portal]->ptl_ml_version++; + + me->me_md = md; + md->md_me = me; - ptl_md2handle(handle, nal, md); + lnet_md2handle(handle, md); - LIB_UNLOCK(nal, flags); - return (PTL_OK); + /* check if this MD matches any blocked msgs */ + lnet_match_blocked_msg(md); /* expects LNET_LOCK held */ + + LNET_UNLOCK(); + return (0); } } - lib_md_free (nal, md); + lnet_md_free_locked(md); - LIB_UNLOCK(nal, flags); + LNET_UNLOCK(); return (rc); } +/** + * Create a "free floating" memory descriptor - a MD that is not associated + * with a ME. Such MDs are usually used in LNetPut() and LNetGet() operations. + * + * \param umd,unlink See the discussion for LNetMDAttach(). + * \param handle On successful returns, a handle to the newly created MD is + * saved here. This handle can be used later in LNetMDUnlink(), LNetPut(), + * and LNetGet() operations. + * + * \retval 0 On success. + * \retval -EINVAL If \a umd is not valid. + * \retval -ENOMEM If new MD cannot be allocated. + * \retval -ENOENT \a umd.eq_handle does not point to a valid EQ. Note that + * it's OK to supply a NULL \a umd.eq_handle by calling + * LNetInvalidateHandle() on it. + */ int -lib_api_md_bind(nal_t *apinal, - ptl_md_t *umd, ptl_unlink_t unlink, - ptl_handle_md_t *handle) +LNetMDBind(lnet_md_t umd, lnet_unlink_t unlink, lnet_handle_md_t *handle) { - lib_nal_t *nal = apinal->nal_data; - lib_md_t *md; - unsigned long flags; - int rc; + lnet_libmd_t *md; + int rc; + + LASSERT (the_lnet.ln_init); + LASSERT (the_lnet.ln_refcount > 0); - if ((umd->options & (PTL_MD_KIOV | PTL_MD_IOVEC)) != 0 && - umd->length > PTL_MD_MAX_IOV) /* too many fragments */ - return PTL_IOV_INVALID; + if (lnet_md_validate(&umd) != 0) + return -EINVAL; - md = lib_md_alloc(nal, umd); + if ((umd.options & (LNET_MD_OP_GET | LNET_MD_OP_PUT)) != 0) { + CERROR("Invalid option: GET|PUT illegal on active MDs\n"); + return -EINVAL; + } + + md = lnet_md_alloc(&umd); if (md == NULL) - return PTL_NO_SPACE; + return -ENOMEM; - LIB_LOCK(nal, flags); + LNET_LOCK(); - rc = lib_md_build(nal, md, umd, unlink); + rc = lib_md_build(md, &umd, unlink); - if (rc == PTL_OK) { - ptl_md2handle(handle, nal, md); + if (rc == 0) { + lnet_md2handle(handle, md); - LIB_UNLOCK(nal, flags); - return (PTL_OK); + LNET_UNLOCK(); + return (0); } - lib_md_free (nal, md); + lnet_md_free_locked(md); - LIB_UNLOCK(nal, flags); + LNET_UNLOCK(); return (rc); } +/** + * Unlink the memory descriptor from any ME it may be linked to and release + * the internal resources associated with it. + * + * This function does not free the memory region associated with the MD; + * i.e., the memory the user allocated for this MD. If the ME associated with + * this MD is not NULL and was created with auto unlink enabled, the ME is + * unlinked as well (see LNetMEAttach()). + * + * Explicitly unlinking a MD via this function call has the same behavior as + * a MD that has been automatically unlinked, except that no LNET_EVENT_UNLINK + * is generated in the latter case. + * + * An unlinked event can be reported in two ways: + * - If there's no pending operations on the MD, it's unlinked immediately + * and an LNET_EVENT_UNLINK event is logged before this function returns. + * - Otherwise, the MD is only marked for deletion when this function + * returns, and the unlinked event will be piggybacked on the event of + * the completion of the last operation by setting the unlinked field of + * the event. No dedicated LNET_EVENT_UNLINK event is generated. + * + * Note that in both cases the unlinked field of the event is always set; no + * more event will happen on the MD after such an event is logged. + * + * \param mdh A handle for the MD to be unlinked. + * + * \retval 0 On success. + * \retval -ENOENT If \a mdh does not point to a valid MD object. + */ int -lib_api_md_unlink (nal_t *apinal, ptl_handle_md_t *mdh) +LNetMDUnlink (lnet_handle_md_t mdh) { - lib_nal_t *nal = apinal->nal_data; - ptl_event_t ev; - lib_md_t *md; - unsigned long flags; + lnet_event_t ev; + lnet_libmd_t *md; + + LASSERT (the_lnet.ln_init); + LASSERT (the_lnet.ln_refcount > 0); - LIB_LOCK(nal, flags); + LNET_LOCK(); - md = ptl_handle2md(mdh, nal); + md = lnet_handle2md(&mdh); if (md == NULL) { - LIB_UNLOCK(nal, flags); - return PTL_MD_INVALID; + LNET_UNLOCK(); + return -ENOENT; } - /* If the MD is busy, lib_md_unlink just marks it for deletion, and + /* If the MD is busy, lnet_md_unlink just marks it for deletion, and * when the NAL is done, the completion event flags that the MD was * unlinked. Otherwise, we enqueue an event now... */ - if (md->eq != NULL && - md->pending == 0) { - memset(&ev, 0, sizeof(ev)); - - ev.type = PTL_EVENT_UNLINK; - ev.ni_fail_type = PTL_OK; - ev.unlinked = 1; - lib_md_deconstruct(nal, md, &ev.md); - ptl_md2handle(&ev.md_handle, nal, md); - - lib_enq_event_locked(nal, NULL, md->eq, &ev); - } - - lib_md_unlink(nal, md); - - LIB_UNLOCK(nal, flags); - return PTL_OK; -} - -int -lib_api_md_update (nal_t *apinal, - ptl_handle_md_t *mdh, - ptl_md_t *oldumd, ptl_md_t *newumd, - ptl_handle_eq_t *testqh) -{ - lib_nal_t *nal = apinal->nal_data; - lib_md_t *md; - lib_eq_t *test_eq = NULL; - unsigned long flags; - int rc; - - LIB_LOCK(nal, flags); - - md = ptl_handle2md(mdh, nal); - if (md == NULL) { - rc = PTL_MD_INVALID; - goto out; - } - - if (oldumd != NULL) - lib_md_deconstruct(nal, md, oldumd); - - if (newumd == NULL) { - rc = PTL_OK; - goto out; - } - - /* XXX fttb, the new MD must be the same "shape" wrt fragmentation, - * since we simply overwrite the old lib-md */ - if ((((newumd->options ^ md->options) & - (PTL_MD_IOVEC | PTL_MD_KIOV)) != 0) || - ((newumd->options & (PTL_MD_IOVEC | PTL_MD_KIOV)) != 0 && - newumd->length != md->md_niov)) { - rc = PTL_IOV_INVALID; - goto out; - } - - if (!PtlHandleIsEqual (*testqh, PTL_EQ_NONE)) { - test_eq = ptl_handle2eq(testqh, nal); - if (test_eq == NULL) { - rc = PTL_EQ_INVALID; - goto out; - } - } - - if (md->pending != 0) { - rc = PTL_MD_NO_UPDATE; - goto out; - } - - if (test_eq == NULL || - test_eq->eq_deq_seq == test_eq->eq_enq_seq) { - lib_me_t *me = md->me; - int unlink = (md->md_flags & PTL_MD_FLAG_AUTO_UNLINK) ? - PTL_UNLINK : PTL_RETAIN; - - // #warning this does not track eq refcounts properly - rc = lib_md_build(nal, md, newumd, unlink); - - md->me = me; - } else { - rc = PTL_MD_NO_UPDATE; + if (md->md_eq != NULL && + md->md_refcount == 0) { + lnet_build_unlink_event(md, &ev); + lnet_eq_enqueue_event(md->md_eq, &ev); } - out: - LIB_UNLOCK(nal, flags); + lnet_md_unlink(md); - return rc; + LNET_UNLOCK(); + return 0; }