memset(buf, 0, sizeof(rawbuf));
data->ioc_version = OBD_IOCTL_VERSION;
- data->ioc_inllen1 = sizeof(rawbuf) - size_round(sizeof(*data));
- data->ioc_inlbuf1 = buf + size_round(sizeof(*data));
+ data->ioc_inllen1 = sizeof(rawbuf) - cfs_size_round(sizeof(*data));
+ data->ioc_inlbuf1 = buf + cfs_size_round(sizeof(*data));
data->ioc_len = obd_ioctl_packlen(data);
rc = l2_ioctl(OBD_DEV_ID, OBD_GET_VERSION, buf);
goto fail;
got_one:
- fgets(buf, sizeof(buf), fp);
+ /* should not ignore fgets(3)'s return value */
+ if (!fgets(buf, sizeof(buf), fp)) {
+ fprintf(stderr, "reading from %s: %s", buf, strerror(errno));
+ fclose(fp);
+ return;
+ }
fclose(fp);
/* trim trailing newlines */
for (index = 0;; index++) {
memset(buf, 0, sizeof(rawbuf));
data->ioc_version = OBD_IOCTL_VERSION;
- data->ioc_inllen1 = sizeof(rawbuf) - size_round(sizeof(*data));
- data->ioc_inlbuf1 = buf + size_round(sizeof(*data));
+ data->ioc_inllen1 =
+ sizeof(rawbuf) - cfs_size_round(sizeof(*data));
+ data->ioc_inlbuf1 = buf + cfs_size_round(sizeof(*data));
data->ioc_len = obd_ioctl_packlen(data);
data->ioc_count = index;
l_cond_broadcast(&shared_data->cond);
else
l_cond_wait(&shared_data->cond,
- &shared_data->mutex);
+ &shared_data->mutex);
shmem_unlock ();
}
memset(&data, 0x00, sizeof(data));
data.ioc_dev = cur_device;
- data.ioc_inllen1 = sizeof(rawbuf) - size_round(sizeof(data));
+ data.ioc_inllen1 = sizeof(rawbuf) - cfs_size_round(sizeof(data));
memset(buf, 0, sizeof(rawbuf));
rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
if (rc) {
data.ioc_dev = cur_device;
data.ioc_inllen1 = strlen(argv[1]) + 1;
data.ioc_inlbuf1 = argv[1];
- data.ioc_inllen2 = sizeof(rawbuf) - size_round(sizeof(data)) -
- size_round(data.ioc_inllen1);
+ data.ioc_inllen2 = sizeof(rawbuf) - cfs_size_round(sizeof(data)) -
+ cfs_size_round(data.ioc_inllen1);
memset(buf, 0, sizeof(rawbuf));
rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
if (rc) {
data.ioc_inllen3 = strlen(to) + 1;
data.ioc_inlbuf3 = to;
}
- data.ioc_inllen4 = sizeof(rawbuf) - size_round(sizeof(data)) -
- size_round(data.ioc_inllen1) -
- size_round(data.ioc_inllen2) -
- size_round(data.ioc_inllen3);
+ data.ioc_inllen4 = sizeof(rawbuf) - cfs_size_round(sizeof(data)) -
+ cfs_size_round(data.ioc_inllen1) -
+ cfs_size_round(data.ioc_inllen2) -
+ cfs_size_round(data.ioc_inllen3);
memset(buf, 0, sizeof(rawbuf));
rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
if (rc) {
data.ioc_inllen3 = strlen(to) + 1;
data.ioc_inlbuf3 = to;
}
- data.ioc_inllen4 = sizeof(rawbuf) - size_round(sizeof(data)) -
- size_round(data.ioc_inllen1) -
- size_round(data.ioc_inllen2) -
- size_round(data.ioc_inllen3);
+ data.ioc_inllen4 = sizeof(rawbuf) - cfs_size_round(sizeof(data)) -
+ cfs_size_round(data.ioc_inllen1) -
+ cfs_size_round(data.ioc_inllen2) -
+ cfs_size_round(data.ioc_inllen3);
memset(buf, 0, sizeof(rawbuf));
rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
if (rc) {
do_disconnect(argv[0], 1);
}
-static int find_target_obdpath(char *fsname, char *path)
-{
- glob_t glob_info;
- char pattern[PATH_MAX + 1];
- int rc;
-
- snprintf(pattern, PATH_MAX,
- "/proc/fs/lustre/lov/%s-*/target_obd",
- fsname);
- rc = glob(pattern, GLOB_BRACE, NULL, &glob_info);
- if (rc == GLOB_NOMATCH)
- return -ENODEV;
- else if (rc)
- return -EINVAL;
-
- strcpy(path, glob_info.gl_pathv[0]);
- globfree(&glob_info);
- return 0;
-}
-
-static int find_poolpath(char *fsname, char *poolname, char *poolpath)
+static int check_pool_cmd(enum lcfg_command_type cmd,
+ char *fsname, char *poolname,
+ char *ostname)
{
- glob_t glob_info;
- char pattern[PATH_MAX + 1];
int rc;
- snprintf(pattern, PATH_MAX,
- "/proc/fs/lustre/lov/%s-*/pools/%s",
- fsname, poolname);
- rc = glob(pattern, GLOB_BRACE, NULL, &glob_info);
- /* If no pools, make sure the lov is available */
- if ((rc == GLOB_NOMATCH) &&
- (find_target_obdpath(fsname, poolpath) == -ENODEV))
- return -ENODEV;
- if (rc)
- return -EINVAL;
-
- strcpy(poolpath, glob_info.gl_pathv[0]);
- globfree(&glob_info);
- return 0;
-}
-
-/*
- * if pool is NULL, search ostname in target_obd
- * if pool is no NULL
- * if pool not found returns < 0
- * if ostname is NULL, returns 1 if pool is not empty and 0 if pool empty
- * if ostname is not NULL, returns 1 if OST is in pool and 0 if not
- */
-static int search_ost(char *fsname, char *poolname, char *ostname)
-{
- FILE *fd;
- char buffer[PATH_MAX + 1];
- int len = 0, rc;
-
- if (ostname != NULL)
- len = strlen(ostname);
-
- if (poolname == NULL)
- rc = find_target_obdpath(fsname, buffer);
- else
- rc = find_poolpath(fsname, poolname, buffer);
- if (rc)
+ rc = llapi_search_ost(fsname, poolname, ostname);
+ if (rc < 0 && (cmd != LCFG_POOL_NEW)) {
+ fprintf(stderr, "Pool %s.%s not found\n",
+ fsname, poolname);
return rc;
-
- if ((fd = fopen(buffer, "r")) == NULL)
- return -EINVAL;
-
- while (fgets(buffer, sizeof(buffer), fd) != NULL) {
- if (poolname == NULL) {
- char *ptr;
- /* Search for an ostname in the list of OSTs
- Line format is IDX: fsname-OSTxxxx_UUID STATUS */
- ptr = strchr(buffer, ' ');
- if ((ptr != NULL) &&
- (strncmp(ptr + 1, ostname, len) == 0)) {
- fclose(fd);
- return 1;
- }
- } else {
- /* Search for an ostname in a pool,
- (or an existing non-empty pool if no ostname) */
- if ((ostname == NULL) ||
- (strncmp(buffer, ostname, len) == 0)) {
- fclose(fd);
- return 1;
- }
- }
}
- fclose(fd);
- return 0;
-}
-
-static int check_pool_cmd(enum lcfg_command_type cmd,
- char *fsname, char *poolname,
- char *ostname)
-{
- int rc = 0;
switch (cmd) {
case LCFG_POOL_NEW: {
- if (search_ost(fsname, poolname, NULL) >= 0) {
+ LASSERT(ostname == NULL);
+ if (rc >= 0) {
fprintf(stderr, "Pool %s.%s already exists\n",
fsname, poolname);
return -EEXIST;
return 0;
}
case LCFG_POOL_DEL: {
- rc = search_ost(fsname, poolname, NULL);
- if (rc < 0) {
- fprintf(stderr, "Pool %s.%s not found\n",
- fsname, poolname);
- return rc;
- }
+ LASSERT(ostname == NULL);
if (rc == 1) {
fprintf(stderr, "Pool %s.%s not empty, "
"please remove all members\n",
return 0;
}
case LCFG_POOL_ADD: {
- rc = search_ost(fsname, NULL, ostname);
- if (rc == 0) {
- fprintf(stderr, "OST %s not found in lov of %s\n",
- ostname, fsname);
- return -ENOENT;
- }
- rc = search_ost(fsname, poolname, ostname);
- if (rc < 0) {
- fprintf(stderr, "Pool %s.%s not found\n",
- fsname, poolname);
- return rc;
- }
if (rc == 1) {
- fprintf(stderr, "OST %s already in pool %s.%s\n",
+ fprintf(stderr, "OST %s is already in pool %s.%s\n",
ostname, fsname, poolname);
return -EEXIST;
}
+ rc = llapi_search_ost(fsname, NULL, ostname);
+ if (rc == 0) {
+ fprintf(stderr, "OST %s is not part of the '%s' fs.\n",
+ ostname, fsname);
+ return -ENOENT;
+ }
return 0;
}
case LCFG_POOL_REM: {
- rc = search_ost(fsname, poolname, ostname);
- if (rc < 0) {
- fprintf(stderr, "Pool %s.%s not found\n",
- fsname, poolname);
- return rc;
- }
if (rc == 0) {
fprintf(stderr, "OST %s not found in pool %s.%s\n",
ostname, fsname, poolname);
}
return 0;
}
- default: {
- }
- }
- return 0;
+ default:
+ break;
+ } /* switch */
+ return -EINVAL;
}
-static void check_pool_cmd_result(enum lcfg_command_type cmd,
- char *fsname, char *poolname,
- char *ostname)
+/* This check only verifies that the changes have been "pushed out" to
+ the client successfully. This involves waiting for a config update,
+ and so may fail because of problems in that code or post-command
+ network loss. So reporting a warning is appropriate, but not a failure.
+*/
+static int check_pool_cmd_result(enum lcfg_command_type cmd,
+ char *fsname, char *poolname,
+ char *ostname)
{
- int cpt, rc = 0;
+ int cpt = 10;
+ int rc = 0;
- cpt = 10;
switch (cmd) {
case LCFG_POOL_NEW: {
do {
- rc = search_ost(fsname, poolname, NULL);
+ rc = llapi_search_ost(fsname, poolname, NULL);
if (rc == -ENODEV)
- return;
+ return rc;
if (rc < 0)
sleep(2);
cpt--;
} while ((rc < 0) && (cpt > 0));
- if (rc >= 0)
+ if (rc >= 0) {
fprintf(stderr, "Pool %s.%s created\n",
fsname, poolname);
- else
+ return 0;
+ } else {
fprintf(stderr, "Warning, pool %s.%s not found\n",
fsname, poolname);
- return;
+ return -ENOENT;
+ }
}
case LCFG_POOL_DEL: {
do {
- rc = search_ost(fsname, poolname, NULL);
+ rc = llapi_search_ost(fsname, poolname, NULL);
if (rc == -ENODEV)
- return;
+ return rc;
if (rc >= 0)
sleep(2);
cpt--;
} while ((rc >= 0) && (cpt > 0));
- if (rc < 0)
+ if (rc < 0) {
fprintf(stderr, "Pool %s.%s destroyed\n",
fsname, poolname);
- else
+ return 0;
+ } else {
fprintf(stderr, "Warning, pool %s.%s still found\n",
fsname, poolname);
- return;
+ return -EEXIST;
+ }
}
case LCFG_POOL_ADD: {
do {
- rc = search_ost(fsname, poolname, ostname);
+ rc = llapi_search_ost(fsname, poolname, ostname);
if (rc == -ENODEV)
- return;
+ return rc;
if (rc != 1)
sleep(2);
cpt--;
} while ((rc != 1) && (cpt > 0));
- if (rc == 1)
+ if (rc == 1) {
fprintf(stderr, "OST %s added to pool %s.%s\n",
ostname, fsname, poolname);
- else
+ return 0;
+ } else {
fprintf(stderr, "Warning, OST %s not found in pool %s.%s\n",
ostname, fsname, poolname);
- return;
+ return -ENOENT;
+ }
}
case LCFG_POOL_REM: {
do {
- rc = search_ost(fsname, poolname, ostname);
+ rc = llapi_search_ost(fsname, poolname, ostname);
if (rc == -ENODEV)
- return;
+ return rc;
if (rc == 1)
sleep(2);
cpt--;
} while ((rc == 1) && (cpt > 0));
- if (rc != 1)
+ if (rc != 1) {
fprintf(stderr, "OST %s removed from pool %s.%s\n",
ostname, fsname, poolname);
- else
+ return 0;
+ } else {
fprintf(stderr, "Warning, OST %s still found in pool %s.%s\n",
ostname, fsname, poolname);
- return;
- }
- default: {
+ return -EEXIST;
+ }
}
+ default:
+ break;
}
+ return -EINVAL;
}
static int check_and_complete_ostname(char *fsname, char *ostname)
cmds[j].rc = pool_cmd(cmd, argv[0], argv[1],
fsname, poolname,
ostname);
+ /* Return an err if any of the add/dels fail */
+ if (!rc)
+ rc = cmds[j].rc;
}
for (j = 0; j < array_sz; j++) {
if (!cmds[j].rc) {
if (ostnames_buf);
free(ostnames_buf);
}
- return 0;
+ /* fall through */
}
- }
-
+ } /* switch */
out:
- if ((rc == -EINVAL) || (rc == -ENOENT))
- fprintf(stderr, "Does the fs, pool or ost exist?\n");
if (rc != 0) {
errno = -rc;
perror(argv[0]);
return rc;
}
+int jt_get_obj_version(int argc, char **argv)
+{
+ struct lu_fid fid;
+ struct obd_ioctl_data data;
+ __u64 version;
+ char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf, *fidstr;
+ int rc;
+
+ if (argc != 2)
+ return CMD_HELP;
+
+ fidstr = argv[1];
+ while (*fidstr == '[')
+ fidstr++;
+ sscanf(fidstr, SFID, RFID(&fid));
+ if (!fid_is_sane(&fid)) {
+ fprintf(stderr, "bad FID format [%s], should be "DFID"\n",
+ fidstr, (__u64)1, 2, 0);
+ return -EINVAL;
+ }
+
+ memset(&data, 0, sizeof data);
+ data.ioc_dev = cur_device;
+ data.ioc_inlbuf1 = (char *) &fid;
+ data.ioc_inllen1 = sizeof fid;
+ data.ioc_inlbuf2 = (char *) &version;
+ data.ioc_inllen2 = sizeof version;
+
+ memset(buf, 0, sizeof *buf);
+ rc = obd_ioctl_pack(&data, &buf, sizeof rawbuf);
+ if (rc) {
+ fprintf(stderr, "error: %s: packing ioctl arguments: %s\n",
+ jt_cmdname(argv[0]), strerror(-rc));
+ return rc;
+ }
+
+ rc = l2_ioctl(OBD_DEV_ID, OBD_IOC_GET_OBJ_VERSION, buf);
+ if (rc == -1) {
+ fprintf(stderr, "error: %s: ioctl: %s\n",
+ jt_cmdname(argv[0]), strerror(errno));
+ return -errno;
+ }
+
+ obd_ioctl_unpack(&data, buf, sizeof rawbuf);
+ printf(LPX64"\n", version);
+ return 0;
+}
+
void llapi_ping_target(char *obd_type, char *obd_name,
char *obd_uuid, void *args)
{
} else {
printf("%s active.\n", obd_name);
}
+}
+
+int jt_changelog_register(int argc, char **argv)
+{
+ char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf;
+ struct obd_ioctl_data data;
+ char devname[30];
+ int rc;
+
+ if (argc > 2)
+ return CMD_HELP;
+ else if (argc == 2 && strcmp(argv[1], "-n") != 0)
+ return CMD_HELP;
+ if (cur_device < 0)
+ return CMD_HELP;
+
+ memset(&data, 0x00, sizeof(data));
+ data.ioc_dev = cur_device;
+ memset(buf, 0, sizeof(rawbuf));
+ rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
+ if (rc) {
+ fprintf(stderr, "error: %s: invalid ioctl\n",
+ jt_cmdname(argv[0]));
+ return rc;
+ }
+
+ rc = l2_ioctl(OBD_DEV_ID, OBD_IOC_CHANGELOG_REG, buf);
+ if (rc < 0) {
+ fprintf(stderr, "error: %s: %s\n", jt_cmdname(argv[0]),
+ strerror(rc = errno));
+ return rc;
+ }
+ obd_ioctl_unpack(&data, buf, sizeof(rawbuf));
+
+ if (data.ioc_u32_1 == 0) {
+ fprintf(stderr, "received invalid userid!\n");
+ return EPROTO;
+ }
+
+ if (lcfg_get_devname() != NULL)
+ strcpy(devname, lcfg_get_devname());
+ else
+ sprintf(devname, "dev %d", cur_device);
+
+ if (argc == 2)
+ /* -n means bare name */
+ printf(CHANGELOG_USER_PREFIX"%u\n", data.ioc_u32_1);
+ else
+ printf("%s: Registered changelog userid '"CHANGELOG_USER_PREFIX
+ "%u'\n", devname, data.ioc_u32_1);
+ return 0;
+}
+
+int jt_changelog_deregister(int argc, char **argv)
+{
+ char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf;
+ struct obd_ioctl_data data;
+ char devname[30];
+ int id, rc;
+
+ if (argc != 2 || cur_device < 0)
+ return CMD_HELP;
+
+ id = strtol(argv[1] + strlen(CHANGELOG_USER_PREFIX), NULL, 10);
+ if ((id == 0) || (strncmp(argv[1], CHANGELOG_USER_PREFIX,
+ strlen(CHANGELOG_USER_PREFIX)) != 0)) {
+ fprintf(stderr, "expecting id of the form '"
+ CHANGELOG_USER_PREFIX"<num>'; got '%s'\n", argv[1]);
+ return CMD_HELP;
+ }
+
+ memset(&data, 0x00, sizeof(data));
+ data.ioc_dev = cur_device;
+ data.ioc_u32_1 = id;
+ memset(buf, 0, sizeof(rawbuf));
+ rc = obd_ioctl_pack(&data, &buf, sizeof(rawbuf));
+ if (rc) {
+ fprintf(stderr, "error: %s: invalid ioctl\n",
+ jt_cmdname(argv[0]));
+ return rc;
+ }
+
+ rc = l2_ioctl(OBD_DEV_ID, OBD_IOC_CHANGELOG_DEREG, buf);
+ if (rc < 0) {
+ fprintf(stderr, "error: %s: %s\n", jt_cmdname(argv[0]),
+ strerror(rc = errno));
+ return rc;
+ }
+ obd_ioctl_unpack(&data, buf, sizeof(rawbuf));
+
+ if (data.ioc_u32_1 != id) {
+ fprintf(stderr, "No changelog user '%s'. Blocking user"
+ " is '"CHANGELOG_USER_PREFIX"%d'.\n", argv[1],
+ data.ioc_u32_1);
+ return ENOENT;
+ }
+
+ if (lcfg_get_devname() != NULL)
+ strcpy(devname, lcfg_get_devname());
+ else
+ sprintf(devname, "dev %d", cur_device);
+ printf("%s: Deregistered changelog user '"CHANGELOG_USER_PREFIX"%d'\n",
+ devname, data.ioc_u32_1);
+ return 0;
}
+
+