Whamcloud - gitweb
LU-2281 utils: Fix possible segfault in tunefs.lustre
[fs/lustre-release.git] / lustre / utils / mount_utils_ldiskfs.c
index 4321bcb..fe365e8 100644 (file)
 #ifndef _GNU_SOURCE
 #define _GNU_SOURCE
 #endif
+#include "mount_utils.h"
 #include <stdlib.h>
 #include <stdio.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <stdarg.h>
 #include <mntent.h>
+#include <glob.h>
 
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <lustre_param.h>
 #include <lnet/lnetctl.h>
 #include <lustre_ver.h>
-#include "mount_utils.h"
+
+#define MAX_HW_SECTORS_KB_PATH "queue/max_hw_sectors_kb"
+#define MAX_SECTORS_KB_PATH    "queue/max_sectors_kb"
+#define STRIPE_CACHE_SIZE      "md/stripe_cache_size"
 
 extern char *progname;
 
@@ -87,7 +92,7 @@ extern char *progname;
 #define EXT3_DIRENT_SIZE                DUMMY_FILE_NAME_LEN
 
 /* Write the server config files */
-int write_local_files(struct mkfs_opts *mop)
+int ldiskfs_write_ldd(struct mkfs_opts *mop)
 {
        char mntpt[] = "/tmp/mntXXXXXX";
        char filepnm[128];
@@ -145,6 +150,7 @@ int write_local_files(struct mkfs_opts *mop)
        if (num < 1 && ferror(filep)) {
                fprintf(stderr, "%s: Unable to write to file (%s): %s\n",
                        progname, filepnm, strerror(errno));
+               fclose(filep);
                goto out_umnt;
        }
        fclose(filep);
@@ -156,6 +162,25 @@ out_rmdir:
        return ret;
 }
 
+static int readcmd(char *cmd, char *buf, int len)
+{
+       FILE *fp;
+       int red;
+
+       fp = popen(cmd, "r");
+       if (!fp)
+               return errno;
+
+       red = fread(buf, 1, len, fp);
+       pclose(fp);
+
+       /* strip trailing newline */
+       if (buf[red - 1] == '\n')
+               buf[red - 1] = '\0';
+
+       return (red == 0) ? -ENOENT : 0;
+}
+
 int ldiskfs_read_ldd(char *dev, struct lustre_disk_data *mo_ldd)
 {
        char tmpdir[] = "/tmp/dirXXXXXX";
@@ -194,16 +219,19 @@ int ldiskfs_read_ldd(char *dev, struct lustre_disk_data *mo_ldd)
                if (num_read < 1 && ferror(filep)) {
                        fprintf(stderr, "%s: Unable to read from file %s: %s\n",
                                progname, filepnm, strerror(errno));
-                       goto out_close;
                }
+               fclose(filep);
        }
-out_close:
-       fclose(filep);
 
        snprintf(cmd, cmdsz, "rm -rf %s", tmpdir);
        run_command(cmd, cmdsz);
        if (ret)
                verrprint("Failed to read old data (%d)\n", ret);
+
+       /* As long as we at least have the label, we're good to go */
+       snprintf(cmd, sizeof(cmd), E2LABEL" %s", dev);
+       ret = readcmd(cmd, mo_ldd->ldd_svname, sizeof(mo_ldd->ldd_svname) - 1);
+
        return ret;
 }
 
@@ -376,8 +404,8 @@ static void append_unique(char *buf, char *prefix, char *key, char *val,
        }
 }
 
-static void enable_default_ext4_features(struct mkfs_opts *mop, char *anchor,
-                                        size_t maxbuflen, int user_spec)
+static int enable_default_ext4_features(struct mkfs_opts *mop, char *anchor,
+                                       size_t maxbuflen, int user_spec)
 {
        if (IS_OST(&mop->mo_ldd)) {
                append_unique(anchor, user_spec ? "," : " -O ",
@@ -408,7 +436,17 @@ static void enable_default_ext4_features(struct mkfs_opts *mop, char *anchor,
        /* The following options are only valid for ext4-based ldiskfs.
         * If --backfstype=ext3 is specified, do not enable them. */
        if (mop->mo_ldd.ldd_mount_type == LDD_MT_EXT3)
-               return;
+               return 0;
+
+       /* Enable quota by default */
+       if (is_e2fsprogs_feature_supp("-O quota") == 0) {
+               append_unique(anchor, ",", "quota", NULL, maxbuflen);
+       } else {
+               fatal();
+               fprintf(stderr, "\"-O quota\" must be supported by "
+                       "e2fsprogs, please upgrade your e2fsprogs.\n");
+               return EINVAL;
+       }
 
        /* Allow files larger than 2TB.  Also needs LU-16, but not harmful. */
        if (is_e2fsprogs_feature_supp("-O huge_file") == 0)
@@ -434,6 +472,7 @@ static void enable_default_ext4_features(struct mkfs_opts *mop, char *anchor,
                }
        }
        /* Don't add any more "-O" options here, see last comment above */
+       return 0;
 }
 
 /**
@@ -476,7 +515,7 @@ static char *moveopts_to_end(char *start)
 }
 
 /* Build fs according to type */
-int make_lustre_backfs(struct mkfs_opts *mop)
+int ldiskfs_make_lustre(struct mkfs_opts *mop)
 {
        __u64 device_sz = mop->mo_device_sz, block_count = 0;
        char mkfs_cmd[PATH_MAX];
@@ -629,13 +668,15 @@ int make_lustre_backfs(struct mkfs_opts *mop)
                        start = moveopts_to_end(start);
                        maxbuflen = sizeof(mop->mo_mkfsopts) -
                                (start - mop->mo_mkfsopts) - strlen(start);
-                       enable_default_ext4_features(mop, start, maxbuflen, 1);
+                       ret = enable_default_ext4_features(mop, start, maxbuflen, 1);
                } else {
                        start = mop->mo_mkfsopts + strlen(mop->mo_mkfsopts),
                              maxbuflen = sizeof(mop->mo_mkfsopts) -
                                      strlen(mop->mo_mkfsopts);
-                       enable_default_ext4_features(mop, start, maxbuflen, 0);
+                       ret = enable_default_ext4_features(mop, start, maxbuflen, 0);
                }
+               if (ret)
+                       return ret;
                /* end handle -O mkfs options */
 
                /* start handle -E mkfs options */
@@ -745,6 +786,242 @@ int ldiskfs_prepare_lustre(struct mkfs_opts *mop,
        return 0;
 }
 
+int read_file(char *path, char *buf, int size)
+{
+       FILE *fd;
+
+       fd = fopen(path, "r");
+       if (fd == NULL)
+               return errno;
+
+       /* should not ignore fgets(3)'s return value */
+       if (!fgets(buf, size, fd)) {
+               fprintf(stderr, "reading from %s: %s", path, strerror(errno));
+               fclose(fd);
+               return 1;
+       }
+       fclose(fd);
+       return 0;
+}
+
+int write_file(char *path, char *buf)
+{
+       FILE *fd;
+
+       fd = fopen(path, "w");
+       if (fd == NULL)
+               return errno;
+
+       fputs(buf, fd);
+       fclose(fd);
+       return 0;
+}
+
+/* This is to tune the kernel for good SCSI performance.
+ * For that we set the value of /sys/block/{dev}/queue/max_sectors_kb
+ * to the value of /sys/block/{dev}/queue/max_hw_sectors_kb */
+int set_blockdev_tunables(char *source, struct mount_opts *mop, int fan_out)
+{
+       glob_t glob_info = { 0 };
+       struct stat stat_buf;
+       char *chk_major, *chk_minor;
+       char *savept = NULL, *dev;
+       char *ret_path;
+       char buf[PATH_MAX] = {'\0'}, path[PATH_MAX] = {'\0'};
+       char real_path[PATH_MAX] = {'\0'};
+       int i, rc = 0;
+       int major, minor;
+
+       if (!source)
+               return -EINVAL;
+
+       ret_path = realpath(source, real_path);
+       if (ret_path == NULL) {
+               if (verbose)
+                       fprintf(stderr, "warning: %s: cannot resolve: %s\n",
+                               source, strerror(errno));
+               return -EINVAL;
+       }
+
+       if (strncmp(real_path, "/dev/loop", 9) == 0)
+               return 0;
+
+       if ((real_path[0] != '/') && (strpbrk(real_path, ",:") != NULL))
+               return 0;
+
+       snprintf(path, sizeof(path), "/sys/block%s", real_path + 4);
+       if (access(path, X_OK) == 0)
+               goto set_params;
+
+       /* The name of the device say 'X' specified in /dev/X may not
+        * match any entry under /sys/block/. In that case we need to
+        * match the major/minor number to find the entry under
+        * sys/block corresponding to /dev/X */
+
+       /* Don't chop tail digit on /dev/mapper/xxx, LU-478 */
+       if (strncmp(real_path, "/dev/mapper", 11) != 0) {
+               dev = real_path + strlen(real_path);
+               while (--dev > real_path && isdigit(*dev))
+                       *dev = 0;
+
+               if (strncmp(real_path, "/dev/md_", 8) == 0)
+                       *dev = 0;
+       }
+
+       rc = stat(real_path, &stat_buf);
+       if (rc) {
+               if (verbose)
+                       fprintf(stderr, "warning: %s, device %s stat failed\n",
+                               strerror(errno), real_path);
+               return rc;
+       }
+
+       major = major(stat_buf.st_rdev);
+       minor = minor(stat_buf.st_rdev);
+       rc = glob("/sys/block/*", GLOB_NOSORT, NULL, &glob_info);
+       if (rc) {
+               if (verbose)
+                       fprintf(stderr, "warning: failed to read entries under "
+                               "/sys/block\n");
+               globfree(&glob_info);
+               return rc;
+       }
+
+       for (i = 0; i < glob_info.gl_pathc; i++){
+               snprintf(path, sizeof(path), "%s/dev", glob_info.gl_pathv[i]);
+
+               rc = read_file(path, buf, sizeof(buf));
+               if (rc)
+                       continue;
+
+               if (buf[strlen(buf) - 1] == '\n')
+                       buf[strlen(buf) - 1] = '\0';
+
+               chk_major = strtok_r(buf, ":", &savept);
+               chk_minor = savept;
+               if (major == atoi(chk_major) &&minor == atoi(chk_minor))
+                       break;
+       }
+
+       if (i == glob_info.gl_pathc) {
+               if (verbose)
+                       fprintf(stderr,"warning: device %s does not match any "
+                               "entry under /sys/block\n", real_path);
+               globfree(&glob_info);
+               return -EINVAL;
+       }
+
+       /* Chop off "/dev" from path we found */
+       path[strlen(glob_info.gl_pathv[i])] = '\0';
+       globfree(&glob_info);
+
+set_params:
+       if (strncmp(real_path, "/dev/md", 7) == 0) {
+               snprintf(real_path, sizeof(real_path), "%s/%s", path,
+                        STRIPE_CACHE_SIZE);
+
+               rc = read_file(real_path, buf, sizeof(buf));
+               if (rc) {
+                       if (verbose)
+                               fprintf(stderr, "warning: opening %s: %s\n",
+                                       real_path, strerror(errno));
+                       return 0;
+               }
+
+               if (atoi(buf) >= mop->mo_md_stripe_cache_size)
+                       return 0;
+
+               if (strlen(buf) - 1 > 0) {
+                       snprintf(buf, sizeof(buf), "%d",
+                                mop->mo_md_stripe_cache_size);
+                       rc = write_file(real_path, buf);
+                       if (rc && verbose)
+                               fprintf(stderr, "warning: opening %s: %s\n",
+                                       real_path, strerror(errno));
+               }
+               /* Return since raid and disk tunables are different */
+               return rc;
+       }
+
+       snprintf(real_path, sizeof(real_path), "%s/%s", path,
+                MAX_HW_SECTORS_KB_PATH);
+       rc = read_file(real_path, buf, sizeof(buf));
+       if (rc) {
+               if (verbose)
+                       fprintf(stderr, "warning: opening %s: %s\n",
+                               real_path, strerror(errno));
+               /* No MAX_HW_SECTORS_KB_PATH isn't necessary an
+                * error for some device. */
+               rc = 0;
+       }
+
+       if (strlen(buf) - 1 > 0) {
+               snprintf(real_path, sizeof(real_path), "%s/%s", path,
+                        MAX_SECTORS_KB_PATH);
+               rc = write_file(real_path, buf);
+               if (rc) {
+                       if (verbose)
+                               fprintf(stderr, "warning: writing to %s: %s\n",
+                                       real_path, strerror(errno));
+                       /* No MAX_SECTORS_KB_PATH isn't necessary an
+                        * error for some device. */
+                       rc = 0;
+               }
+       }
+
+       if (fan_out) {
+               char *slave = NULL;
+               glob_info.gl_pathc = 0;
+               glob_info.gl_offs = 0;
+               /* if device is multipath device, tune its slave devices */
+               snprintf(real_path, sizeof(real_path), "%s/slaves/*", path);
+               rc = glob(real_path, GLOB_NOSORT, NULL, &glob_info);
+
+               for (i = 0; rc == 0 && i < glob_info.gl_pathc; i++){
+                       slave = basename(glob_info.gl_pathv[i]);
+                       snprintf(real_path, sizeof(real_path), "/dev/%s", slave);
+                       rc = set_blockdev_tunables(real_path, mop, 0);
+               }
+
+               if (rc == GLOB_NOMATCH) {
+                       /* no slave device is not an error */
+                       rc = 0;
+               } else if (rc && verbose) {
+                       if (slave == NULL) {
+                               fprintf(stderr, "warning: %s, failed to read"
+                                       " entries under %s/slaves\n",
+                                       strerror(errno), path);
+                       } else {
+                               fprintf(stderr, "unable to set tunables for"
+                                       " slave device %s (slave would be"
+                                       " unable to handle IO request from"
+                                       " master %s)\n",
+                                       real_path, source);
+                       }
+               }
+               globfree(&glob_info);
+       }
+
+       return rc;
+}
+
+int ldiskfs_tune_lustre(char *dev, struct mount_opts *mop)
+{
+       return set_blockdev_tunables(dev, mop, 1);
+}
+
+int ldiskfs_label_lustre(struct mount_opts *mop)
+{
+       char label_cmd[PATH_MAX];
+       int rc;
+
+       snprintf(label_cmd, sizeof(label_cmd), E2LABEL" %s %s",
+                mop->mo_source, mop->mo_ldd.ldd_svname);
+       rc = run_command(label_cmd, sizeof(label_cmd));
+
+       return rc;
+}
+
 /* return canonicalized absolute pathname, even if the target file does not
  * exist, unlike realpath */
 static char *absolute_path(char *devname)
@@ -758,8 +1035,10 @@ static char *absolute_path(char *devname)
                return NULL;
 
        if (devname[0] != '/') {
-               if (getcwd(buf, sizeof(buf) - 1) == NULL)
+               if (getcwd(buf, sizeof(buf) - 1) == NULL) {
+                       free(path);
                        return NULL;
+               }
                strcat(buf, "/");
                strcat(buf, devname);
        } else {
@@ -820,3 +1099,73 @@ out:
        return ret;
 }
 
+static int is_feature_enabled(const char *feature, const char *devpath)
+{
+       char cmd[PATH_MAX];
+       FILE *fp;
+       char enabled_features[4096] = "";
+
+       snprintf(cmd, sizeof(cmd), "%s -R features %s 2>&1",
+                DEBUGFS, devpath);
+
+       /* Using popen() instead of run_command() since debugfs does
+        * not return proper error code if command is not supported */
+       fp = popen(cmd, "r");
+       if (!fp) {
+               fprintf(stderr, "%s: %s\n", progname, strerror(errno));
+               return 0;
+       }
+
+       fread(enabled_features, 1, sizeof(enabled_features), fp);
+       fclose(fp);
+
+       if (strstr(enabled_features, feature))
+               return 1;
+       return 0;
+}
+
+/* Enable quota accounting */
+int ldiskfs_enable_quota(struct mkfs_opts *mop)
+{
+       char *dev;
+       char cmd[512];
+       int cmdsz = sizeof(cmd), ret;
+
+       if (is_e2fsprogs_feature_supp("-O quota") != 0) {
+               fprintf(stderr, "%s: \"-O quota\" is is not supported by "
+                       "current e2fsprogs\n", progname);
+               return EINVAL;
+       }
+
+       dev = mop->mo_device;
+       if (mop->mo_flags & MO_IS_LOOP)
+               dev = mop->mo_loopdev;
+
+       /* Quota feature is already enabled? */
+       if (is_feature_enabled("quota", dev)) {
+               vprint("Quota feature is already enabled.\n");
+               return 0;
+       }
+
+       /* Turn on quota feature by "tune2fs -O quota" */
+       snprintf(cmd, cmdsz, "%s -O quota %s", TUNE2FS, dev);
+       ret = run_command(cmd, cmdsz);
+       if (ret)
+               fprintf(stderr, "command:%s (%d)", cmd, ret);
+
+       return ret;
+}
+
+int ldiskfs_init(void)
+{
+       /* Required because full path to DEBUGFS is not specified */
+       setenv("PATH", "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin", 0);
+
+       return 0;
+}
+
+void ldiskfs_fini(void)
+{
+       return;
+}
+