LU-8361 lfsck: detect Lustre device automatically

[fs/lustre-release.git] / lustre / utils / lustre_lfsck.c

diff --git a/lustre/utils/lustre_lfsck.c b/lustre/utils/lustre_lfsck.c
index 7937ca1..2de436c 100644 (file)
--- a/lustre/utils/lustre_lfsck.c
+++ b/lustre/utils/lustre_lfsck.c
@@ -46,6 +46,7 @@
 #include <lustre_ioctl.h>
 /* Needs to be last to avoid clashes */
 #include <libcfs/util/ioctl.h>
+#include <libcfs/util/param.h>
 
 static struct option long_opt_start[] = {
        {"device",              required_argument, 0, 'M'},
@@ -122,7 +123,7 @@ static void usage_start(void)
 {
        fprintf(stderr, "start LFSCK\n"
                "usage:\n"
-               "lfsck_start <-M | --device {MDT,OST}_device>\n"
+               "lfsck_start [-M | --device {MDT,OST}_device]\n"
                "            [-A | --all] [-c | --create_ostobj [on | off]]\n"
                "            [-C | --create_mdtobj [on | off]]\n"
                "            [-e | --error {continue | abort}] [-h | --help]\n"
@@ -154,7 +155,7 @@ static void usage_stop(void)
 {
        fprintf(stderr, "stop LFSCK\n"
                "usage:\n"
-               "lfsck_stop <-M | --device {MDT,OST}_device>\n"
+               "lfsck_stop [-M | --device {MDT,OST}_device]\n"
                "           [-A | --all] [-h | --help]\n"
                "options:\n"
                "-M: device to stop LFSCK/scrub on\n"
@@ -167,7 +168,7 @@ static void usage_query(void)
 {
        fprintf(stderr, "check the LFSCK global status\n"
                "usage:\n"
-               "lfsck_query <-M | --device MDT_device> [-h | --help]\n"
+               "lfsck_query [-M | --device MDT_device] [-h | --help]\n"
                "            [-t | --type check_type[,check_type...]]\n"
                "            [-t | --wait]\n"
                "options:\n"
@@ -194,6 +195,74 @@ static int lfsck_pack_dev(struct obd_ioctl_data *data, char *device, char *arg)
        return 0;
 }
 
+static int lfsck_get_dev_name(struct obd_ioctl_data *data, char *device,
+                             int types, bool multipe_devices)
+{
+       glob_t param = { 0 };
+       char *ptr;
+       int rc;
+       int i;
+
+       rc = cfs_get_param_paths(&param, "mdd/*-MDT*");
+       if (rc) {
+               if (multipe_devices || errno != ENOENT ||
+                   types & LFSCK_TYPE_NAMESPACE) {
+                       fprintf(stderr, "Fail to get device name: rc = %d\n."
+                               "You can specify the device explicitly "
+                               "via '-M' option.\n", rc);
+                       return rc;
+               }
+
+               rc = cfs_get_param_paths(&param, "obdfilter/*-OST*");
+               if (rc) {
+                       fprintf(stderr, "Fail to get device name: rc = %d\n."
+                               "You can specify the device explicitly "
+                               "via '-M' option.\n", rc);
+                       return rc;
+               }
+       }
+
+       if (param.gl_pathc == 1)
+               goto pack;
+
+       if (!multipe_devices) {
+               fprintf(stderr,
+                       "Detect multiple devices on current node. "
+                       "Please specify the device explicitly "
+                       "via '-M' option or '-A' option for all.\n");
+               rc = -EINVAL;
+               goto out;
+       }
+
+       ptr = strrchr(param.gl_pathv[0], '-');
+       LASSERT(ptr != NULL);
+
+       for (i = 1; i < param.gl_pathc; i++) {
+               char *ptr2 = strrchr(param.gl_pathv[i], '-');
+
+               LASSERT(ptr2 != NULL);
+
+               if ((ptr - param.gl_pathv[0]) != (ptr2 - param.gl_pathv[i]) ||
+                   strncmp(param.gl_pathv[0], param.gl_pathv[i],
+                           (ptr - param.gl_pathv[0])) != 0) {
+                       fprintf(stderr,
+                               "Detect multiple filesystems on current node. "
+                               "Please specify the device explicitly "
+                               "via '-M' option.\n");
+                       rc = -EINVAL;
+                       goto out;
+               }
+       }
+
+pack:
+       rc = lfsck_pack_dev(data, device, basename(param.gl_pathv[0]));
+
+out:
+       cfs_free_param_data(&param);
+
+       return rc;
+}
+
 int jt_lfsck_start(int argc, char **argv)
 {
        struct obd_ioctl_data data;
@@ -335,15 +404,10 @@ bad_type:
                start.ls_active = LFSCK_TYPES_DEF;
 
        if (data.ioc_inlbuf4 == NULL) {
-               if (lcfg_get_devname() != NULL) {
-                       rc = lfsck_pack_dev(&data, device, lcfg_get_devname());
-                       if (rc != 0)
-                               return rc;
-               } else {
-                       fprintf(stderr,
-                               "Must specify device to start LFSCK.\n");
-                       return -EINVAL;
-               }
+               rc = lfsck_get_dev_name(&data, device, start.ls_active,
+                                       start.ls_flags & LPF_ALL_TGT);
+               if (rc != 0)
+                       return rc;
        }
 
        data.ioc_inlbuf1 = (char *)&start;
@@ -413,15 +477,10 @@ int jt_lfsck_stop(int argc, char **argv)
        }
 
        if (data.ioc_inlbuf4 == NULL) {
-               if (lcfg_get_devname() != NULL) {
-                       rc = lfsck_pack_dev(&data, device, lcfg_get_devname());
-                       if (rc != 0)
-                               return rc;
-               } else {
-                       fprintf(stderr,
-                               "Must specify device to stop LFSCK.\n");
-                       return -EINVAL;
-               }
+               rc = lfsck_get_dev_name(&data, device, 0,
+                                       stop.ls_flags & LPF_ALL_TGT);
+               if (rc != 0)
+                       return rc;
        }
 
        data.ioc_inlbuf1 = (char *)&stop;
@@ -496,15 +555,9 @@ bad_type:
        }
 
        if (data.ioc_inlbuf4 == NULL) {
-               if (lcfg_get_devname() != NULL) {
-                       rc = lfsck_pack_dev(&data, device, lcfg_get_devname());
-                       if (rc != 0)
-                               return rc;
-               } else {
-                       fprintf(stderr,
-                               "Must specify device to query LFSCK.\n");
-                       return -EINVAL;
-               }
+               rc = lfsck_get_dev_name(&data, device, 0, true);
+               if (rc != 0)
+                       return rc;
        }
 
        data.ioc_inlbuf1 = (char *)&query;