#include <time.h>
#include <fnmatch.h>
#include <libgen.h> /* for dirname() */
+#include <linux/limits.h>
#ifdef HAVE_LINUX_UNISTD_H
#include <linux/unistd.h>
#else
#include <linux/lustre/lustre_ostid.h>
#include <linux/lustre/lustre_ioctl.h>
#include "lustreapi_internal.h"
+#include "lstddef.h"
static int llapi_msg_level = LLAPI_MSG_MAX;
const char *liblustreapi_cmd;
char *mdt_hash_name[] = { "none",
LMV_HASH_NAME_ALL_CHARS,
LMV_HASH_NAME_FNV_1A_64,
+ LMV_HASH_NAME_CRUSH,
};
struct lustre_foreign_type lu_foreign_types[] = {
void llapi_msg_set_level(int level)
{
- /* ensure level is in the good range */
- if (level < LLAPI_MSG_OFF)
- llapi_msg_level = LLAPI_MSG_OFF;
- else if (level > LLAPI_MSG_MAX)
- llapi_msg_level = LLAPI_MSG_MAX;
- else
- llapi_msg_level = level;
+ /* ensure level is in the good range */
+ if (level < LLAPI_MSG_OFF)
+ llapi_msg_level = LLAPI_MSG_OFF;
+ else if (level > LLAPI_MSG_MAX)
+ llapi_msg_level = LLAPI_MSG_MAX;
+ else
+ llapi_msg_level = level;
}
int llapi_msg_get_level(void)
static void error_callback_default(enum llapi_message_level level, int err,
const char *fmt, va_list ap)
{
+ bool has_nl = strchr(fmt, '\n') != NULL;
+
if (liblustreapi_cmd != NULL)
fprintf(stderr, "%s %s: ", program_invocation_short_name,
liblustreapi_cmd);
else
fprintf(stderr, "%s: ", program_invocation_short_name);
- vfprintf(stderr, fmt, ap);
- if (level & LLAPI_MSG_NO_ERRNO)
- fprintf(stderr, "\n");
- else
+
+
+ if (level & LLAPI_MSG_NO_ERRNO) {
+ vfprintf(stderr, fmt, ap);
+ if (!has_nl)
+ fprintf(stderr, "\n");
+ } else {
+ char *newfmt;
+
+ /*
+ * Remove trailing linefeed so error string can be appended.
+ * @fmt is a const string, so we can't modify it directly.
+ */
+ if (has_nl && (newfmt = strdup(fmt)))
+ *strrchr(newfmt, '\n') = '\0';
+ else
+ newfmt = (char *)fmt;
+
+ vfprintf(stderr, newfmt, ap);
+ if (newfmt != fmt)
+ free(newfmt);
fprintf(stderr, ": %s (%d)\n", strerror(err), err);
+ }
}
static void info_callback_default(enum llapi_message_level level, int err,
if (*pbuf != NULL && data->ioc_len > max_len) {
llapi_error(LLAPI_MSG_ERROR, -EINVAL,
- "pbuf = %p, ioc_len = %u, max_len = %d\n",
+ "pbuf = %p, ioc_len = %u, max_len = %d",
*pbuf, data->ioc_len, max_len);
return -EINVAL;
}
int rc = 0;
if (page_size == 0) {
- /* 64 KB is the largest common page size (on ia64/PPC/ARM),
+ /*
+ * 64 KB is the largest common page size (on ia64/PPC/ARM),
* but check the local page size just in case. The page_size
* will not change for the lifetime of this process at least.
*/
}
if (!llapi_stripe_size_is_aligned(stripe_size)) {
rc = -EINVAL;
- llapi_error(LLAPI_MSG_ERROR, rc, "error: bad stripe_size %llu, "
- "must be an even multiple of %d bytes",
- (unsigned long long)stripe_size, page_size);
+ llapi_error(LLAPI_MSG_ERROR, rc,
+ "error: bad stripe_size %llu, must be an even multiple of %d bytes",
+ (unsigned long long)stripe_size, page_size);
goto out;
}
if (!llapi_stripe_index_is_valid(stripe_offset)) {
static int get_mds_md_size(const char *path)
{
- char buf[PATH_MAX], inst[PATH_MAX];
int md_size = lov_user_md_size(LOV_MAX_STRIPE_COUNT, LOV_USER_MAGIC_V3);
- int rc;
- rc = llapi_getname(path, inst, sizeof(inst));
- if (rc != 0)
- return rc;
-
- /* Get the max ea size from llite parameters. */
- rc = get_lustre_param_value("llite", inst, FILTER_BY_EXACT,
- "max_easize", buf, sizeof(buf));
- if (rc != 0)
- return rc;
+ /*
+ * Rather than open the file and do the ioctl to get the
+ * instance name and close the file and search for the param
+ * file and open the param file and read the param file and
+ * parse the value and close the param file, let's just return
+ * a large enough value. It's 2020, RAM is cheap and this is
+ * much faster.
+ */
- rc = atoi(buf);
+ if (md_size < XATTR_SIZE_MAX)
+ md_size = XATTR_SIZE_MAX;
- return rc > 0 ? rc : md_size;
+ return md_size;
}
int llapi_get_agent_uuid(char *path, char *buf, size_t bufsize)
/* Make sure we have a good pool */
if (pool_name != NULL) {
- /* in case user gives the full pool name <fsname>.<poolname>,
- * strip the fsname */
+ /*
+ * in case user gives the full pool name <fsname>.<poolname>,
+ * strip the fsname
+ */
char *ptr = strchr(pool_name, '.');
+
if (ptr != NULL) {
*ptr = '\0';
if (strcmp(pool_name, fsname) != 0) {
}
if (!found) {
llapi_error(LLAPI_MSG_ERROR, -EINVAL,
- "%s: stripe offset '%d' is not in the "
- "target list",
+ "%s: stripe offset '%d' is not in the target list",
__func__, param->lsp_stripe_offset);
return -EINVAL;
}
lumv3->lmm_magic = LOV_USER_MAGIC_SPECIFIC;
if (pool_name == NULL) {
- /* LOV_USER_MAGIC_SPECIFIC uses v3 format plus specified
+ /*
+ * LOV_USER_MAGIC_SPECIFIC uses v3 format plus specified
* OST list, therefore if pool is not specified we have
- * to pack a null pool name for placeholder. */
+ * to pack a null pool name for placeholder.
+ */
memset(lumv3->lmm_pool_name, 0, LOV_MAXPOOLNAME);
}
}
if (ioctl(fd, LL_IOC_LOV_SETSTRIPE, lum) != 0) {
- char *errmsg = "stripe already set";
+ char errmsg[512] = "stripe already set";
rc = -errno;
if (errno != EEXIST && errno != EALREADY)
- errmsg = strerror(errno);
+ strncpy(errmsg, strerror(errno), sizeof(errmsg) - 1);
+ if (rc == -EREMOTEIO)
+ snprintf(errmsg, sizeof(errmsg),
+ "inactive OST among your specified %d OST(s)",
+ param->lsp_stripe_count);
llapi_err_noerrno(LLAPI_MSG_ERROR,
"setstripe error for '%s': %s", name, errmsg);
}
int llapi_file_open(const char *name, int flags, int mode,
- unsigned long long stripe_size, int stripe_offset,
- int stripe_count, int stripe_pattern)
+ unsigned long long stripe_size, int stripe_offset,
+ int stripe_count, int stripe_pattern)
{
- return llapi_file_open_pool(name, flags, mode, stripe_size,
- stripe_offset, stripe_count,
- stripe_pattern, NULL);
+ return llapi_file_open_pool(name, flags, mode, stripe_size,
+ stripe_offset, stripe_count,
+ stripe_pattern, NULL);
}
int llapi_file_create_foreign(const char *name, mode_t mode, __u32 type,
}
int llapi_file_create(const char *name, unsigned long long stripe_size,
- int stripe_offset, int stripe_count, int stripe_pattern)
+ int stripe_offset, int stripe_count, int stripe_pattern)
{
- int fd;
+ int fd;
- fd = llapi_file_open_pool(name, O_CREAT | O_WRONLY, 0644, stripe_size,
- stripe_offset, stripe_count, stripe_pattern,
- NULL);
- if (fd < 0)
- return fd;
+ fd = llapi_file_open_pool(name, O_CREAT | O_WRONLY, 0644, stripe_size,
+ stripe_offset, stripe_count, stripe_pattern,
+ NULL);
+ if (fd < 0)
+ return fd;
- close(fd);
- return 0;
+ close(fd);
+ return 0;
}
int llapi_file_create_pool(const char *name, unsigned long long stripe_size,
- int stripe_offset, int stripe_count,
- int stripe_pattern, char *pool_name)
+ int stripe_offset, int stripe_count,
+ int stripe_pattern, char *pool_name)
{
- int fd;
+ int fd;
- fd = llapi_file_open_pool(name, O_CREAT | O_WRONLY, 0644, stripe_size,
- stripe_offset, stripe_count, stripe_pattern,
- pool_name);
- if (fd < 0)
- return fd;
+ fd = llapi_file_open_pool(name, O_CREAT | O_WRONLY, 0644, stripe_size,
+ stripe_offset, stripe_count, stripe_pattern,
+ pool_name);
+ if (fd < 0)
+ return fd;
- close(fd);
- return 0;
+ close(fd);
+ return 0;
}
static int verify_dir_param(const char *name,
/* Make sure we have a good pool */
if (pool_name != NULL) {
- /* in case user gives the full pool name <fsname>.<poolname>,
- * strip the fsname */
+ /*
+ * in case user gives the full pool name <fsname>.<poolname>,
+ * strip the fsname
+ */
char *ptr = strchr(pool_name, '.');
if (ptr != NULL) {
}
if (!found) {
llapi_error(LLAPI_MSG_ERROR, -EINVAL,
- "%s: stripe offset '%d' is not in the "
- "target list",
+ "%s: stripe offset '%d' is not in the target list",
__func__, param->lsp_stripe_offset);
return -EINVAL;
}
rc = ioctl(fd, LL_IOC_LMV_SET_DEFAULT_STRIPE, &lmu);
if (rc < 0) {
char *errmsg = "stripe already set";
+
rc = -errno;
if (errno != EEXIST && errno != EALREADY)
errmsg = strerror(errno);
if (len > XATTR_SIZE_MAX - offsetof(struct lmv_foreign_md, lfm_value) ||
len <= 0) {
rc = -EINVAL;
- llapi_error(LLAPI_MSG_ERROR, rc, "invalid LOV EA length %zu "
- "(must be 0 < len < %zu)\n", len,
- XATTR_SIZE_MAX -
- offsetof(struct lmv_foreign_md, lfm_value));
+ llapi_error(LLAPI_MSG_ERROR, rc,
+ "invalid LOV EA length %zu (must be 0 < len < %zu)",
+ len, XATTR_SIZE_MAX -
+ offsetof(struct lmv_foreign_md, lfm_value));
return rc;
}
lfm_size = len + offsetof(struct lmv_foreign_md, lfm_value);
goto out;
}
- if (ioctl(fd, LL_IOC_REMOVE_ENTRY, filename)) {
- char *errmsg = strerror(errno);
- llapi_err_noerrno(LLAPI_MSG_ERROR,
- "error on ioctl %#jx for '%s' (%d): %s",
- (uintmax_t)LL_IOC_LMV_SETSTRIPE, filename,
- fd, errmsg);
- }
+ if (ioctl(fd, LL_IOC_REMOVE_ENTRY, filename))
+ llapi_error(LLAPI_MSG_ERROR, errno,
+ "error on ioctl %#lx for '%s' (%d)",
+ (long)LL_IOC_LMV_SETSTRIPE, filename, fd);
out:
free(dirpath);
free(namepath);
char buf[PATH_MAX], mntdir[PATH_MAX];
char *ptr, *ptr_end;
FILE *fp;
- int idx = 0, len = 0, mntlen, fd;
+ int idx = 0, mntlen = 0, fd;
int rc = -ENODEV;
int fsnamelen, mountlen;
- /* get the mount point */
+ /* get the mount point */
fp = setmntent(PROC_MOUNTS, "r");
if (fp == NULL) {
rc = -EIO;
"cannot retrieve filesystem mount point");
return rc;
}
- while (1) {
- if (getmntent_r(fp, &mnt, buf, sizeof(buf)) == NULL)
- break;
+ while (1) {
+ if (getmntent_r(fp, &mnt, buf, sizeof(buf)) == NULL)
+ break;
- if (!llapi_is_lustre_mnt(&mnt))
- continue;
+ if (!llapi_is_lustre_mnt(&mnt))
+ continue;
- if ((want & WANT_INDEX) && (idx++ != index))
- continue;
+ if ((want & WANT_INDEX) && (idx++ != index))
+ continue;
- mntlen = strlen(mnt.mnt_dir);
+ mntlen = strlen(mnt.mnt_dir);
ptr = strchr(mnt.mnt_fsname, '/');
while (ptr && *ptr == '/')
ptr++;
- /* thanks to the call to llapi_is_lustre_mnt() above,
+ /*
+ * thanks to the call to llapi_is_lustre_mnt() above,
* we are sure that mnt.mnt_fsname contains ":/",
- * so ptr should never be NULL */
+ * so ptr should never be NULL
+ */
if (ptr == NULL)
continue;
ptr_end = ptr;
/* Check the fsname for a match, if given */
mountlen = ptr_end - ptr;
- if (!(want & WANT_FSNAME) && fsname != NULL &&
+ if (!(want & WANT_FSNAME) && fsname != NULL &&
(fsnamelen = strlen(fsname)) > 0 &&
(fsnamelen != mountlen ||
(strncmp(ptr, fsname, mountlen) != 0)))
- continue;
+ continue;
- /* If the path isn't set return the first one we find */
+ /* If the path isn't set return the first one we find */
if (path == NULL || strlen(path) == 0) {
strncpy(mntdir, mnt.mnt_dir, sizeof(mntdir) - 1);
mntdir[sizeof(mntdir) - 1] = '\0';
rc = 0;
break;
/* Otherwise find the longest matching path */
- } else if ((strlen(path) >= mntlen) && (mntlen >= len) &&
+ } else if ((strlen(path) >= mntlen) &&
(strncmp(mnt.mnt_dir, path, mntlen) == 0)) {
+ /* check the path format */
+ if (strlen(path) > mntlen && path[mntlen] != '/')
+ continue;
strncpy(mntdir, mnt.mnt_dir, sizeof(mntdir) - 1);
mntdir[sizeof(mntdir) - 1] = '\0';
- len = mntlen;
if ((want & WANT_FSNAME) && fsname != NULL) {
strncpy(fsname, ptr, mountlen);
fsname[mountlen] = '\0';
}
rc = 0;
+ break;
}
}
endmntent(fp);
/* Found it */
if (rc == 0) {
if ((want & WANT_PATH) && path != NULL) {
- strncpy(path, mntdir, PATH_MAX);
- path[strlen(mntdir)] = '\0';
+ strncpy(path, mntdir, mntlen);
+ path[mntlen] = '\0';
}
if (want & WANT_FD) {
fd = open(mntdir, O_RDONLY | O_DIRECTORY | O_NONBLOCK);
if (fd < 0) {
rc = -errno;
llapi_error(LLAPI_MSG_ERROR, rc,
- "cannot open '%s': %s", mntdir,
- strerror(-rc));
+ "cannot open '%s'", mntdir);
} else {
*outfd = fd;
* See function lfs_osts in lfs.c for an example of the index use.
*/
int llapi_search_mounts(const char *pathname, int index, char *mntdir,
- char *fsname)
+ char *fsname)
{
- int want = WANT_PATH, idx = -1;
+ int want = WANT_PATH, idx = -1;
- if (!pathname || pathname[0] == '\0') {
- want |= WANT_INDEX;
- idx = index;
- } else
- strcpy(mntdir, pathname);
+ if (!pathname || pathname[0] == '\0') {
+ want |= WANT_INDEX;
+ idx = index;
+ } else {
+ strcpy(mntdir, pathname);
+ }
- if (fsname)
- want |= WANT_FSNAME;
- return get_root_path(want, fsname, NULL, mntdir, idx);
+ if (fsname)
+ want |= WANT_FSNAME;
+ return get_root_path(want, fsname, NULL, mntdir, idx);
}
/* Given a path, find the corresponding Lustre fsname */
int llapi_search_fsname(const char *pathname, char *fsname)
{
- char *path;
- int rc;
+ char *path;
+ int rc;
- path = realpath(pathname, NULL);
- if (path == NULL) {
+ path = realpath(pathname, NULL);
+ if (path == NULL) {
char tmp[PATH_MAX - 1];
char buf[PATH_MAX];
char *ptr;
tmp[0] = '\0';
buf[0] = '\0';
if (pathname[0] != '/') {
- /* Need an absolute path, but realpath() only works for
+ /*
+ * Need an absolute path, but realpath() only works for
* pathnames that actually exist. We go through the
* extra hurdle of dirname(getcwd() + pathname) in
- * case the relative pathname contains ".." in it. */
+ * case the relative pathname contains ".." in it.
+ */
char realpath[PATH_MAX - 1];
if (getcwd(realpath, sizeof(realpath) - 2) == NULL) {
int llapi_search_rootpath(char *pathname, const char *fsname)
{
- /* pathname can be used as an argument by get_root_path(),
- * clear it for safety */
- pathname[0] = 0;
- return get_root_path(WANT_PATH, (char *)fsname, NULL, pathname, -1);
-}
-
-int llapi_getname(const char *path, char *buf, size_t size)
-{
- struct obd_uuid uuid_buf;
- char *uuid = uuid_buf.uuid;
- char *cfg_instance;
- int rc, len, fsname_len;
-
- memset(&uuid_buf, 0, sizeof(uuid_buf));
- rc = llapi_file_get_lov_uuid(path, &uuid_buf);
- if (rc)
- return rc;
-
/*
- * We want to turn testfs-clilov-ffff88002738bc00 into
- * testfs-ffff88002738bc00 in a portable way that doesn't depend
- * on what is after "-clilov-" as it may change in the future.
- * Unfortunately, the "fsname" part may contain a dash, so we
- * can't just skip to the first dash, and the "instance" may be a
- * UUID in the future, so we can't necessarily go to the last dash.
+ * pathname can be used as an argument by get_root_path(),
+ * clear it for safety
*/
- cfg_instance = strstr(uuid, "-clilov-");
- if (!cfg_instance)
- return -EINVAL;
-
- fsname_len = cfg_instance - uuid;
- cfg_instance += strlen("-clilov-");
- len = snprintf(buf, size, "%.*s-%s", fsname_len, uuid, cfg_instance);
-
- if (len >= size)
- rc = -ENAMETOOLONG;
-
- return rc;
+ pathname[0] = 0;
+ return get_root_path(WANT_PATH, (char *)fsname, NULL, pathname, -1);
}
/**
* \retval -error failure
*/
int llapi_get_poolmembers(const char *poolname, char **members,
- int list_size, char *buffer, int buffer_size)
+ int list_size, char *buffer, int buffer_size)
{
char fsname[PATH_MAX];
char *pool, *tmp;
return rc;
}
- rc = 0;
- while (fgets(buf, sizeof(buf), fd) != NULL) {
- if (nb_entries >= list_size) {
- rc = -EOVERFLOW;
- break;
- }
+ rc = 0;
+ while (fgets(buf, sizeof(buf), fd) != NULL) {
+ if (nb_entries >= list_size) {
+ rc = -EOVERFLOW;
+ break;
+ }
buf[sizeof(buf) - 1] = '\0';
- /* remove '\n' */
- tmp = strchr(buf, '\n');
- if (tmp != NULL)
- *tmp='\0';
- if (used + strlen(buf) + 1 > buffer_size) {
- rc = -EOVERFLOW;
- break;
- }
-
- strcpy(buffer + used, buf);
- members[nb_entries] = buffer + used;
- used += strlen(buf) + 1;
- nb_entries++;
- rc = nb_entries;
- }
-
- fclose(fd);
- return rc;
+ /* remove '\n' */
+ tmp = strchr(buf, '\n');
+ if (tmp != NULL)
+ *tmp = '\0';
+ if (used + strlen(buf) + 1 > buffer_size) {
+ rc = -EOVERFLOW;
+ break;
+ }
+
+ strcpy(buffer + used, buf);
+ members[nb_entries] = buffer + used;
+ used += strlen(buf) + 1;
+ nb_entries++;
+ rc = nb_entries;
+ }
+
+ fclose(fd);
+ return rc;
}
/**
* \retval -error failure
*/
int llapi_get_poollist(const char *name, char **poollist, int list_size,
- char *buffer, int buffer_size)
+ char *buffer, int buffer_size)
{
glob_t pathname;
char *fsname;
goto free_dir;
}
- /* ignore . and .. */
+ /* ignore . and .. */
if (!strcmp(pool->d_name, ".") || !strcmp(pool->d_name, ".."))
- continue;
+ continue;
- /* check output bounds */
+ /* check output bounds */
if (nb_entries >= list_size) {
rc = -EOVERFLOW;
goto free_dir_no_msg;
}
- /* +2 for '.' and final '\0' */
+ /* +2 for '.' and final '\0' */
if (used + strlen(pool->d_name) + strlen(fsname) + 2
> buffer_size) {
rc = -EOVERFLOW;
}
sprintf(buffer + used, "%s.%s", fsname, pool->d_name);
- poollist[nb_entries] = buffer + used;
+ poollist[nb_entries] = buffer + used;
used += strlen(pool->d_name) + strlen(fsname) + 2;
- nb_entries++;
+ nb_entries++;
} while (1);
free_dir:
/* wrapper for lfs.c and obd.c */
int llapi_poollist(const char *name)
{
- /* list of pool names (assume that pool count is smaller
- than OST count) */
+ /*
+ * list of pool names (assume that pool count is smaller
+ * than OST count)
+ */
char **list, *buffer = NULL, *fsname = (char *)name;
char *poolname = NULL, *tmp = NULL, data[16];
enum param_filter type = FILTER_BY_PATH;
goto err;
obdcount = atoi(data);
- /* Allocate space for each fsname-OST0000_UUID, 1 per OST,
- * and also an array to store the pointers for all that
- * allocated space. */
+ /*
+ * Allocate space for each fsname-OST0000_UUID, 1 per OST,
+ * and also an array to store the pointers for all that
+ * allocated space.
+ */
retry_get_pools:
- bufsize = sizeof(struct obd_uuid) * obdcount;
- buffer = realloc(tmp, bufsize + sizeof(*list) * obdcount);
- if (buffer == NULL) {
- rc = -ENOMEM;
- goto err;
- }
- list = (char **) (buffer + bufsize);
-
- if (!poolname) {
- /* name is a path or fsname */
- nb = llapi_get_poollist(name, list, obdcount,
- buffer, bufsize);
- } else {
- /* name is a pool name (<fsname>.<poolname>) */
- nb = llapi_get_poolmembers(name, list, obdcount,
- buffer, bufsize);
- }
-
- if (nb == -EOVERFLOW) {
- obdcount *= 2;
- tmp = buffer;
- goto retry_get_pools;
- }
-
- for (i = 0; i < nb; i++)
- llapi_printf(LLAPI_MSG_NORMAL, "%s\n", list[i]);
- rc = (nb < 0 ? nb : 0);
+ bufsize = sizeof(struct obd_uuid) * obdcount;
+ buffer = realloc(tmp, bufsize + sizeof(*list) * obdcount);
+ if (buffer == NULL) {
+ rc = -ENOMEM;
+ goto err;
+ }
+ list = (char **) (buffer + bufsize);
+
+ if (!poolname) {
+ /* name is a path or fsname */
+ nb = llapi_get_poollist(name, list, obdcount,
+ buffer, bufsize);
+ } else {
+ /* name is a pool name (<fsname>.<poolname>) */
+ nb = llapi_get_poolmembers(name, list, obdcount,
+ buffer, bufsize);
+ }
+
+ if (nb == -EOVERFLOW) {
+ obdcount *= 2;
+ tmp = buffer;
+ goto retry_get_pools;
+ }
+
+ for (i = 0; i < nb; i++)
+ llapi_printf(LLAPI_MSG_NORMAL, "%s\n", list[i]);
+ rc = (nb < 0 ? nb : 0);
err:
- if (buffer)
- free(buffer);
+ if (buffer)
+ free(buffer);
if (fsname != NULL && type == FILTER_BY_FS_NAME)
free(fsname);
return rc;
struct dirent64 *de)
{
struct find_param *param = data;
- param->fp_depth--;
+ param->fp_depth--;
return 0;
}
stripe_count = lmv_foreign_to_md_stripes(size);
} else {
llapi_error(LLAPI_MSG_ERROR, -EINVAL,
- "error: invalid %d foreign size "
- "returned from ioctl",
+ "error: invalid %d foreign size returned from ioctl",
lfm->lfm_length);
return -EINVAL;
}
return -EINVAL;
if (dir_fd >= 0) {
- /* LL_IOC_MDC_GETINFO operates on the current directory inode
+ /*
+ * LL_IOC_MDC_GETINFO operates on the current directory inode
* and returns struct lov_user_mds_data, while
* LL_IOC_LOV_GETSTRIPE returns only struct lov_user_md.
*/
if (type == GET_LMD_INFO)
- cmd = use_old_ioctl ? LL_IOC_MDC_GETINFO_OLD :
- LL_IOC_MDC_GETINFO;
+ cmd = use_old_ioctl ? LL_IOC_MDC_GETINFO_V1 :
+ LL_IOC_MDC_GETINFO_V2;
else
cmd = LL_IOC_LOV_GETSTRIPE;
retry_getinfo:
ret = ioctl(dir_fd, cmd, lmdbuf);
- if (ret < 0 && errno == ENOTTY && cmd == LL_IOC_MDC_GETINFO) {
- cmd = LL_IOC_MDC_GETINFO_OLD;
+ if (ret < 0 && errno == ENOTTY &&
+ cmd == LL_IOC_MDC_GETINFO_V2) {
+ cmd = LL_IOC_MDC_GETINFO_V1;
use_old_ioctl = true;
goto retry_getinfo;
}
- if (cmd == LL_IOC_MDC_GETINFO_OLD && !ret)
+ if (cmd == LL_IOC_MDC_GETINFO_V1 && !ret)
ret = convert_lmdbuf_v1v2(lmdbuf, lmdlen);
} else if (parent_fd >= 0) {
const char *fname = strrchr(path, '/');
- /* IOC_MDC_GETFILEINFO takes as input the filename (relative to
+ /*
+ * IOC_MDC_GETFILEINFO takes as input the filename (relative to
* the parent directory) and returns struct lov_user_mds_data,
* while IOC_MDC_GETFILESTRIPE returns only struct lov_user_md.
*
errno = EINVAL;
else {
if (type == GET_LMD_INFO)
- cmd = use_old_ioctl ? IOC_MDC_GETFILEINFO_OLD :
- IOC_MDC_GETFILEINFO;
+ cmd = use_old_ioctl ? IOC_MDC_GETFILEINFO_V1 :
+ IOC_MDC_GETFILEINFO_V2;
else
cmd = IOC_MDC_GETFILESTRIPE;
retry_getfileinfo:
ret = ioctl(parent_fd, cmd, lmdbuf);
if (ret < 0 && errno == ENOTTY &&
- cmd == IOC_MDC_GETFILEINFO) {
- cmd = IOC_MDC_GETFILEINFO_OLD;
+ cmd == IOC_MDC_GETFILEINFO_V2) {
+ cmd = IOC_MDC_GETFILEINFO_V1;
use_old_ioctl = true;
goto retry_getfileinfo;
}
- if (cmd == IOC_MDC_GETFILEINFO_OLD && !ret)
+ if (cmd == IOC_MDC_GETFILEINFO_V1 && !ret)
ret = convert_lmdbuf_v1v2(lmdbuf, lmdlen);
}
}
if (errno == ENOTTY) {
lstat_t st;
- /* ioctl is not supported, it is not a lustre fs.
+ /*
+ * ioctl is not supported, it is not a lustre fs.
* Do the regular lstat(2) instead.
*/
ret = lstat_f(path, &st);
}
convert_lmd_statx(lmd, &st, true);
- /* It may be wrong to set use_old_ioctl with true as
+ /*
+ * It may be wrong to set use_old_ioctl with true as
* the file is not a lustre fs. So reset it with false
* directly here.
*/
ret = 0;
len = strlen(path);
- d = opendir(path);
- if (!d && errno != ENOTDIR) {
- ret = -errno;
- llapi_error(LLAPI_MSG_ERROR, ret, "%s: Failed to open '%s'",
- __func__, path);
- return ret;
- } else if (!d && !parent) {
- /* ENOTDIR. Open the parent dir. */
- p = opendir_parent(path);
+ d = opendir(path);
+ if (!d && errno != ENOTDIR) {
+ ret = -errno;
+ llapi_error(LLAPI_MSG_ERROR, ret, "%s: Failed to open '%s'",
+ __func__, path);
+ return ret;
+ } else if (!d && !parent) {
+ /* ENOTDIR. Open the parent dir. */
+ p = opendir_parent(path);
if (!p) {
ret = -errno;
goto out;
}
- }
+ }
if (sem_init && (ret = sem_init(path, parent ?: p, &d, data, de)))
goto err;
strcat(path, dent->d_name);
if (dent->d_type == DT_UNKNOWN) {
- lstatx_t *stx = ¶m->fp_lmd->lmd_stx;
+ struct lov_user_mds_data *lmd = param->fp_lmd;
- rc = get_lmd_info(path, d, NULL, param->fp_lmd,
+ rc = get_lmd_info(path, d, NULL, lmd,
param->fp_lum_size, GET_LMD_INFO);
if (rc == 0)
- dent->d_type = IFTODT(stx->stx_mode);
+ dent->d_type = IFTODT(lmd->lmd_stx.stx_mode);
else if (ret == 0)
ret = rc;
if (rc == -ENOENT)
continue;
}
- switch (dent->d_type) {
- case DT_UNKNOWN:
- llapi_err_noerrno(LLAPI_MSG_ERROR,
- "error: %s: '%s' is UNKNOWN type %d",
- __func__, dent->d_name, dent->d_type);
- break;
+ switch (dent->d_type) {
+ case DT_UNKNOWN:
+ llapi_err_noerrno(LLAPI_MSG_ERROR,
+ "error: %s: '%s' is UNKNOWN type %d",
+ __func__, dent->d_name, dent->d_type);
+ break;
case DT_DIR:
rc = llapi_semantic_traverse(path, size, d, sem_init,
sem_fini, data, dent);
}
if (sem_fini && rc == 0)
sem_fini(path, d, NULL, data, dent);
- }
- }
+ }
+ }
out:
- path[len] = 0;
+ path[len] = 0;
if (sem_fini)
sem_fini(path, parent, &d, data, de);
err:
- if (d)
- closedir(d);
- if (p)
- closedir(p);
+ if (d)
+ closedir(d);
+ if (p)
+ closedir(p);
return ret;
}
static int param_callback(char *path, semantic_func_t sem_init,
- semantic_func_t sem_fini, struct find_param *param)
+ semantic_func_t sem_fini, struct find_param *param)
{
- int ret, len = strlen(path);
- char *buf;
+ int ret, len = strlen(path);
+ char *buf;
- if (len > PATH_MAX) {
- ret = -EINVAL;
- llapi_error(LLAPI_MSG_ERROR, ret,
- "Path name '%s' is too long", path);
- return ret;
- }
+ if (len > PATH_MAX) {
+ ret = -EINVAL;
+ llapi_error(LLAPI_MSG_ERROR, ret,
+ "Path name '%s' is too long", path);
+ return ret;
+ }
- buf = (char *)malloc(PATH_MAX + 1);
- if (!buf)
- return -ENOMEM;
+ buf = (char *)malloc(PATH_MAX + 1);
+ if (!buf)
+ return -ENOMEM;
snprintf(buf, PATH_MAX + 1, "%s", path);
- ret = common_param_init(param, buf);
- if (ret)
- goto out;
+ ret = common_param_init(param, buf);
+ if (ret)
+ goto out;
param->fp_depth = 0;
- ret = llapi_semantic_traverse(buf, PATH_MAX + 1, NULL, sem_init,
- sem_fini, param, NULL);
+ ret = llapi_semantic_traverse(buf, PATH_MAX + 1, NULL, sem_init,
+ sem_fini, param, NULL);
out:
- find_param_fini(param);
- free(buf);
- return ret < 0 ? ret : 0;
+ find_param_fini(param);
+ free(buf);
+ return ret < 0 ? ret : 0;
}
int llapi_file_fget_lov_uuid(int fd, struct obd_uuid *lov_name)
int llapi_file_fget_lmv_uuid(int fd, struct obd_uuid *lov_name)
{
- int rc = ioctl(fd, OBD_IOC_GETMDNAME, lov_name);
- if (rc) {
- rc = -errno;
- llapi_error(LLAPI_MSG_ERROR, rc, "error: can't get lmv name.");
- }
- return rc;
+ int rc = ioctl(fd, OBD_IOC_GETMDNAME, lov_name);
+
+ if (rc) {
+ rc = -errno;
+ llapi_error(LLAPI_MSG_ERROR, rc, "error: can't get lmv name.");
+ }
+ return rc;
}
int llapi_file_get_lov_uuid(const char *path, struct obd_uuid *lov_uuid)
}
enum tgt_type {
- LOV_TYPE = 1,
- LMV_TYPE
+ LOV_TYPE = 1,
+ LMV_TYPE
};
/*
* the ost_count set to number of available obd uuids.
*/
static int llapi_get_target_uuids(int fd, struct obd_uuid *uuidp,
- int *ost_count, enum tgt_type type)
+ int *ost_count, enum tgt_type type)
{
char buf[PATH_MAX], format[32];
int rc = 0, index = 0;
while (fgets(buf, sizeof(buf), fp) != NULL) {
if (uuidp && (index < *ost_count)) {
if (sscanf(buf, format, &index, uuidp[index].uuid) < 2)
- break;
- }
- index++;
- }
+ break;
+ }
+ index++;
+ }
- fclose(fp);
+ fclose(fp);
- if (uuidp && (index > *ost_count))
- rc = -EOVERFLOW;
+ if (uuidp && (index > *ost_count))
+ rc = -EOVERFLOW;
*ost_count = index;
free_param:
int llapi_lov_get_uuids(int fd, struct obd_uuid *uuidp, int *ost_count)
{
- return llapi_get_target_uuids(fd, uuidp, ost_count, LOV_TYPE);
+ return llapi_get_target_uuids(fd, uuidp, ost_count, LOV_TYPE);
}
int llapi_get_obd_count(char *mnt, int *count, int is_mdt)
return rc;
}
-/* Check if user specified value matches a real uuid. Ignore _UUID,
+/*
+ * Check if user specified value matches a real uuid. Ignore _UUID,
* -osc-4ba41334, other trailing gunk in comparison.
* @param real_uuid ends in "_UUID"
* @param search_uuid may or may not end in "_UUID"
*/
int llapi_uuid_match(char *real_uuid, char *search_uuid)
{
- int cmplen = strlen(real_uuid);
- int searchlen = strlen(search_uuid);
+ int cmplen = strlen(real_uuid);
+ int searchlen = strlen(search_uuid);
- if (cmplen > 5 && strcmp(real_uuid + cmplen - 5, "_UUID") == 0)
- cmplen -= 5;
- if (searchlen > 5 && strcmp(search_uuid + searchlen - 5, "_UUID") == 0)
- searchlen -= 5;
+ if (cmplen > 5 && strcmp(real_uuid + cmplen - 5, "_UUID") == 0)
+ cmplen -= 5;
+ if (searchlen > 5 && strcmp(search_uuid + searchlen - 5, "_UUID") == 0)
+ searchlen -= 5;
- /* The UUIDs may legitimately be different lengths, if
- * the system was upgraded from an older version. */
- if (cmplen != searchlen)
- return 0;
+ /*
+ * The UUIDs may legitimately be different lengths, if
+ * the system was upgraded from an older version.
+ */
+ if (cmplen != searchlen)
+ return 0;
- return (strncmp(search_uuid, real_uuid, cmplen) == 0);
+ return (strncmp(search_uuid, real_uuid, cmplen) == 0);
}
-/* Here, param->fp_obd_uuid points to a single obduuid, the index of which is
- * returned in param->fp_obd_index */
+/*
+ * Here, param->fp_obd_uuid points to a single obduuid, the index of which is
+ * returned in param->fp_obd_index
+ */
static int setup_obd_uuid(int fd, char *dname, struct find_param *param)
{
struct obd_uuid obd_uuid;
}
param->fp_obds_printed = 1;
- fclose(fp);
+ fclose(fp);
if (param->fp_obd_uuid && (param->fp_obd_index == OBD_NOT_FOUND)) {
llapi_err_noerrno(LLAPI_MSG_ERROR,
return rc;
}
-/* In this case, param->fp_obd_uuid will be an array of obduuids and
+/*
+ * In this case, param->fp_obd_uuid will be an array of obduuids and
* obd index for all these obduuids will be returned in
- * param->fp_obd_indexes */
+ * param->fp_obd_indexes
+ */
static int setup_indexes(DIR *dir, char *path, struct obd_uuid *obduuids,
- int num_obds, int **obdindexes, int *obdindex,
- enum tgt_type type)
+ int num_obds, int **obdindexes, int *obdindex,
+ enum tgt_type type)
{
int ret, obdcount, obd_valid = 0, obdnum;
long i;
- struct obd_uuid *uuids = NULL;
- char buf[16];
- int *indexes;
+ struct obd_uuid *uuids = NULL;
+ char buf[16];
+ int *indexes;
if (type == LOV_TYPE)
ret = get_param_lov(path, "numobd", buf, sizeof(buf));
goto out_free;
}
- indexes = malloc(num_obds * sizeof(*obdindex));
- if (indexes == NULL) {
- ret = -ENOMEM;
- goto out_free;
- }
-
- for (obdnum = 0; obdnum < num_obds; obdnum++) {
- char *end = NULL;
-
- /* The user may have specified a simple index */
- i = strtol(obduuids[obdnum].uuid, &end, 0);
- if (end && *end == '\0' && i < obdcount) {
- indexes[obdnum] = i;
- obd_valid++;
- } else {
- for (i = 0; i < obdcount; i++) {
- if (llapi_uuid_match(uuids[i].uuid,
- obduuids[obdnum].uuid)) {
- indexes[obdnum] = i;
- obd_valid++;
- break;
- }
- }
- }
+ indexes = malloc(num_obds * sizeof(*obdindex));
+ if (indexes == NULL) {
+ ret = -ENOMEM;
+ goto out_free;
+ }
+
+ for (obdnum = 0; obdnum < num_obds; obdnum++) {
+ char *end = NULL;
+
+ /* The user may have specified a simple index */
+ i = strtol(obduuids[obdnum].uuid, &end, 0);
+ if (end && *end == '\0' && i < obdcount) {
+ indexes[obdnum] = i;
+ obd_valid++;
+ } else {
+ for (i = 0; i < obdcount; i++) {
+ if (llapi_uuid_match(uuids[i].uuid,
+ obduuids[obdnum].uuid)) {
+ indexes[obdnum] = i;
+ obd_valid++;
+ break;
+ }
+ }
+ }
if (i >= obdcount) {
indexes[obdnum] = OBD_NOT_FOUND;
llapi_err_noerrno(LLAPI_MSG_ERROR,
}
}
- if (obd_valid == 0)
- *obdindex = OBD_NOT_FOUND;
- else
- *obdindex = obd_valid;
+ if (obd_valid == 0)
+ *obdindex = OBD_NOT_FOUND;
+ else
+ *obdindex = obd_valid;
- *obdindexes = indexes;
+ *obdindexes = indexes;
out_free:
- if (uuids)
- free(uuids);
+ if (uuids)
+ free(uuids);
- return ret;
+ return ret;
}
static int setup_target_indexes(DIR *dir, char *path, struct find_param *param)
{
- int ret = 0;
+ int ret = 0;
if (param->fp_mdt_uuid) {
ret = setup_indexes(dir, path, param->fp_mdt_uuid,
* using pathname.
*/
static int sattr_get_defaults(const char *const fsname,
- unsigned int *scount,
- unsigned int *ssize,
- unsigned int *soffset)
+ unsigned int *scount,
+ unsigned int *ssize,
+ unsigned int *soffset)
{
char val[PATH_MAX];
int rc;
const char *const pathname, unsigned int *scount,
unsigned int *ssize, unsigned int *soffset)
{
- static struct {
- char fsname[PATH_MAX + 1];
- unsigned int stripecount;
- unsigned int stripesize;
- unsigned int stripeoffset;
- } cache = {
- .fsname = {'\0'}
- };
-
- int rc;
- char fsname_buf[PATH_MAX + 1];
- unsigned int tmp[3];
-
- if (fsname == NULL) {
- rc = llapi_search_fsname(pathname, fsname_buf);
- if (rc)
- return rc;
- } else {
+ static struct {
+ char fsname[PATH_MAX + 1];
+ unsigned int stripecount;
+ unsigned int stripesize;
+ unsigned int stripeoffset;
+ } cache = {
+ .fsname = {'\0'}
+ };
+
+ int rc;
+ char fsname_buf[PATH_MAX + 1];
+ unsigned int tmp[3];
+
+ if (fsname == NULL) {
+ rc = llapi_search_fsname(pathname, fsname_buf);
+ if (rc)
+ return rc;
+ } else {
snprintf(fsname_buf, sizeof(fsname_buf), "%s", fsname);
- }
+ }
if (strncmp(fsname_buf, cache.fsname, sizeof(fsname_buf) - 1) != 0) {
- /*
- * Ensure all 3 sattrs (count, size, and offset) are
- * successfully retrieved and stored in tmp before writing to
- * cache.
- */
+ /*
+ * Ensure all 3 sattrs (count, size, and offset) are
+ * successfully retrieved and stored in tmp before writing to
+ * cache.
+ */
rc = sattr_get_defaults(fsname_buf, &tmp[0], &tmp[1], &tmp[2]);
- if (rc != 0)
- return rc;
+ if (rc != 0)
+ return rc;
- cache.stripecount = tmp[0];
- cache.stripesize = tmp[1];
- cache.stripeoffset = tmp[2];
+ cache.stripecount = tmp[0];
+ cache.stripesize = tmp[1];
+ cache.stripeoffset = tmp[2];
snprintf(cache.fsname, sizeof(cache.fsname), "%s", fsname_buf);
- }
+ }
- if (scount)
- *scount = cache.stripecount;
- if (ssize)
- *ssize = cache.stripesize;
- if (soffset)
- *soffset = cache.stripeoffset;
+ if (scount)
+ *scount = cache.stripecount;
+ if (ssize)
+ *ssize = cache.stripesize;
+ if (soffset)
+ *soffset = cache.stripeoffset;
- return 0;
+ return 0;
}
static char *layout2name(__u32 layout_pattern)
if (verbose & ~VERBOSE_DFID)
llapi_printf(LLAPI_MSG_NORMAL, "%slmm_fid: ",
space);
- /* This needs a bit of hand-holding since old 1.x lmm_oi
+ /*
+ * This needs a bit of hand-holding since old 1.x lmm_oi
* have { oi.oi_id = mds_inum, oi.oi_seq = 0 } and 2.x lmm_oi
* have { oi.oi_id = mds_oid, oi.oi_seq = mds_seq } instead of
* a real FID. Ideally the 2.x code would have stored this
* oi_fid fields are in the right order. This is why there are
* separate lmm_oi_seq() and lmm_oi_id() routines for this.
*
- * For newer layout types hopefully this will be a real FID. */
+ * For newer layout types hopefully this will be a real FID.
+ */
seq = lmm_oi_seq(&lum->lmm_oi) == 0 ?
lmm_oi_id(&lum->lmm_oi) : lmm_oi_seq(&lum->lmm_oi);
oid = lmm_oi_seq(&lum->lmm_oi) == 0 ?
if (!is_raw && lum->lmm_stripe_count == 0 &&
lov_pattern(lum->lmm_pattern) != LOV_PATTERN_MDT) {
unsigned int scount;
+
rc = sattr_cache_get_defaults(NULL, path,
&scount, NULL,
NULL);
scount);
else
llapi_error(LLAPI_MSG_ERROR, rc,
- "Cannot determine default"
- " stripe count.");
+ "Cannot determine default stripe count.");
} else {
llapi_printf(LLAPI_MSG_NORMAL, "%d",
extension ? 0 :
space, prefix);
if (is_dir && !is_raw && lum->lmm_stripe_size == 0) {
unsigned int ssize;
+
rc = sattr_cache_get_defaults(NULL, path, NULL, &ssize,
NULL);
if (rc == 0)
llapi_printf(LLAPI_MSG_NORMAL, "%u", ssize);
else
llapi_error(LLAPI_MSG_ERROR, rc,
- "Cannot determine default"
- " stripe size.");
+ "Cannot determine default stripe size.");
} else {
/* Extension size is in KiB */
llapi_printf(LLAPI_MSG_NORMAL, "%llu",
space, i, idx, PFID(&fid));
} else {
char fmt[48];
+
sprintf(fmt, "%s%s%s\n",
"\t%6u\t%14llu\t%#13llx\t",
(fid_seq_is_rsvd(gr) ||
llapi_printf(LLAPI_MSG_NORMAL, ",bad_type");
if (flags & LMV_HASH_FLAG_LOST_LMV)
llapi_printf(LLAPI_MSG_NORMAL, ",lost_lmv");
- separator = "\n";
+ separator = "\n";
}
if (verbose & VERBOSE_OBJID && lum->lum_magic != LMV_USER_MAGIC) {
for (i = 0; i < lum->lum_stripe_count; i++) {
int idx = objects[i].lum_mds;
struct lu_fid *fid = &objects[i].lum_fid;
+
if ((obdindex == OBD_NOT_FOUND) || (obdindex == idx))
llapi_printf(LLAPI_MSG_NORMAL,
"%6u\t\t "DFID"\t\t%s\n",
idx, PFID(fid),
obdindex == idx ? " *" : "");
}
-
}
if ((verbose & VERBOSE_POOL) && pool_name != NULL &&
}
}
-/* Check if the value matches 1 of the given criteria (e.g. --atime +/-N).
+/*
+ * Check if the value matches 1 of the given criteria (e.g. --atime +/-N).
* @mds indicates if this is MDS timestamps and there are attributes on OSTs.
*
* The result is -1 if it does not match, 0 if not yet clear, 1 if matches.
* 9 | file < limit; sign < 0 | ? / -1 |
* --------------------------------------
* Note: 5th actually means that the value is within the interval
- * (limit - margin, limit]. */
+ * (limit - margin, limit].
+ */
static int find_value_cmp(unsigned long long file, unsigned long long limit,
int sign, int negopt, unsigned long long margin,
bool mds)
lmv_dump_foreign_lmm(param, path, flags);
break;
default:
- llapi_printf(LLAPI_MSG_NORMAL, "unknown lmm_magic: %#x "
- "(expecting one of %#x %#x %#x %#x)\n",
+ llapi_printf(LLAPI_MSG_NORMAL,
+ "unknown lmm_magic: %#x (expecting one of %#x %#x %#x %#x)\n",
*(__u32 *)¶m->fp_lmd->lmd_lmm,
LOV_USER_MAGIC_V1, LOV_USER_MAGIC_V3,
LMV_USER_MAGIC, LMV_MAGIC_V1);
int llapi_file_lookup(int dirfd, const char *name)
{
- struct obd_ioctl_data data = { 0 };
- char rawbuf[8192];
- char *buf = rawbuf;
- int rc;
+ struct obd_ioctl_data data = { 0 };
+ char rawbuf[8192];
+ char *buf = rawbuf;
+ int rc;
- if (dirfd < 0 || name == NULL)
- return -EINVAL;
+ if (dirfd < 0 || name == NULL)
+ return -EINVAL;
- data.ioc_version = OBD_IOCTL_VERSION;
- data.ioc_len = sizeof(data);
- data.ioc_inlbuf1 = (char *)name;
- data.ioc_inllen1 = strlen(name) + 1;
+ data.ioc_version = OBD_IOCTL_VERSION;
+ data.ioc_len = sizeof(data);
+ data.ioc_inlbuf1 = (char *)name;
+ data.ioc_inllen1 = strlen(name) + 1;
rc = llapi_ioctl_pack(&data, &buf, sizeof(rawbuf));
- if (rc) {
- llapi_error(LLAPI_MSG_ERROR, rc,
- "error: IOC_MDC_LOOKUP pack failed for '%s': rc %d",
- name, rc);
- return rc;
- }
+ if (rc) {
+ llapi_error(LLAPI_MSG_ERROR, rc,
+ "error: IOC_MDC_LOOKUP pack failed for '%s': rc %d",
+ name, rc);
+ return rc;
+ }
- rc = ioctl(dirfd, IOC_MDC_LOOKUP, buf);
- if (rc < 0)
- rc = -errno;
- return rc;
+ rc = ioctl(dirfd, IOC_MDC_LOOKUP, buf);
+ if (rc < 0)
+ rc = -errno;
+ return rc;
}
-/* Check if the file time matches all the given criteria (e.g. --atime +/-N).
+/*
+ * Check if the file time matches all the given criteria (e.g. --atime +/-N).
* Return -1 or 1 if file timestamp does not or does match the given criteria
* correspondingly. Return 0 if the MDS time is being checked and there are
* attributes on OSTs and it is not yet clear if the timespamp matches.
*
* If 0 is returned, we need to do another RPC to the OSTs to obtain the
- * updated timestamps. */
-static int find_time_check(lstatx_t *stx, struct find_param *param, int mds)
+ * updated timestamps.
+ */
+static int find_time_check(struct find_param *param, int mds)
{
+ struct lov_user_mds_data *lmd = param->fp_lmd;
int rc = 1;
int rc2;
/* Check if file is accepted. */
if (param->fp_atime) {
- rc2 = find_value_cmp(stx->stx_atime.tv_sec, param->fp_atime,
- param->fp_asign, param->fp_exclude_atime,
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_atime.tv_sec,
+ param->fp_atime, param->fp_asign,
+ param->fp_exclude_atime,
param->fp_time_margin, mds);
if (rc2 < 0)
return rc2;
}
if (param->fp_mtime) {
- rc2 = find_value_cmp(stx->stx_mtime.tv_sec, param->fp_mtime,
- param->fp_msign, param->fp_exclude_mtime,
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_mtime.tv_sec,
+ param->fp_mtime, param->fp_msign,
+ param->fp_exclude_mtime,
param->fp_time_margin, mds);
if (rc2 < 0)
return rc2;
- /* If the previous check matches, but this one is not yet clear,
- * we should return 0 to do an RPC on OSTs. */
+ /*
+ * If the previous check matches, but this one is not yet clear,
+ * we should return 0 to do an RPC on OSTs.
+ */
if (rc == 1)
rc = rc2;
}
if (param->fp_ctime) {
- rc2 = find_value_cmp(stx->stx_ctime.tv_sec, param->fp_ctime,
- param->fp_csign, param->fp_exclude_ctime,
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_ctime.tv_sec,
+ param->fp_ctime, param->fp_csign,
+ param->fp_exclude_ctime,
param->fp_time_margin, mds);
if (rc2 < 0)
return rc2;
- /* If the previous check matches, but this one is not yet clear,
- * we should return 0 to do an RPC on OSTs. */
+ /*
+ * If the previous check matches, but this one is not yet clear,
+ * we should return 0 to do an RPC on OSTs.
+ */
if (rc == 1)
rc = rc2;
}
return rc;
}
+static int find_newerxy_check(struct find_param *param, int mds, bool from_mdt)
+{
+ struct lov_user_mds_data *lmd = param->fp_lmd;
+ int i;
+ int rc = 1;
+ int rc2;
+
+ for (i = 0; i < 2; i++) {
+ /* Check if file is accepted. */
+ if (param->fp_newery[NEWERXY_ATIME][i]) {
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_atime.tv_sec,
+ param->fp_newery[NEWERXY_ATIME][i],
+ -1, i, 0, mds);
+ if (rc2 < 0)
+ return rc2;
+ rc = rc2;
+ }
+
+ if (param->fp_newery[NEWERXY_MTIME][i]) {
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_mtime.tv_sec,
+ param->fp_newery[NEWERXY_MTIME][i],
+ -1, i, 0, mds);
+ if (rc2 < 0)
+ return rc2;
+
+ /*
+ * If the previous check matches, but this one is not
+ * yet clear, we should return 0 to do an RPC on OSTs.
+ */
+ if (rc == 1)
+ rc = rc2;
+ }
+
+ if (param->fp_newery[NEWERXY_CTIME][i]) {
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_ctime.tv_sec,
+ param->fp_newery[NEWERXY_CTIME][i],
+ -1, i, 0, mds);
+ if (rc2 < 0)
+ return rc2;
+
+ /*
+ * If the previous check matches, but this one is not
+ * yet clear, we should return 0 to do an RPC on OSTs.
+ */
+ if (rc == 1)
+ rc = rc2;
+ }
+
+ /*
+ * File birth time (btime) can get from MDT directly.
+ * if @from_mdt is true, it means the input file attributs are
+ * obtained directly from MDT.
+ * Thus, if @from_mdt is false, we should skip the following
+ * btime check.
+ */
+ if (!from_mdt)
+ continue;
+
+ if (param->fp_newery[NEWERXY_BTIME][i]) {
+ if (!(lmd->lmd_stx.stx_mask & STATX_BTIME))
+ return -EOPNOTSUPP;
+
+ rc2 = find_value_cmp(lmd->lmd_stx.stx_btime.tv_sec,
+ param->fp_newery[NEWERXY_BTIME][i],
+ -1, i, 0, 0);
+ if (rc2 < 0)
+ return rc2;
+ }
+ }
+
+ return rc;
+}
+
/**
* Check whether the stripes matches the indexes user provided
* 1 : matched
{
struct lov_user_ost_data_v1 *objects;
struct lov_comp_md_v1 *comp_v1 = NULL;
- struct lov_user_md_v1 *v1 = ¶m->fp_lmd->lmd_lmm;
- lstatx_t *stx = ¶m->fp_lmd->lmd_stx;
+ struct lov_user_mds_data *lmd = param->fp_lmd;
+ struct lov_user_md_v1 *v1 = &lmd->lmd_lmm;
int i, j, k, count = 1;
if (param->fp_obd_uuid && param->fp_obd_index == OBD_NOT_FOUND)
return 0;
- if (!S_ISREG(stx->stx_mode))
+ if (!S_ISREG(lmd->lmd_stx.stx_mode))
return 0;
/* exclude foreign */
if (v1->lmm_magic == LOV_USER_MAGIC_FOREIGN)
return param->fp_exclude_obd;
- /* Only those files should be accepted, which have a
- * stripe on the specified OST. */
+ /*
+ * Only those files should be accepted, which have a
+ * stripe on the specified OST.
+ */
if (v1->lmm_magic == LOV_USER_MAGIC_COMP_V1) {
comp_v1 = (struct lov_comp_md_v1 *)v1;
count = comp_v1->lcm_entry_count;
* not active, just print the object affected by this
* failed target
**/
-static int print_failed_tgt(struct find_param *param, char *path, int type)
+static void print_failed_tgt(struct find_param *param, char *path, int type)
{
- struct obd_statfs stat_buf;
- struct obd_uuid uuid_buf;
- int ret;
-
- if (type != LL_STATFS_LOV && type != LL_STATFS_LMV)
- return -EINVAL;
+ struct obd_statfs stat_buf;
+ struct obd_uuid uuid_buf;
+ int tgt_nr, i, *indexes;
+ int ret = 0;
- memset(&stat_buf, 0, sizeof(struct obd_statfs));
- memset(&uuid_buf, 0, sizeof(struct obd_uuid));
- ret = llapi_obd_statfs(path, type,
- param->fp_obd_index, &stat_buf,
- &uuid_buf);
- if (ret) {
- llapi_printf(LLAPI_MSG_NORMAL,
- "obd_uuid: %s failed %s ",
- param->fp_obd_uuid->uuid,
- strerror(errno));
+ if (type != LL_STATFS_LOV && type != LL_STATFS_LMV) {
+ llapi_error(LLAPI_MSG_NORMAL, ret, "%s: wrong statfs type(%d)",
+ __func__, type);
+ return;
}
- return ret;
+ tgt_nr = (type == LL_STATFS_LOV) ? param->fp_obd_index :
+ param->fp_mdt_index;
+ indexes = (type == LL_STATFS_LOV) ? param->fp_obd_indexes :
+ param->fp_mdt_indexes;
+
+ for (i = 0; i < tgt_nr; i++) {
+ memset(&stat_buf, 0, sizeof(struct obd_statfs));
+ memset(&uuid_buf, 0, sizeof(struct obd_uuid));
+
+ ret = llapi_obd_statfs(path, type, indexes[i], &stat_buf,
+ &uuid_buf);
+ if (ret)
+ llapi_error(LLAPI_MSG_NORMAL, ret,
+ "%s: obd_uuid: %s failed",
+ __func__, param->fp_obd_uuid->uuid);
+ }
}
static int find_check_stripe_size(struct find_param *param)
return -1;
}
-/* if no type specified, check/exclude all foreign
+/*
+ * if no type specified, check/exclude all foreign
* if type specified, check all foreign&type and exclude !foreign + foreign&type
*/
static int find_check_foreign(struct find_param *param)
if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN)
return param->fp_exclude_foreign ? 1 : -1;
return -1;
- } else {
- if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN ||
- lfm->lfm_type == param->fp_foreign_type)
- return param->fp_exclude_foreign ? -1 : 1;
- return param->fp_exclude_foreign ? 1 : -1;
}
+
+ if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN ||
+ lfm->lfm_type == param->fp_foreign_type)
+ return param->fp_exclude_foreign ? -1 : 1;
+ return param->fp_exclude_foreign ? 1 : -1;
}
if (S_ISDIR(param->fp_lmd->lmd_stx.stx_mode)) {
if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN)
return param->fp_exclude_foreign ? 1 : -1;
return -1;
- } else {
- if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN ||
- lfm->lfm_type == param->fp_foreign_type)
- return param->fp_exclude_foreign ? -1 : 1;
- return param->fp_exclude_foreign ? 1 : -1;
}
+
+ if (param->fp_foreign_type == LU_FOREIGN_TYPE_UNKNOWN ||
+ lfm->lfm_type == param->fp_foreign_type)
+ return param->fp_exclude_foreign ? -1 : 1;
+ return param->fp_exclude_foreign ? 1 : -1;
}
return -1;
}
static int find_check_pool(struct find_param *param)
{
struct lov_comp_md_v1 *comp_v1 = NULL;
- struct lov_user_md_v1 *v1 = ¶m->fp_lmd->lmd_lmm;
- struct lov_user_md_v3 *v3 = (void *)v1;
+ struct lov_user_md_v3 *v3 = (void *)¶m->fp_lmd->lmd_lmm;
int i, count = 1;
bool found = false;
- if (v1->lmm_magic == LOV_USER_MAGIC_COMP_V1) {
- comp_v1 = (struct lov_comp_md_v1 *)v1;
+ if (v3->lmm_magic == LOV_USER_MAGIC_COMP_V1) {
+ comp_v1 = (struct lov_comp_md_v1 *)v3;
count = comp_v1->lcm_entry_count;
/* empty requested pool is taken as no pool search */
- if (count == 0 && param->fp_poolname[0] == '\0')
+ if (count == 0 && param->fp_poolname[0] == '\0') {
found = true;
+ goto found;
+ }
}
for (i = 0; i < count; i++) {
- if (comp_v1 != NULL)
- v1 = lov_comp_entry(comp_v1, i);
+ if (comp_v1 != NULL) {
+ if (!(comp_v1->lcm_entries[i].lcme_flags &
+ LCME_FL_INIT))
+ continue;
- if (v1->lmm_magic == LOV_USER_MAGIC_FOREIGN)
+ v3 = (void *)lov_comp_entry(comp_v1, i);
+ }
+
+ if (v3->lmm_magic == LOV_USER_MAGIC_FOREIGN)
continue;
- if (((v1->lmm_magic == LOV_USER_MAGIC_V1) &&
+ if (((v3->lmm_magic == LOV_USER_MAGIC_V1) &&
(param->fp_poolname[0] == '\0')) ||
- ((v1->lmm_magic == LOV_USER_MAGIC_V3) &&
+ ((v3->lmm_magic == LOV_USER_MAGIC_V3) &&
(strncmp(v3->lmm_pool_name,
param->fp_poolname, LOV_MAXPOOLNAME) == 0)) ||
- ((v1->lmm_magic == LOV_USER_MAGIC_V3) &&
+ ((v3->lmm_magic == LOV_USER_MAGIC_V3) &&
(strcmp(param->fp_poolname, "*") == 0))) {
found = true;
break;
}
}
+found:
if ((found && !param->fp_exclude_pool) ||
(!found && param->fp_exclude_pool))
return 1;
static int find_check_comp_options(struct find_param *param)
{
- lstatx_t *stx = ¶m->fp_lmd->lmd_stx;
struct lov_comp_md_v1 *comp_v1, *forged_v1 = NULL;
- struct lov_user_md_v1 *v1 = ¶m->fp_lmd->lmd_lmm;
+ struct lov_user_mds_data *lmd = param->fp_lmd;
+ struct lov_user_md_v1 *v1 = &lmd->lmd_lmm;
struct lov_comp_md_entry_v1 *entry;
int i, ret = 0;
comp_v1 = forged_v1;
comp_v1->lcm_entry_count = 1;
entry = &comp_v1->lcm_entries[0];
- entry->lcme_flags = S_ISDIR(stx->stx_mode) ? 0 : LCME_FL_INIT;
+ entry->lcme_flags = S_ISDIR(lmd->lmd_stx.stx_mode) ?
+ 0 : LCME_FL_INIT;
entry->lcme_extent.e_start = 0;
entry->lcme_extent.e_end = LUSTRE_EOF;
}
struct fsxattr fsx;
int rc;
- rc = ioctl(fd, LL_IOC_FSGETXATTR, &fsx);
+ rc = ioctl(fd, FS_IOC_FSGETXATTR, &fsx);
if (rc)
return -errno;
void *data, struct dirent64 *de)
{
struct find_param *param = (struct find_param *)data;
+ struct lov_user_mds_data *lmd = param->fp_lmd;
DIR *dir = dirp == NULL ? NULL : *dirp;
int decision = 1; /* 1 is accepted; -1 is rejected. */
- lstatx_t *stx = ¶m->fp_lmd->lmd_stx;
int lustre_fs = 1;
int checked_type = 0;
int ret = 0;
/* If a regular expression is presented, make the initial decision */
if (param->fp_pattern != NULL) {
char *fname = strrchr(path, '/');
+
fname = (fname == NULL ? path : fname + 1);
ret = fnmatch(param->fp_pattern, fname, 0);
if ((ret == FNM_NOMATCH && !param->fp_exclude_pattern) ||
ret = 0;
- /* Request MDS for the stat info if some of these parameters need
- * to be compared. */
+ /*
+ * Request MDS for the stat info if some of these parameters need
+ * to be compared.
+ */
if (param->fp_obd_uuid || param->fp_mdt_uuid ||
param->fp_check_uid || param->fp_check_gid ||
+ param->fp_newerxy || param->fp_btime ||
param->fp_atime || param->fp_mtime || param->fp_ctime ||
param->fp_check_size || param->fp_check_blocks ||
find_check_lmm_info(param) ||
decision = 0;
if (param->fp_type != 0 && checked_type == 0)
- decision = 0;
+ decision = 0;
if (decision == 0) {
if (dir && (param->fp_check_mdt_count ||
param->fp_get_lmv = 1;
ret = cb_get_dirstripe(path, dir, param);
if (ret != 0) {
- /* XXX this works to decide for foreign
+ /*
+ * XXX this works to decide for foreign
* criterion only
*/
if (errno == ENODATA &&
find_check_lmm_info(param)) {
struct lov_user_md *lmm = ¶m->fp_lmd->lmd_lmm;
- /* We need to "fake" the "use the default" values
- * since the lmm struct is zeroed out at this point. */
+ /*
+ * We need to "fake" the "use the default" values
+ * since the lmm struct is zeroed out at this point.
+ */
lmm->lmm_magic = LOV_USER_MAGIC_V1;
lmm->lmm_pattern = LOV_PATTERN_DEFAULT;
if (!param->fp_raw)
if (dir != NULL) {
ret = llapi_file_fget_mdtidx(dirfd(dir),
¶m->fp_file_mdt_index);
- } else if (S_ISREG(stx->stx_mode)) {
- /* FIXME: we could get the MDT index from the
+ } else if (S_ISREG(lmd->lmd_stx.stx_mode)) {
+ /*
+ * FIXME: we could get the MDT index from the
* file's FID in lmd->lmd_lmm.lmm_oi without
* opening the file, once we are sure that
* LFSCK2 (2.6) has fixed up pre-2.0 LOV EAs.
* That would still be an ioctl() to map the
- * FID to the MDT, but not an open RPC. */
+ * FID to the MDT, but not an open RPC.
+ */
fd = open(path, O_RDONLY);
if (fd > 0) {
ret = llapi_file_fget_mdtidx(fd,
ret = -errno;
}
} else {
- /* For a special file, we assume it resides on
- * the same MDT as the parent directory. */
+ /*
+ * For a special file, we assume it resides on
+ * the same MDT as the parent directory.
+ */
ret = llapi_file_fget_mdtidx(dirfd(parent),
¶m->fp_file_mdt_index);
}
}
if (param->fp_type && !checked_type) {
- if ((stx->stx_mode & S_IFMT) == param->fp_type) {
+ if ((lmd->lmd_stx.stx_mode & S_IFMT) == param->fp_type) {
if (param->fp_exclude_type)
goto decided;
} else {
}
}
- /* Prepare odb. */
+ /* Prepare odb. */
if (param->fp_obd_uuid || param->fp_mdt_uuid) {
if (lustre_fs && param->fp_got_uuids &&
- param->fp_dev != makedev(stx->stx_dev_major,
- stx->stx_dev_minor)) {
+ param->fp_dev != makedev(lmd->lmd_stx.stx_dev_major,
+ lmd->lmd_stx.stx_dev_minor)) {
/* A lustre/lustre mount point is crossed. */
param->fp_got_uuids = 0;
param->fp_obds_printed = 0;
if (ret)
goto out;
- param->fp_dev = makedev(stx->stx_dev_major,
- stx->stx_dev_minor);
+ param->fp_dev = makedev(lmd->lmd_stx.stx_dev_major,
+ lmd->lmd_stx.stx_dev_minor);
} else if (!lustre_fs && param->fp_got_uuids) {
/* A lustre/non-lustre mount point is crossed. */
param->fp_got_uuids = 0;
param->fp_mdt_index = OBD_NOT_FOUND;
param->fp_obd_index = OBD_NOT_FOUND;
- }
- }
+ }
+ }
if (param->fp_check_foreign) {
decision = find_check_foreign(param);
(param->fp_mdt_uuid && param->fp_mdt_index == OBD_NOT_FOUND))
goto decided;
- /* If an OST or MDT UUID is given, and some OST matches,
- * check it here. */
+ /*
+ * If an OST or MDT UUID is given, and some OST matches,
+ * check it here.
+ */
if (param->fp_obd_index != OBD_NOT_FOUND ||
param->fp_mdt_index != OBD_NOT_FOUND) {
if (param->fp_obd_uuid) {
if (check_obd_match(param)) {
- /* If no mdtuuid is given, we are done.
+ /*
+ * If no mdtuuid is given, we are done.
* Otherwise, fall through to the mdtuuid
- * check below. */
+ * check below.
+ */
if (!param->fp_mdt_uuid)
goto obd_matches;
} else {
obd_matches:
if (param->fp_check_uid) {
- if (stx->stx_uid == param->fp_uid) {
+ if (lmd->lmd_stx.stx_uid == param->fp_uid) {
if (param->fp_exclude_uid)
goto decided;
} else {
}
if (param->fp_check_gid) {
- if (stx->stx_gid == param->fp_gid) {
+ if (lmd->lmd_stx.stx_gid == param->fp_gid) {
if (param->fp_exclude_gid)
goto decided;
} else {
/* Check the time on mds. */
decision = 1;
if (param->fp_atime || param->fp_mtime || param->fp_ctime) {
- int for_mds;
+ int for_mds;
+
+ for_mds = lustre_fs ?
+ (S_ISREG(lmd->lmd_stx.stx_mode) && stripe_count) : 0;
+ decision = find_time_check(param, for_mds);
+ if (decision == -1)
+ goto decided;
+ }
+
+ if (param->fp_btime) {
+ if (!(lmd->lmd_stx.stx_mask & STATX_BTIME)) {
+ ret = -EOPNOTSUPP;
+ goto out;
+ }
+
+ decision = find_value_cmp(lmd->lmd_stx.stx_btime.tv_sec,
+ param->fp_btime, param->fp_bsign,
+ param->fp_exclude_btime,
+ param->fp_time_margin, 0);
+ if (decision == -1)
+ goto decided;
+ }
+
+ if (param->fp_newerxy) {
+ int for_mds;
for_mds = lustre_fs ?
- (S_ISREG(stx->stx_mode) && stripe_count) : 0;
- decision = find_time_check(stx, param, for_mds);
+ (S_ISREG(lmd->lmd_stx.stx_mode) && stripe_count) : 0;
+ decision = find_newerxy_check(param, for_mds, true);
if (decision == -1)
goto decided;
+ if (decision < 0) {
+ ret = decision;
+ goto out;
+ }
}
flags = param->fp_lmd->lmd_flags;
if (param->fp_check_size &&
- ((S_ISREG(stx->stx_mode) && stripe_count) ||
- S_ISDIR(stx->stx_mode)) &&
+ ((S_ISREG(lmd->lmd_stx.stx_mode) && stripe_count) ||
+ S_ISDIR(lmd->lmd_stx.stx_mode)) &&
!(flags & OBD_MD_FLSIZE ||
(param->fp_lazy && flags & OBD_MD_FLLAZYSIZE)))
decision = 0;
if (param->fp_check_blocks &&
- ((S_ISREG(stx->stx_mode) && stripe_count) ||
- S_ISDIR(stx->stx_mode)) &&
+ ((S_ISREG(lmd->lmd_stx.stx_mode) && stripe_count) ||
+ S_ISDIR(lmd->lmd_stx.stx_mode)) &&
!(flags & OBD_MD_FLBLOCKS ||
(param->fp_lazy && flags & OBD_MD_FLLAZYBLOCKS)))
decision = 0;
- /* If file still fits the request, ask ost for updated info.
+ /*
+ * If file still fits the request, ask ost for updated info.
* The regular stat is almost of the same speed as some new
* 'glimpse-size-ioctl'.
*/
if (!decision) {
lstat_t st;
- /* For regular files with the stripe the decision may have not
- * been taken yet if *time or size is to be checked. */
+ /*
+ * For regular files with the stripe the decision may have not
+ * been taken yet if *time or size is to be checked.
+ */
if (param->fp_obd_index != OBD_NOT_FOUND)
- print_failed_tgt(param, path, LL_STATFS_LOV);
+ print_failed_tgt(param, path, LL_STATFS_LOV);
if (param->fp_mdt_index != OBD_NOT_FOUND)
- print_failed_tgt(param, path, LL_STATFS_LMV);
+ print_failed_tgt(param, path, LL_STATFS_LMV);
if (dir != NULL)
ret = fstat_f(dirfd(dir), &st);
convert_lmd_statx(param->fp_lmd, &st, true);
/* Check the time on osc. */
- decision = find_time_check(stx, param, 0);
+ decision = find_time_check(param, 0);
if (decision == -1)
goto decided;
+
+ if (param->fp_newerxy) {
+ decision = find_newerxy_check(param, 0, false);
+ if (decision == -1)
+ goto decided;
+ if (decision < 0) {
+ ret = decision;
+ goto out;
+ }
+ }
}
if (param->fp_check_size) {
- decision = find_value_cmp(stx->stx_size, param->fp_size,
+ decision = find_value_cmp(lmd->lmd_stx.stx_size,
+ param->fp_size,
param->fp_size_sign,
param->fp_exclude_size,
param->fp_size_units, 0);
}
if (param->fp_check_blocks) { /* convert st_blocks to bytes */
- decision = find_value_cmp(stx->stx_blocks * 512,
+ decision = find_value_cmp(lmd->lmd_stx.stx_blocks * 512,
param->fp_blocks,
param->fp_blocks_sign,
param->fp_exclude_blocks,
ret = llapi_ioctl_pack(&data, &rawbuf, sizeof(raw));
if (ret != 0) {
llapi_error(LLAPI_MSG_ERROR, ret,
- "llapi_obd_statfs: error packing ioctl data");
+ "%s: error packing ioctl data", __func__);
goto out;
}
ret = ioctl(fd, LL_IOC_MIGRATE, rawbuf);
if (ret != 0) {
if (errno == EBUSY && !retry) {
- /* because migrate may not be able to lock all involved
+ /*
+ * because migrate may not be able to lock all involved
* objects in order, for some of them it try lock, while
* there may be conflicting COS locks and cause migrate
* fail with EBUSY, hope a sync() could cause
- * transaction commit and release these COS locks. */
+ * transaction commit and release these COS locks.
+ */
sync();
retry = true;
goto migrate;
} else if (errno == EALREADY) {
if (param->fp_verbose & VERBOSE_DETAIL)
llapi_printf(LLAPI_MSG_NORMAL,
- "%s was migrated to MDT%d already\n",
+ "%s migrated to MDT%d already\n",
path, lmu->lum_stripe_offset);
ret = 0;
} else {
ret = -errno;
- llapi_error(LLAPI_MSG_ERROR, ret,
- "%s migrate failed: %s (%d)\n",
- path, strerror(-ret), ret);
+ llapi_error(LLAPI_MSG_ERROR, ret, "%s migrate failed",
+ path);
goto out;
}
} else if (param->fp_verbose & VERBOSE_DETAIL) {
out:
if (dirp != NULL) {
- /* If the directory is being migration, we need
+ /*
+ * If the directory is being migration, we need
* close the directory after migration,
* so the old directory cache will be cleanup
* on the client side, and re-open to get the
- * new directory handle */
+ * new directory handle
+ */
*dirp = opendir(path);
if (*dirp == NULL) {
ret = -errno;
if (!printed) {
llapi_error(LLAPI_MSG_ERROR, -ESTALE,
- "llapi_mv() is deprecated, use llapi_migrate_mdt()\n");
+ "%s() is deprecated, use llapi_migrate_mdt() instead",
+ __func__);
printed = true;
}
#endif
int llapi_find(char *path, struct find_param *param)
{
- return param_callback(path, cb_find_init, cb_common_fini, param);
+ return param_callback(path, cb_find_init, cb_common_fini, param);
}
/*
*/
int llapi_file_fget_mdtidx(int fd, int *mdtidx)
{
- if (ioctl(fd, LL_IOC_GET_MDTIDX, mdtidx) < 0)
- return -errno;
- return 0;
+ if (ioctl(fd, LL_IOC_GET_MDTIDX, mdtidx) < 0)
+ return -errno;
+ return 0;
}
static int cb_get_mdt_index(char *path, DIR *parent, DIR **dirp, void *data,
static int cb_getstripe(char *path, DIR *parent, DIR **dirp, void *data,
struct dirent64 *de)
{
- struct find_param *param = (struct find_param *)data;
+ struct find_param *param = (struct find_param *)data;
DIR *d = dirp == NULL ? NULL : *dirp;
- int ret = 0;
+ int ret = 0;
if (parent == NULL && d == NULL)
return -EINVAL;
else
return 0;
- if (ret) {
- if (errno == ENODATA && d != NULL) {
- /* We need to "fake" the "use the default" values
+ if (ret) {
+ if (errno == ENODATA && d != NULL) {
+ /*
+ * We need to "fake" the "use the default" values
* since the lmm struct is zeroed out at this point.
* The magic needs to be set in order to satisfy
* a check later on in the code path.
* The object_seq needs to be set for the "(Default)"
- * prefix to be displayed. */
+ * prefix to be displayed.
+ */
if (param->fp_get_default_lmv) {
struct lmv_user_md *lum = param->fp_lmv_md;
lmm->lmm_stripe_offset = -1;
goto dump;
}
- } else if (errno == ENODATA && parent != NULL) {
+ } else if (errno == ENODATA && parent != NULL) {
if (!param->fp_obd_uuid && !param->fp_mdt_uuid)
- llapi_printf(LLAPI_MSG_NORMAL,
- "%s has no stripe info\n", path);
- goto out;
- } else if (errno == ENOENT) {
- llapi_error(LLAPI_MSG_WARN, -ENOENT,
- "warning: %s: %s does not exist",
- __func__, path);
- goto out;
- } else if (errno == ENOTTY) {
- ret = -errno;
- llapi_error(LLAPI_MSG_ERROR, ret,
- "%s: '%s' not on a Lustre fs?",
- __func__, path);
- } else {
- ret = -errno;
+ llapi_printf(LLAPI_MSG_NORMAL,
+ "%s has no stripe info\n", path);
+ goto out;
+ } else if (errno == ENOENT) {
+ llapi_error(LLAPI_MSG_WARN, -ENOENT,
+ "warning: %s: %s does not exist",
+ __func__, path);
+ goto out;
+ } else if (errno == ENOTTY) {
+ ret = -errno;
+ llapi_error(LLAPI_MSG_ERROR, ret,
+ "%s: '%s' not on a Lustre fs?",
+ __func__, path);
+ } else {
+ ret = -errno;
err_out:
llapi_error(LLAPI_MSG_ERROR, ret,
"error: %s: %s failed for %s",
"IOC_MDC_GETFILESTRIPE", path);
}
- return ret;
- }
+ return ret;
+ }
dump:
if (!(param->fp_verbose & VERBOSE_MDTINDEX))
int llapi_getstripe(char *path, struct find_param *param)
{
return param_callback(path, (param->fp_verbose & VERBOSE_MDTINDEX) ?
- cb_get_mdt_index : cb_getstripe,
- cb_common_fini, param);
+ cb_get_mdt_index : cb_getstripe,
+ cb_common_fini, param);
}
int llapi_obd_fstatfs(int fd, __u32 type, __u32 index,
struct obd_statfs *stat_buf, struct obd_uuid *uuid_buf)
{
char raw[MAX_IOC_BUFLEN] = {'\0'};
- char *rawbuf = raw;
- struct obd_ioctl_data data = { 0 };
- int rc = 0;
-
- data.ioc_inlbuf1 = (char *)&type;
- data.ioc_inllen1 = sizeof(__u32);
- data.ioc_inlbuf2 = (char *)&index;
- data.ioc_inllen2 = sizeof(__u32);
- data.ioc_pbuf1 = (char *)stat_buf;
- data.ioc_plen1 = sizeof(struct obd_statfs);
- data.ioc_pbuf2 = (char *)uuid_buf;
- data.ioc_plen2 = sizeof(struct obd_uuid);
+ char *rawbuf = raw;
+ struct obd_ioctl_data data = { 0 };
+ int rc = 0;
+
+ data.ioc_inlbuf1 = (char *)&type;
+ data.ioc_inllen1 = sizeof(__u32);
+ data.ioc_inlbuf2 = (char *)&index;
+ data.ioc_inllen2 = sizeof(__u32);
+ data.ioc_pbuf1 = (char *)stat_buf;
+ data.ioc_plen1 = sizeof(struct obd_statfs);
+ data.ioc_pbuf2 = (char *)uuid_buf;
+ data.ioc_plen2 = sizeof(struct obd_uuid);
rc = llapi_ioctl_pack(&data, &rawbuf, sizeof(raw));
- if (rc != 0) {
- llapi_error(LLAPI_MSG_ERROR, rc,
- "llapi_obd_statfs: error packing ioctl data");
- return rc;
- }
+ if (rc != 0) {
+ llapi_error(LLAPI_MSG_ERROR, rc,
+ "%s: error packing ioctl data", __func__);
+ return rc;
+ }
rc = ioctl(fd, IOC_OBD_STATFS, (void *)rawbuf);
rc = -errno;
llapi_error(LLAPI_MSG_ERROR, rc, "error: %s: opening '%s'",
__func__, path);
- /* If we can't even open a file on the filesystem (e.g. with
- * -ESHUTDOWN), force caller to exit or it will loop forever. */
+ /*
+ * If we can't even open a file on the filesystem (e.g. with
+ * -ESHUTDOWN), force caller to exit or it will loop forever.
+ */
return -ENODEV;
}
}
int llapi_target_iterate(int type_num, char **obd_type,
- void *args, llapi_cb_t cb)
+ void *args, llapi_cb_t cb)
{
int i, rc = 0;
glob_t param;
}
static void do_target_check(char *obd_type_name, char *obd_name,
- char *obd_uuid, void *args)
+ char *obd_uuid, void *args)
{
- int rc;
+ int rc;
- rc = llapi_ping(obd_type_name, obd_name);
- if (rc == ENOTCONN) {
- llapi_printf(LLAPI_MSG_NORMAL, "%s inactive.\n", obd_name);
- } else if (rc) {
- llapi_error(LLAPI_MSG_ERROR, rc, "error: check '%s'", obd_name);
- } else {
- llapi_printf(LLAPI_MSG_NORMAL, "%s active.\n", obd_name);
- }
+ rc = llapi_ping(obd_type_name, obd_name);
+ if (rc == ENOTCONN)
+ llapi_printf(LLAPI_MSG_NORMAL, "%s inactive.\n", obd_name);
+ else if (rc)
+ llapi_error(LLAPI_MSG_ERROR, rc, "error: check '%s'", obd_name);
+ else
+ llapi_printf(LLAPI_MSG_NORMAL, "%s active.\n", obd_name);
}
int llapi_target_check(int type_num, char **obd_type, char *dir)
{
- return llapi_target_iterate(type_num, obd_type, NULL, do_target_check);
+ return llapi_target_iterate(type_num, obd_type, NULL, do_target_check);
}
#undef MAX_STRING_SIZE
/* Is this a lustre client fs? */
int llapi_is_lustre_mnt(struct mntent *mnt)
{
- return (llapi_is_lustre_mnttype(mnt->mnt_type) &&
- strstr(mnt->mnt_fsname, ":/") != NULL);
+ return (llapi_is_lustre_mnttype(mnt->mnt_type) &&
+ strstr(mnt->mnt_fsname, ":/") != NULL);
}
int llapi_quotactl(char *mnt, struct if_quotactl *qctl)
rc = ioctl(root, OBD_IOC_QUOTACTL, qctl);
if (rc < 0)
rc = -errno;
+ if (rc == -ENOENT && LUSTRE_Q_CMD_IS_POOL(qctl->qc_cmd))
+ llapi_error(LLAPI_MSG_ERROR | LLAPI_MSG_NO_ERRNO, rc,
+ "Cannot find pool '%s'", qctl->qc_poolname);
close(root);
return rc;