Whamcloud - gitweb
LU-14506 hsm: correct default stripe offset in import
[fs/lustre-release.git] / lustre / utils / lhsmtool_posix.c
index 2ad9f3f..707cbab 100644 (file)
@@ -59,6 +59,7 @@
 #include <libcfs/util/string.h>
 #include <linux/lustre/lustre_fid.h>
 #include <lustre/lustreapi.h>
+#include "pid_file.h"
 
 /* Progress reporting period */
 #define REPORT_INTERVAL_DEFAULT 30
@@ -87,8 +88,9 @@ struct options {
        int                      o_shadow_tree;
        int                      o_verbose;
        int                      o_copy_xattrs;
-       int                      o_archive_cnt;
-       int                      o_archive_id[LL_HSM_MAX_ARCHIVE + 1];
+       int                      o_archive_id_used;
+       int                      o_archive_id_cnt;
+       int                     *o_archive_id;
        int                      o_report_int;
        unsigned long long       o_bandwidth;
        size_t                   o_chunk_size;
@@ -99,6 +101,7 @@ struct options {
        char                    *o_hsm_root;
        char                    *o_src; /* for import, or rebind */
        char                    *o_dst; /* for import, or rebind */
+       char                    *o_pid_file;
 };
 
 /* everything else is zeroed */
@@ -123,6 +126,7 @@ static int err_minor;
 
 static char cmd_name[PATH_MAX];
 static char fs_name[MAX_OBD_NAME + 1];
+static int pid_file_fd = -1;
 
 static struct hsm_copytool_private *ctdata;
 
@@ -197,6 +201,7 @@ static void usage(const char *name, int rc)
        "   -c, --chunk-size <sz>     I/O size used during data copy\n"
        "                             (unit can be used, default is MB)\n"
        "   -f, --event-fifo <path>   Write events stream to fifo\n"
+       "   -P, --pid-file=PATH       Lock and write PID to PATH\n"
        "   -p, --hsm-root <path>     Target HSM mount point\n"
        "   -q, --quiet               Produce less verbose output\n"
        "   -u, --update-interval <s> Interval between progress reports sent\n"
@@ -240,6 +245,7 @@ static int ct_parseopts(int argc, char * const *argv)
          .flag = &opt.o_copy_xattrs },
        { .val = 0,     .name = "no_xattr",     .has_arg = no_argument,
          .flag = &opt.o_copy_xattrs },
+       { .val = 'P',   .name = "pid-file",     .has_arg = required_argument },
        { .val = 'p',   .name = "hsm-root",     .has_arg = required_argument },
        { .val = 'p',   .name = "hsm_root",     .has_arg = required_argument },
        { .val = 'q',   .name = "quiet",        .has_arg = no_argument },
@@ -250,12 +256,22 @@ static int ct_parseopts(int argc, char * const *argv)
                                                .has_arg = required_argument },
        { .val = 'v',   .name = "verbose",      .has_arg = no_argument },
        { .name = NULL } };
-       int                      c, rc;
-       unsigned long long       value;
-       unsigned long long       unit;
+
+       unsigned long long value;
+       unsigned long long unit;
+       bool all_id = false;
+       int c, rc;
+       int i;
 
        optind = 0;
-       while ((c = getopt_long(argc, argv, "A:b:c:f:hiMp:qru:v",
+
+       opt.o_archive_id_cnt = LL_HSM_ORIGIN_MAX_ARCHIVE;
+       opt.o_archive_id = malloc(opt.o_archive_id_cnt *
+                                 sizeof(*opt.o_archive_id));
+       if (opt.o_archive_id == NULL)
+               return -ENOMEM;
+repeat:
+       while ((c = getopt_long(argc, argv, "A:b:c:f:hiMp:P:qru:v",
                                long_opts, NULL)) != -1) {
                switch (c) {
                case 'A': {
@@ -268,16 +284,40 @@ static int ct_parseopts(int argc, char * const *argv)
                                         optarg);
                                return rc;
                        }
+                       /* if archiveID is zero, any archiveID is accepted */
+                       if (all_id == true)
+                               goto repeat;
+
+                       if (val == 0) {
+                               free(opt.o_archive_id);
+                               opt.o_archive_id = NULL;
+                               opt.o_archive_id_cnt = 0;
+                               opt.o_archive_id_used = 0;
+                               all_id = true;
+                               CT_WARN("archive-id = 0 is found, any backend will be served\n");
+                               goto repeat;
+                       }
 
-                       if (opt.o_archive_cnt > LL_HSM_MAX_ARCHIVE ||
-                           val > LL_HSM_MAX_ARCHIVE) {
-                               rc = -EINVAL;
-                               CT_ERROR(rc, "archive number must be less"
-                                        " than %zu", LL_HSM_MAX_ARCHIVE + 1);
-                               return rc;
+                       /* skip the duplicated id */
+                       for (i = 0; i < opt.o_archive_id_used; i++) {
+                               if (opt.o_archive_id[i] == val)
+                                       goto repeat;
+                       }
+                       /* extend the space */
+                       if (opt.o_archive_id_used >= opt.o_archive_id_cnt) {
+                               int *tmp;
+
+                               opt.o_archive_id_cnt *= 2;
+                               tmp = realloc(opt.o_archive_id,
+                                             sizeof(*opt.o_archive_id) *
+                                             opt.o_archive_id_cnt);
+                               if (tmp == NULL)
+                                       return -ENOMEM;
+
+                               opt.o_archive_id = tmp;
                        }
-                       opt.o_archive_id[opt.o_archive_cnt] = val;
-                       opt.o_archive_cnt++;
+
+                       opt.o_archive_id[opt.o_archive_id_used++] = val;
                        break;
                }
                case 'b': /* -b and -c have both a number with unit as arg */
@@ -305,6 +345,9 @@ static int ct_parseopts(int argc, char * const *argv)
                case 'M':
                        opt.o_action = CA_MAXSEQ;
                        break;
+               case 'P':
+                       opt.o_pid_file = optarg;
+                       break;
                case 'p':
                        opt.o_hsm_root = optarg;
                        break;
@@ -434,7 +477,7 @@ static int ct_mkdir_p(const char *path)
 
 static int ct_save_stripe(int src_fd, const char *src, const char *dst)
 {
-       char                     lov_file[PATH_MAX];
+       char                     lov_file[PATH_MAX + 8];
        char                     lov_buf[XATTR_SIZE_MAX];
        struct lov_user_md      *lum;
        int                      rc;
@@ -494,7 +537,7 @@ err_cleanup:
 
 static int ct_load_stripe(const char *src, void *lovea, size_t *lovea_size)
 {
-       char     lov_file[PATH_MAX];
+       char     lov_file[PATH_MAX + 4];
        int      rc;
        int      fd;
 
@@ -664,7 +707,8 @@ static int ct_copy_data(struct hsm_copyaction_private *hcp, const char *src,
                                        CT_TRACE("bandwith control: %lluB/s "
                                                 "excess=%llu sleep for "
                                                 "%lld.%09lds",
-                                                opt.o_bandwidth, excess,
+                                                (unsigned long long)opt.o_bandwidth,
+                                                (unsigned long long)excess,
                                                 (long long)delay.tv_sec,
                                                 delay.tv_nsec);
                                        last_bw_print = now;
@@ -807,22 +851,22 @@ static int ct_copy_xattr(const char *src, const char *dst, int src_fd,
 static int ct_path_lustre(char *buf, int sz, const char *mnt,
                          const struct lu_fid *fid)
 {
-       return snprintf(buf, sz, "%s/%s/fid/"DFID_NOBRACE, mnt,
-                       dot_lustre_name, PFID(fid));
+       return scnprintf(buf, sz, "%s/%s/fid/"DFID_NOBRACE, mnt,
+                        dot_lustre_name, PFID(fid));
 }
 
 static int ct_path_archive(char *buf, int sz, const char *archive_dir,
                           const struct lu_fid *fid)
 {
-       return snprintf(buf, sz, "%s/%04x/%04x/%04x/%04x/%04x/%04x/"
-                       DFID_NOBRACE, archive_dir,
-                       (fid)->f_oid       & 0xFFFF,
-                       (fid)->f_oid >> 16 & 0xFFFF,
-                       (unsigned int)((fid)->f_seq       & 0xFFFF),
-                       (unsigned int)((fid)->f_seq >> 16 & 0xFFFF),
-                       (unsigned int)((fid)->f_seq >> 32 & 0xFFFF),
-                       (unsigned int)((fid)->f_seq >> 48 & 0xFFFF),
-                       PFID(fid));
+       return scnprintf(buf, sz, "%s/%04x/%04x/%04x/%04x/%04x/%04x/"
+                        DFID_NOBRACE, archive_dir,
+                        (fid)->f_oid       & 0xFFFF,
+                        (fid)->f_oid >> 16 & 0xFFFF,
+                        (unsigned int)((fid)->f_seq       & 0xFFFF),
+                        (unsigned int)((fid)->f_seq >> 16 & 0xFFFF),
+                        (unsigned int)((fid)->f_seq >> 32 & 0xFFFF),
+                        (unsigned int)((fid)->f_seq >> 48 & 0xFFFF),
+                        PFID(fid));
 }
 
 static bool ct_is_retryable(int err)
@@ -1007,8 +1051,8 @@ static int ct_archive(const struct hsm_action_item *hai, const long hal_flags)
        }
 
        if (rename_needed == true) {
-               char     tmp_src[PATH_MAX];
-               char     tmp_dst[PATH_MAX];
+               char     tmp_src[PATH_MAX + 8];
+               char     tmp_dst[PATH_MAX + 8];
 
                /* atomically replace old archived file */
                ct_path_archive(src, sizeof(src), opt.o_hsm_root,
@@ -1042,17 +1086,19 @@ static int ct_archive(const struct hsm_action_item *hai, const long hal_flags)
                int              depth = 0;
                ssize_t          sz;
 
-               sprintf(buf, DFID, PFID(&hai->hai_fid));
                sprintf(src, "%s/shadow/", opt.o_hsm_root);
 
                ptr = opt.o_hsm_root;
                while (*ptr)
                        (*ptr++ == '/') ? depth-- : 0;
 
-               rc = llapi_fid2path(opt.o_mnt, buf, src + strlen(src),
-                                   sizeof(src) - strlen(src), &recno, &linkno);
+               rc = llapi_fid2path_at(opt.o_mnt_fd, &hai->hai_fid,
+                                      src + strlen(src),
+                                      sizeof(src) - strlen(src),
+                                      &recno, &linkno);
                if (rc < 0) {
-                       CT_ERROR(rc, "cannot get FID of '%s'", buf);
+                       CT_ERROR(rc, "cannot get FID of "DFID,
+                                PFID(&hai->hai_fid));
                        rcf = rcf ? rcf : rc;
                        goto fini_minor;
                }
@@ -1286,7 +1332,12 @@ static int ct_remove(const struct hsm_action_item *hai, const long hal_flags)
                rc = -errno;
                CT_ERROR(rc, "cannot unlink '%s'", attr);
                err_minor++;
-               goto fini;
+
+               /* ignore the error when lov file does not exist. */
+               if (rc == -ENOENT)
+                       rc = 0;
+               else
+                       goto fini;
        }
 
 fini:
@@ -1301,19 +1352,19 @@ static int ct_process_item(struct hsm_action_item *hai, const long hal_flags)
 
        if (opt.o_verbose >= LLAPI_MSG_INFO || opt.o_dry_run) {
                /* Print the original path */
-               char            fid[128];
                char            path[PATH_MAX];
                long long       recno = -1;
                int             linkno = 0;
 
-               sprintf(fid, DFID, PFID(&hai->hai_fid));
-               CT_TRACE("'%s' action %s reclen %d, cookie=%#jx",
-                        fid, hsm_copytool_action2name(hai->hai_action),
+               CT_TRACE(DFID" action %s reclen %d, cookie=%#jx",
+                        PFID(&hai->hai_fid),
+                        hsm_copytool_action2name(hai->hai_action),
                         hai->hai_len, (uintmax_t)hai->hai_cookie);
-               rc = llapi_fid2path(opt.o_mnt, fid, path,
-                                   sizeof(path), &recno, &linkno);
+               rc = llapi_fid2path_at(opt.o_mnt_fd, &hai->hai_fid, path,
+                                      sizeof(path), &recno, &linkno);
                if (rc < 0)
-                       CT_ERROR(rc, "cannot get path of FID %s", fid);
+                       CT_ERROR(rc, "cannot get path of "DFID,
+                                PFID(&hai->hai_fid));
                else
                        CT_TRACE("processing file '%s'", path);
        }
@@ -1426,8 +1477,14 @@ static int ct_import_one(const char *src, const char *dst)
                return 0;
 
        rc = llapi_hsm_import(dst,
-                             opt.o_archive_cnt ? opt.o_archive_id[0] : 0,
-                             &st, 0, 0, 0, 0, NULL, &fid);
+                             opt.o_archive_id_used ? opt.o_archive_id[0] : 0,
+                             &st,
+                             0 /* default stripe_size */,
+                             -1 /* default stripe offset */,
+                             0 /* default stripe count */,
+                             0 /* stripe pattern (will be RAID0+RELEASED) */,
+                             NULL /* pool_name */,
+                             &fid);
        if (rc < 0) {
                CT_ERROR(rc, "cannot import '%s' from '%s'", dst, src);
                return rc;
@@ -1500,10 +1557,9 @@ static int ct_import_recurse(const char *relpath)
        if (relpath == NULL)
                return -EINVAL;
 
-       /* Is relpath a FID? In which case SFID should expand to three
-        * elements. */
-       rc = sscanf(relpath, SFID, RFID(&import_fid));
-       if (rc == 3)
+       /* Is relpath a FID? */
+       rc = llapi_fid_parse(relpath, &import_fid, NULL);
+       if (!rc)
                return ct_import_fid(&import_fid);
 
        srcpath = path_concat(opt.o_hsm_root, relpath);
@@ -1650,8 +1706,9 @@ static int ct_rebind_list(const char *list)
 
        /* each line consists of 2 FID */
        while ((r = getline(&line, &line_size, filp)) != -1) {
-               struct lu_fid   old_fid;
-               struct lu_fid   new_fid;
+               struct lu_fid old_fid;
+               struct lu_fid new_fid;
+               char *next_fid;
 
                /* Ignore empty and commented out ('#...') lines. */
                if (should_ignore_line(line))
@@ -1659,12 +1716,17 @@ static int ct_rebind_list(const char *list)
 
                nl++;
 
-               rc = sscanf(line, SFID" "SFID, RFID(&old_fid), RFID(&new_fid));
-               if (rc != 6 || !fid_is_file(&old_fid) ||
-                   !fid_is_file(&new_fid)) {
-                       CT_ERROR(EINVAL,
-                                "'%s' FID expected near '%s', line %u",
-                                list, line, nl);
+               rc = llapi_fid_parse(line, &old_fid, &next_fid);
+               if (rc)
+                       goto error;
+               rc = llapi_fid_parse(next_fid, &new_fid, NULL);
+               if (rc)
+                       goto error;
+               if (!fid_is_file(&old_fid) || !fid_is_file(&new_fid))
+                       rc = -EINVAL;
+               if (rc) {
+error:                 CT_ERROR(rc, "%s:%u: two FIDs expected in '%s'",
+                                list, nl, line);
                        err_major++;
                        continue;
                }
@@ -1688,23 +1750,25 @@ static int ct_rebind_list(const char *list)
 
 static int ct_rebind(void)
 {
-       int     rc;
+       int rc;
 
        if (opt.o_dst) {
                struct lu_fid old_fid;
                struct lu_fid new_fid;
 
-               if (sscanf(opt.o_src, SFID, RFID(&old_fid)) != 3 ||
-                   !fid_is_file(&old_fid)) {
+               rc = llapi_fid_parse(opt.o_src, &old_fid, NULL);
+               if (!rc && !fid_is_file(&old_fid))
                        rc = -EINVAL;
-                       CT_ERROR(rc, "'%s' invalid FID format", opt.o_src);
+               if (rc) {
+                       CT_ERROR(rc, "invalid source FID '%s'", opt.o_src);
                        return rc;
                }
 
-               if (sscanf(opt.o_dst, SFID, RFID(&new_fid)) != 3 ||
-                   !fid_is_file(&new_fid)) {
+               rc = llapi_fid_parse(opt.o_dst, &new_fid, NULL);
+               if (!rc && !fid_is_file(&new_fid))
                        rc = -EINVAL;
-                       CT_ERROR(rc, "'%s' invalid FID format", opt.o_dst);
+               if (rc) {
+                       CT_ERROR(rc, "invalid destination FID '%s'", opt.o_dst);
                        return rc;
                }
 
@@ -1824,6 +1888,15 @@ static int ct_run(void)
                }
        }
 
+       if (opt.o_pid_file != NULL) {
+               pid_file_fd = create_pid_file(opt.o_pid_file);
+               if (pid_file_fd < 0) {
+                       rc = -errno;
+                       CT_ERROR(rc, "cannot create PID file");
+                       return rc;
+               }
+       }
+
        setbuf(stdout, NULL);
 
        if (opt.o_event_fifo != NULL) {
@@ -1836,7 +1909,7 @@ static int ct_run(void)
        }
 
        rc = llapi_hsm_copytool_register(&ctdata, opt.o_mnt,
-                                        opt.o_archive_cnt,
+                                        opt.o_archive_id_used,
                                         opt.o_archive_id, 0);
        if (rc < 0) {
                CT_ERROR(rc, "cannot start copytool interface");
@@ -1969,6 +2042,12 @@ static int ct_cleanup(void)
                }
        }
 
+       if (opt.o_archive_id_cnt > 0) {
+               free(opt.o_archive_id);
+               opt.o_archive_id = NULL;
+               opt.o_archive_id_cnt = 0;
+       }
+
        return 0;
 }