LU-17504 build: fix gcc-13 [-Werror=stringop-overread] error

[fs/lustre-release.git] / lustre / tests / sanity-selinux.sh

diff --git a/lustre/tests/sanity-selinux.sh b/lustre/tests/sanity-selinux.sh
index 0403a3c..362086b 100755 (executable)
--- a/lustre/tests/sanity-selinux.sh
+++ b/lustre/tests/sanity-selinux.sh
@@ -15,23 +15,20 @@
 set -e
 
 ONLY=${ONLY:-"$*"}
-# bug number for skipped test:
-ALWAYS_EXCEPT=${ALWAYS_EXCEPT:-"$SANITY_SELINUX_EXCEPT"}
-# UPDATE THE COMMENT ABOVE WITH BUG NUMBERS WHEN CHANGING ALWAYS_EXCEPT!
-
-SRCDIR=$(dirname $0)
-SAVE_PWD=$PWD
 
 LUSTRE=${LUSTRE:-$(dirname $0)/..}
 . $LUSTRE/tests/test-framework.sh
-init_test_env $@
-. ${CONFIG:=$LUSTRE/tests/cfg/$NAME.sh}
+init_test_env "$@"
 init_logging
 
-require_dsh_mds || exit 0
+ALWAYS_EXCEPT="$SANITY_SELINUX_EXCEPT"
 
 [ "$SLOW" = "no" ] && EXCEPT_SLOW="xxx"
 
+build_test_filter
+
+require_dsh_mds || exit 0
+
 RUNAS_CMD=${RUNAS_CMD:-runas}
 # $RUNAS_ID may get set incorrectly somewhere else
 [ $UID -eq 0 -a $RUNAS_ID -eq 0 ] &&
@@ -69,18 +66,14 @@ rm -rf $DIR/[df][0-9]*
 
 check_runas_id $RUNAS_ID $RUNAS_ID $RUNAS
 
-build_test_filter
-
 umask 077
 
 check_selinux_xattr() {
        local mds=$1
        local mds_path=$2
-       local mds_dev=$(facet_device $mds)
        local mntpt="/tmp/mdt_"
-       local opts
 
-       do_facet $mds mkdir -p $mntpt  || error "mkdir $mntpt failed"
+       do_facet $mds mkdir -p $mntpt || error "mkdir $mntpt failed"
        mount_fstype $mds $mntpt  || error "mount $mds failed"
 
        local xattrval=$(do_facet $mds getfattr -n security.selinux \
@@ -102,7 +95,6 @@ get_sel_ctx() {
 }
 
 test_1() {
-       local devname=$(mdsdevname 1)
        local filename=${DIR}/${tdir}/df1
        local mds_path=${filename#$MOUNT}
 
@@ -119,13 +111,12 @@ test_1() {
 run_test 1 "create file and check security.selinux xattr is set on MDT"
 
 test_2a() {
-       local devname=$(mdsdevname 1)
        local dirname=${DIR}/${tdir}/dir2a
        local mds_path=${dirname#$MOUNT}
 
        mds_path=${mds_path#/}
 
-       $LFS setdirstripe -i0 -c1 ${DIR}/$tdir || error "create dir failed"
+       mkdir_on_mdt0 ${DIR}/$tdir || error "create dir failed"
        mkdir $dirname || error "cannot mkdir $dirname"
 
        local xattrval=$(check_selinux_xattr "mds1" $mds_path)
@@ -136,7 +127,6 @@ test_2a() {
 run_test 2a "create dir (mkdir) and check security.selinux xattr is set on MDT"
 
 test_2b() {
-       local devname=$(mdsdevname 1)
        local dirname1=${DIR}/$tdir/dir2b1
        local dirname2=${DIR}/$tdir/dir2b2
        local mds_path=${dirname1#$MOUNT}
@@ -549,7 +539,9 @@ create_nodemap() {
        check_nodemap $nm trusted_nodemap 1
 
        sleep 10
+       l_getsepol || error "cannot get sepol"
        sepol=$(l_getsepol | cut -d':' -f2- | xargs)
+       [ -n "$sepol" ] || error "sepol is empty"
        do_facet mgs $LCTL set_param -P nodemap.$nm.sepol="$sepol"
 
        check_nodemap $nm sepol $sepol
@@ -593,7 +585,7 @@ test_21a() {
                export SK_UNIQUE_NM=true
 
                # load specific key on servers
-               do_nodes $(comma_list $(all_server_nodes)) "lgss_sk -t server \
+               do_nodes $(comma_list $(all_server_nodes)) "$LGSS_SK -t server \
                                                    -l $SK_PATH/nodemap/c0.key"
 
                # set perms for per-nodemap keys else permission denied
@@ -642,9 +634,12 @@ test_21b() {
        [ "$MDS1_VERSION" -lt $(version_code 2.11.56) ] &&
                skip "Need MDS >= 2.11.56"
 
+       stack_trap "restore_opencache" EXIT
+       disable_opencache
+
        local sepol
 
-       mkdir -p $DIR/$tdir || error "failed to create $DIR/$tdir"
+       mkdir_on_mdt0 $DIR/$tdir || error "failed to create $DIR/$tdir"
        echo test > $DIR/$tdir/toopen ||
                error "failed to write to $DIR/$tdir/toopen"
        touch $DIR/$tdir/ftoremove ||
@@ -678,7 +673,7 @@ test_21b() {
                export SK_UNIQUE_NM=true
 
                # load specific key on servers
-               do_nodes $(comma_list $(all_server_nodes)) "lgss_sk -t server \
+               do_nodes $(comma_list $(all_server_nodes)) "$LGSS_SK -t server \
                                                    -l $SK_PATH/nodemap/c0.key"
 
                # set perms for per-nodemap keys else permission denied
@@ -754,7 +749,9 @@ test_21b() {
        ln $DIR/$tdir/toopen $DIR/$tdir/toopen_hl3 && error "hardlink (3)"
 
        # reset correct sepol
+       l_getsepol || error "cannot get sepol"
        sepol=$(l_getsepol | cut -d':' -f2- | xargs)
+       [ -n "$sepol" ] || error "sepol is empty"
        do_facet mgs $LCTL set_param -P nodemap.c0.sepol="$sepol"
        check_nodemap c0 sepol $sepol
 
@@ -848,6 +845,6 @@ test_21b() {
 }
 run_test 21b "Send sepol for metadata ops"
 
-complete $SECONDS
+complete_test $SECONDS
 check_and_cleanup_lustre
 exit_status