LU-13284 tests: few tests miss MDS_MOUNT_OPTS/OST_MOUNT_OPTS

[fs/lustre-release.git] / lustre / tests / sanity-lfsck.sh

diff --git a/lustre/tests/sanity-lfsck.sh b/lustre/tests/sanity-lfsck.sh
index 967b7d2..755d823 100644 (file)
--- a/lustre/tests/sanity-lfsck.sh
+++ b/lustre/tests/sanity-lfsck.sh
@@ -40,9 +40,9 @@ SAVED_OSTCOUNT=${OSTCOUNT}
 # use small MDS + OST size to speed formatting time
 # do not use too small MDSSIZE/OSTSIZE, which affect the default journal size
 MDSSIZE=100000
-[ $(facet_fstype $SINGLEMDS) == zfs ] && MDSSIZE=300000
+[ "$mds1_FSTYPE" == zfs ] && MDSSIZE=300000
 OSTSIZE=100000
-[ $(facet_fstype ost1) == zfs ] && OSTSIZE=300000
+[ "$ost1_FSTYPE" == zfs ] && OSTSIZE=300000
 
 # no need too many OSTs, to reduce the format/start/stop overhead
 cleanupall
@@ -68,7 +68,7 @@ SHOW_LAYOUT_ON_OST="do_facet ost1 \
                $LCTL get_param -n obdfilter.${OST_DEV}.lfsck_layout"
 MOUNT_OPTS_SCRUB="$MDS_MOUNT_OPTS -o user_xattr"
 MOUNT_OPTS_NOSCRUB="$MDS_MOUNT_OPTS -o user_xattr,noscrub"
-MOUNT_OPTS_SKIP_LFSCK="-o user_xattr,skip_lfsck"
+MOUNT_OPTS_SKIP_LFSCK="$MDS_MOUNT_OPTS -o user_xattr,skip_lfsck"
 
 lfsck_prep() {
        local ndirs=$1
@@ -241,8 +241,8 @@ run_test 1a "LFSCK can find out and repair crashed FID-in-dirent"
 
 test_1b()
 {
-       [ $(facet_fstype $SINGLEMDS) != ldiskfs ] &&
-               skip "OI Scrub not implemented for ZFS" && return
+       [ "$mds1_FSTYPE" != ldiskfs ] &&
+               skip "OI Scrub not implemented for ZFS"
 
        lfsck_prep 1 1
 
@@ -324,6 +324,70 @@ test_1c() {
 }
 run_test 1c "LFSCK can find out and repair lost FID-in-dirent"
 
+test_1d() {
+       [ $MDS1_VERSION -lt $(version_code 2.13.57) ] &&
+               skip "MDS older than 2.13.57"
+       [ $MDSCOUNT -lt 2 ] && skip "needs >= 2 MDTs"
+
+       check_mount_and_prep
+
+       touch $DIR/$tdir/$tfile
+       mkdir $DIR/$tdir/subdir
+       $LFS mkdir -i 1 $DIR/$tdir/remotedir
+       $LFS path2fid $DIR/$tdir
+       ll_decode_linkea $DIR/$tdir/$tfile
+       ll_decode_linkea $DIR/$tdir/subdir
+       ll_decode_linkea $DIR/$tdir/remotedir
+
+       local mntpt=$(facet_mntpt mds1)
+
+       # unlink OI files to remove the stale entry
+       local saved_opts=$MDS_MOUNT_OPTS
+
+       stopall
+       mount_fstype mds1 $mntpt
+       # increase $tdir FID oid in LMA
+       do_facet mds1 "getfattr -d -m trusted.lma -e hex \
+               --absolute-names $mntpt/ROOT/$tdir | \
+               sed -E 's/0(.{8})$/1\1/' | setfattr --restore=-"
+       unmount_fstype mds1 $mntpt
+       setupall
+
+       # the FID oid in LMA was increased above, and it's not in OI table,
+       # run scrub first to generate mapping in OI, so the following namespace
+       # check can fix linkea correctly, this is not necessary normally.
+       do_facet mds1 $LCTL lfsck_start -M ${MDT_DEV} -t scrub ||
+               error "failed to start LFSCK for scrub!"
+       wait_update_facet mds1 "$LCTL get_param -n \
+               osd-*.$(facet_svc mds1).oi_scrub |
+               awk '/^status/ { print \\\$2 }'" "completed" 32 ||
+               error "unexpected status"
+
+       $START_NAMESPACE -r -A || error "fail to start LFSCK for namespace!"
+       wait_update_facet mds1 "$LCTL get_param -n \
+               mdd.${MDT_DEV}.lfsck_namespace |
+               awk '/^status/ { print \\\$2 }'" "completed" 32 || {
+               $SHOW_NAMESPACE
+               error "unexpected status"
+       }
+       $LFS path2fid $DIR/$tdir
+       ll_decode_linkea $DIR/$tdir/$tfile
+       ll_decode_linkea $DIR/$tdir/subdir
+       ll_decode_linkea $DIR/$tdir/remotedir
+
+       local pfid
+       local fid
+
+       fid=$($LFS path2fid $DIR/$tdir)
+       for f in $tfile subdir remotedir; do
+               pfid=$(ll_decode_linkea $DIR/$tdir/$f |
+                       awk '/pfid/ { print $3 }')
+               pfid=${pfid%,}
+               [ "$pfid" == "$fid" ] || error "$fid in LMA != $pfid in linkea"
+       done
+}
+run_test 1d "LFSCK can fix mismatch of FID in LMA and FID in child linkea"
+
 test_2a() {
        lfsck_prep 1 1
 
@@ -560,8 +624,8 @@ run_test 3 "LFSCK can verify multiple-linked objects"
 
 test_4()
 {
-       [ $(facet_fstype $SINGLEMDS) != ldiskfs ] &&
-               skip "OI Scrub not implemented for ZFS" && return
+       [ "$mds1_FSTYPE" != ldiskfs ] &&
+               skip "OI Scrub not implemented for ZFS"
 
        lfsck_prep 3 3
        cleanup_mount $MOUNT || error "(0.1) Fail to stop client!"
@@ -620,8 +684,8 @@ run_test 4 "FID-in-dirent can be rebuilt after MDT file-level backup/restore"
 
 test_5()
 {
-       [ $(facet_fstype $SINGLEMDS) != ldiskfs ] &&
-               skip "OI Scrub not implemented for ZFS" && return
+       [ "$mds1_FSTYPE" != ldiskfs ] &&
+               skip "OI Scrub not implemented for ZFS"
 
        lfsck_prep 1 1 1
        cleanup_mount $MOUNT || error "(0.1) Fail to stop client!"
@@ -4848,6 +4912,10 @@ test_31a() {
        [ $repaired -ge 1 ] ||
                error "(5) Fail to repair bad name hash: $repaired"
 
+       local rc=$($LFS find -H badtype $DIR/$tdir/striped_dir | wc -l)
+       [ $rc -ge 1 ] ||
+               error "Fail to find flag bad type: $rc"
+
        umount_client $MOUNT || error "(6) umount failed"
        mount_client $MOUNT || error "(7) mount failed"
 
@@ -4951,6 +5019,9 @@ test_31c() {
        [ $repaired -eq 1 ] ||
                error "(4) Fail to re-generate master LMV EA: $repaired"
 
+       local rc=$($LFS find -H lostlmv $DIR/$tdir/striped_dir | wc -l)
+       [ $rc -eq 1 ] || error "Fail to find flag lost LMV: $rc"
+
        umount_client $MOUNT || error "(5) umount failed"
        mount_client $MOUNT || error "(6) mount failed"
 
@@ -5281,9 +5352,8 @@ run_test 33 "check LFSCK paramters"
 
 test_34()
 {
-       [ $MDSCOUNT -lt 2 ] && skip "needs >= 2 MDTs" && return
-       [ $(facet_fstype $SINGLEMDS) != zfs ] &&
-               skip "Only valid for ZFS backend" && return
+       [ $MDSCOUNT -lt 2 ] && skip "needs >= 2 MDTs"
+       [ "$mds1_FSTYPE" != zfs ] && skip "Only valid for ZFS backend"
 
        lfsck_prep 1 1
 
@@ -5705,7 +5775,7 @@ run_test 37 "LFSCK must skip a ORPHAN"
 
 test_38()
 {
-       [[ $MDS1_VERSION -le $(version_code 2.12.51) ]] &&
+       [[ "$MDS1_VERSION" -le $(version_code 2.12.51) ]] &&
                skip "Need MDS version newer than 2.12.51"
 
        test_mkdir $DIR/$tdir
@@ -5713,7 +5783,7 @@ test_38()
        local uuid2=$(cat /proc/sys/kernel/random/uuid)
 
        # create foreign file
-       $LFS setstripe --foreign=daos --flags 0xda05 \
+       $LFS setstripe --foreign=none --flags 0xda05 \
                -x "${uuid1}@${uuid2}" $DIR/$tdir/$tfile ||
                error "$DIR/$tdir/$tfile: create failed"
 
@@ -5723,7 +5793,7 @@ test_38()
        # lfm_length is LOV EA size - sizeof(lfm_magic) - sizeof(lfm_length)
        $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_length:.*73" ||
                error "$DIR/$tdir/$tfile: invalid LOV EA foreign size"
-       $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_type:.*daos" ||
+       $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_type:.*none" ||
                error "$DIR/$tdir/$tfile: invalid LOV EA foreign type"
        $LFS getstripe -v $DIR/$tdir/$tfile |
                grep "lfm_flags:.*0x0000DA05" ||
@@ -5766,7 +5836,7 @@ test_38()
        # lfm_length is LOV EA size - sizeof(lfm_magic) - sizeof(lfm_length)
        $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_length:.*73" ||
                error "$DIR/$tdir/$tfile: invalid LOV EA foreign size"
-       $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_type:.*daos" ||
+       $LFS getstripe -v $DIR/$tdir/$tfile | grep "lfm_type:.*none" ||
                error "$DIR/$tdir/$tfile: invalid LOV EA foreign type"
        $LFS getstripe -v $DIR/$tdir/$tfile |
                grep "lfm_flags:.*0x0000DA05" ||
@@ -5792,7 +5862,7 @@ run_test 38 "LFSCK does not break foreign file and reverse is also true"
 
 test_39()
 {
-       [[ $(lustre_version_code $SINGLEMDS) -le $(version_code 2.12.51) ]] &&
+       [[ "$MDS1_VERSION" -le $(version_code 2.12.51) ]] &&
                skip "Need MDS version newer than 2.12.51"
 
        test_mkdir $DIR/$tdir
@@ -5800,7 +5870,7 @@ test_39()
        local uuid2=$(cat /proc/sys/kernel/random/uuid)
 
        # create foreign dir
-       $LFS mkdir --foreign=daos --xattr="${uuid1}@${uuid2}" --flags=0xda05 \
+       $LFS mkdir --foreign=none --xattr="${uuid1}@${uuid2}" --flags=0xda05 \
                $DIR/$tdir/${tdir}2 ||
                error "$DIR/$tdir/${tdir}2: create failed"
 
@@ -5811,7 +5881,7 @@ test_39()
        # - sizeof(lfm_type) - sizeof(lfm_flags)
        $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_length:.*73" ||
                error "$DIR/$tdir/${tdir}2: invalid LMV EA size"
-       $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_type:.*daos" ||
+       $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_type:.*none" ||
                error "$DIR/$tdir/${tdir}2: invalid LMV EA type"
        $LFS getdirstripe -v $DIR/$tdir/${tdir}2 |
                grep "lfm_flags:.*0x0000DA05" ||
@@ -5863,7 +5933,7 @@ test_39()
        # - sizeof(lfm_type) - sizeof(lfm_flags)
        $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_length:.*73" ||
                error "$DIR/$tdir/${tdir}2: invalid LMV EA size"
-       $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_type:.*daos" ||
+       $LFS getdirstripe -v $DIR/$tdir/${tdir}2 | grep "lfm_type:.*none" ||
                error "$DIR/$tdir/${tdir}2: invalid LMV EA type"
        $LFS getdirstripe -v $DIR/$tdir/${tdir}2 |
                grep "lfm_flags:.*0x0000DA05" ||
@@ -5919,6 +5989,35 @@ test_40a() {
 }
 run_test 40a "LFSCK correctly fixes lmm_oi in composite layout"
 
+test_41()
+{
+       local old_debug=$(do_facet $SINGLEMDS $LCTL get_param -n debug)
+
+       do_facet $SINGLEMDS $LCTL set_param debug=+lfsck
+       $LFS setstripe -E 1G -z 64M -E -1 -z 128M $DIR/$tfile
+       do_facet $SINGLEMDS $LCTL dk > /dev/null
+
+       echo "trigger LFSCK for SEL layout"
+       do_facet $SINGLEMDS $LCTL lfsck_start -M ${MDT_DEV} -A -t all -r -n on
+       wait_update_facet $SINGLEMDS "$LCTL get_param -n \
+               mdd.${MDT_DEV}.lfsck_layout |
+               awk '/^status/ { print \\\$2 }'" "completed" 32 || {
+               $SHOW_LAYOUT
+               error "(2) unexpected status"
+       }
+
+       local errors=$(do_facet $SINGLEMDS $LCTL dk |
+                      grep "lfsck_layout_verify_header")
+
+       [[ "x$errors" == "x" ]] || {
+               echo "$errors"
+               error "lfsck failed"
+       }
+
+       do_facet $SINGLEMDS "$LCTL set_param debug='$old_debug'"
+}
+run_test 41 "SEL support in LFSCK"
+
 # restore MDS/OST size
 MDSSIZE=${SAVED_MDSSIZE}
 OSTSIZE=${SAVED_OSTSIZE}