* GPL HEADER END
*/
/*
- * Copyright 2008 Sun Microsystems, Inc. All rights reserved
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
* Use is subject to license terms.
*/
/*
#ifdef HAVE_QUOTA_SUPPORT
-/* lock ordering: mds->mds_qonoff_sem > dquot->dq_sem */
+/* lock ordering: mds->mds_qonoff_sem > dquot->dq_sem > lqs->lqs_lock */
static cfs_list_t lustre_dquot_hash[NR_DQHASH];
-static cfs_spinlock_t dquot_hash_lock = CFS_SPIN_LOCK_UNLOCKED;
+static cfs_rwlock_t dquot_hash_lock = CFS_RW_LOCK_UNLOCKED;
cfs_mem_cache_t *lustre_dquot_cachep;
struct lustre_dquot *dquot;
ENTRY;
- LASSERT_SPIN_LOCKED(&dquot_hash_lock);
cfs_list_for_each_entry(dquot, &lustre_dquot_hash[hashent], dq_hash) {
if (dquot->dq_info == lqi &&
dquot->dq_id == id && dquot->dq_type == type)
CFS_INIT_LIST_HEAD(&dquot->dq_hash);
cfs_init_mutex_locked(&dquot->dq_sem);
- dquot->dq_refcnt = 1;
+ cfs_atomic_set(&dquot->dq_refcnt, 1);
dquot->dq_info = lqi;
dquot->dq_id = id;
dquot->dq_type = type;
- dquot->dq_status = DQ_STATUS_AVAIL;
RETURN(dquot);
}
static void lustre_dqput(struct lustre_dquot *dquot)
{
ENTRY;
- cfs_spin_lock(&dquot_hash_lock);
- LASSERT(dquot->dq_refcnt);
- dquot->dq_refcnt--;
- if (!dquot->dq_refcnt) {
+ cfs_write_lock(&dquot_hash_lock);
+ LASSERT(cfs_atomic_read(&dquot->dq_refcnt));
+ cfs_atomic_dec(&dquot->dq_refcnt);
+ if (cfs_atomic_read(&dquot->dq_refcnt) == 0) {
remove_dquot_nolock(dquot);
free_dquot(dquot);
}
- cfs_spin_unlock(&dquot_hash_lock);
+ cfs_write_unlock(&dquot_hash_lock);
EXIT;
}
static struct lustre_dquot *lustre_dqget(struct obd_device *obd,
struct lustre_quota_info *lqi,
- qid_t id, int type)
+ qid_t id, int type, int can_fake)
{
unsigned int hashent = dquot_hashfn(lqi, id, type);
struct lustre_dquot *dquot, *empty;
+ int free_dq = 0;
ENTRY;
if ((empty = alloc_dquot(lqi, id, type)) == NULL)
RETURN(ERR_PTR(-ENOMEM));
- cfs_spin_lock(&dquot_hash_lock);
+ cfs_read_lock(&dquot_hash_lock);
if ((dquot = find_dquot(hashent, lqi, id, type)) != NULL) {
- dquot->dq_refcnt++;
- cfs_spin_unlock(&dquot_hash_lock);
- free_dquot(empty);
+ cfs_atomic_inc(&dquot->dq_refcnt);
+ cfs_read_unlock(&dquot_hash_lock);
+ free_dq = 1;
} else {
int rc;
- dquot = empty;
- insert_dquot_nolock(dquot);
- cfs_spin_unlock(&dquot_hash_lock);
+ cfs_read_unlock(&dquot_hash_lock);
+ dquot = empty;
rc = fsfilt_dquot(obd, dquot, QFILE_RD_DQUOT);
cfs_up(&dquot->dq_sem);
if (rc) {
CERROR("can't read dquot from admin quotafile! "
"(rc:%d)\n", rc);
- lustre_dqput(dquot);
+ free_dquot(dquot);
RETURN(ERR_PTR(rc));
+ } else {
+ cfs_write_lock(&dquot_hash_lock);
+ if ((dquot = find_dquot(hashent, lqi, id, type)) != NULL) {
+ cfs_atomic_inc(&dquot->dq_refcnt);
+ free_dq = 1;
+ } else {
+ dquot = empty;
+ insert_dquot_nolock(dquot);
+ }
+ cfs_write_unlock(&dquot_hash_lock);
}
}
LASSERT(dquot);
+ if (!can_fake && cfs_test_bit(DQ_FAKE_B, &dquot->dq_flags)) {
+ DQUOT_DEBUG(dquot, "It is a fake dquot: unexpected!\n");
+ lustre_dqput(dquot);
+ dquot = ERR_PTR(-ENOENT);
+ }
+
+ if (free_dq)
+ free_dquot(empty);
+
+
RETURN(dquot);
}
ENTRY;
LASSERT(mds);
- dquot = lustre_dqget(obd, info, id, type);
+ cfs_down_read(&mds->mds_qonoff_sem);
+ dquot = lustre_dqget(obd, info, id, type, 0);
if (IS_ERR(dquot))
RETURN(PTR_ERR(dquot));
+ cfs_up_read(&mds->mds_qonoff_sem);
OBD_ALLOC_PTR(oqaq);
if (!oqaq)
GOTO(out, rc = -ENOMEM);
/* only when block qunit is reduced, boardcast to osts */
if ((adjust_res & LQS_BLK_DECREASE) && QAQ_IS_ADJBLK(oqaq))
- rc = obd_quota_adjust_qunit(mds->mds_osc_exp, oqaq, qctxt);
+ rc = obd_quota_adjust_qunit(mds->mds_lov_exp, oqaq, qctxt, NULL);
out:
lustre_dqput(dquot);
if (OBD_FAIL_CHECK(OBD_FAIL_OBD_DQACQ))
RETURN(-EIO);
- dquot = lustre_dqget(obd, info, qdata->qd_id, QDATA_IS_GRP(qdata));
- if (IS_ERR(dquot))
- RETURN(PTR_ERR(dquot));
+ if (!ll_sb_has_quota_active(qctxt->lqc_sb,
+ QDATA_IS_GRP(qdata) ? GRPQUOTA : USRQUOTA))
+ RETURN(-EIO);
+
+ lqs = quota_search_lqs(LQS_KEY(QDATA_IS_GRP(qdata), qdata->qd_id),
+ qctxt, 0);
+ if (lqs == NULL)
+ rc = -ENOENT;
+ if (IS_ERR(lqs))
+ rc = PTR_ERR(lqs);
+ if (rc)
+ RETURN(rc);
+
+ cfs_spin_lock(&lqs->lqs_lock);
+ if (LQS_IS_RECOVERY(lqs)) {
+ cfs_spin_unlock(&lqs->lqs_lock);
+ LQS_DEBUG(lqs, "this lqs is under recovery\n");
+ GOTO(skip, rc = -EBUSY);
+ }
+ cfs_spin_unlock(&lqs->lqs_lock);
+
+ cfs_down_write(&mds->mds_qonoff_sem);
+ dquot = lustre_dqget(obd, info, qdata->qd_id, QDATA_IS_GRP(qdata), 0);
+ if (IS_ERR(dquot)) {
+ cfs_up_write(&mds->mds_qonoff_sem);
+ GOTO(skip, rc = PTR_ERR(dquot));
+ }
DQUOT_DEBUG(dquot, "get dquot in dqacq_handler\n");
QINFO_DEBUG(dquot->dq_info, "get dquot in dqadq_handler\n");
- cfs_down(&mds->mds_qonoff_sem);
cfs_down(&dquot->dq_sem);
- if (dquot->dq_status & DQ_STATUS_RECOVERY) {
- DQUOT_DEBUG(dquot, "this dquot is under recovering.\n");
- GOTO(out, rc = -EBUSY);
- }
-
if (QDATA_IS_BLK(qdata)) {
grace = info->qi_info[QDATA_IS_GRP(qdata)].dqi_bgrace;
usage = &dquot->dq_dqb.dqb_curspace;
EXIT;
out:
cfs_up(&dquot->dq_sem);
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
lustre_dqput(dquot);
if (rc != -EDQUOT)
dqacq_adjust_qunit_sz(obd, qdata->qd_id, QDATA_IS_GRP(qdata),
QDATA_IS_BLK(qdata));
- lqs = quota_search_lqs(LQS_KEY(QDATA_IS_GRP(qdata), qdata->qd_id),
- qctxt, 0);
- if (lqs == NULL || IS_ERR(lqs)) {
- CDEBUG(D_INFO, "Can't find the lustre qunit size!\n");
- qdata->qd_qunit = QDATA_IS_BLK(qdata) ? qctxt->lqc_bunit_sz :
- qctxt->lqc_iunit_sz;
- } else {
- cfs_spin_lock(&lqs->lqs_lock);
- qdata->qd_qunit = QDATA_IS_BLK(qdata) ? lqs->lqs_bunit_sz :
- lqs->lqs_iunit_sz;
- cfs_spin_unlock(&lqs->lqs_lock);
- }
+ cfs_spin_lock(&lqs->lqs_lock);
+ qdata->qd_qunit = QDATA_IS_BLK(qdata) ? lqs->lqs_bunit_sz :
+ lqs->lqs_iunit_sz;
+ cfs_spin_unlock(&lqs->lqs_lock);
if (QDATA_IS_BLK(qdata))
QDATA_SET_ADJBLK(qdata);
QDATA_SET_ADJINO(qdata);
QDATA_DEBUG(qdata, "alloc/release qunit in dqacq_handler\n");
- if (lqs)
- lqs_putref(lqs);
+skip:
+ lqs_putref(lqs);
return rc;
}
cfs_down(&obt->obt_quotachecking);
push_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
for (i = 0; i < MAXQUOTAS; i++) {
struct file *fp;
filp_close(fp, 0);
}
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
pop_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
cfs_up(&obt->obt_quotachecking);
RETURN(rc ? : rc1);
RETURN(-EINVAL);
cfs_down(&obt->obt_quotachecking);
+ if (obt->obt_qctxt.lqc_flags & UGQUOTA2LQC(oqctl->qc_type))
+ GOTO(out, rc = -EBUSY);
push_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
oqctl->qc_cmd = Q_FINVALIDATE;
rc = fsfilt_quotactl(obd, obd->u.obt.obt_sb, oqctl);
if (!rc)
- rc = obd_quotactl(mds->mds_osc_exp, oqctl);
+ rc = obd_quotactl(mds->mds_lov_exp, oqctl);
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
pop_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
+out:
cfs_up(&obt->obt_quotachecking);
RETURN(rc);
}
LASSERT(qinfo->qi_version == LUSTRE_QUOTA_V2);
push_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
-
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
for (i = 0; i < MAXQUOTAS && !rc; i++) {
struct file *fp;
}
qinfo->qi_files[i] = fp;
rc = fsfilt_quotainfo(obd, qinfo, i, QFILE_CHK);
- qinfo->qi_files[i] = 0;
+ qinfo->qi_files[i] = NULL;
filp_close(fp, 0);
}
else
filp_close(fp, 0);
qinfo->qi_files[i] = NULL;
}
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
pop_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
RETURN(rc);
}
for (i = 0; i < MAXQUOTAS; i++) {
struct file *fp;
- if (!Q_TYPESET(oqctl, i))
+ if (!Q_TYPESET(oqctl, i) || qinfo->qi_files[i] != NULL)
continue;
LASSERT(strlen(quotafile[i])
+ sizeof(prefix) <= sizeof(name));
sprintf(name, "%s%s", prefix, quotafile[i]);
-
- if (qinfo->qi_files[i] != NULL) {
- CWARN("quota[%d] is on already\n", i);
- rc1 = -EALREADY;
- continue;
- }
-
fp = filp_open(name, O_RDWR, 0);
if (IS_ERR(fp) || !S_ISREG(fp->f_dentry->d_inode->i_mode)) {
rc = IS_ERR(fp) ? PTR_ERR(fp) : -EINVAL;
RETURN(rc ? : rc1);
}
-int mds_admin_quota_off(struct obd_device *obd,
- struct obd_quotactl *oqctl)
-{
- struct mds_obd *mds = &obd->u.mds;
- struct lustre_quota_info *qinfo = &mds->mds_quota_info;
- int rc;
- ENTRY;
-
- /* close admin quota files */
- rc = close_quota_files(oqctl, qinfo);
- RETURN(rc);
-}
-
int mds_quota_on(struct obd_device *obd, struct obd_quotactl *oqctl)
{
- struct mds_obd *mds = &obd->u.mds;
- struct obd_device_target *obt = &obd->u.obt;
- struct lustre_quota_ctxt *qctxt = &obt->obt_qctxt;
- struct lvfs_run_ctxt saved;
- int rc = 0, rc1 = 0, rc2 = 0;
+ int rc;
ENTRY;
if (oqctl->qc_type != USRQUOTA &&
oqctl->qc_type != UGQUOTA)
RETURN(-EINVAL);
- cfs_down(&obt->obt_quotachecking);
- push_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
- cfs_down(&mds->mds_qonoff_sem);
- rc2 = mds_admin_quota_on(obd, oqctl);
- if (rc2 && rc2 != -EALREADY) {
- CWARN("mds quota[%d] is failed to be on for %d\n", oqctl->qc_type, rc2);
- GOTO(out, rc2);
- }
+ rc = generic_quota_on(obd, oqctl, 1);
- rc1 = fsfilt_quotactl(obd, obd->u.obt.obt_sb, oqctl);
- if (!rc1) {
- qctxt->lqc_flags |= UGQUOTA2LQC(oqctl->qc_type);
- /* when quotaon, create lqs for every quota uid/gid b=18574 */
- build_lqs(obd);
- } else if (rc1 == -EBUSY && quota_is_on(qctxt, oqctl)) {
- CWARN("mds local quota[%d] is on already\n", oqctl->qc_type);
- rc1 = -EALREADY;
- } else {
- if (rc2 != -EALREADY) {
- CWARN("mds local quota[%d] is failed to be on for %d\n",
- oqctl->qc_type, rc1);
- oqctl->qc_cmd = Q_QUOTAOFF;
- mds_admin_quota_off(obd, oqctl);
- oqctl->qc_cmd = Q_QUOTAON;
- }
- GOTO(out, rc1);
- }
+ RETURN(rc);
+}
- rc = obd_quotactl(mds->mds_osc_exp, oqctl);
- if (rc && rc != -EALREADY) {
- CWARN("mds remote quota[%d] is failed to be on for %d\n",
- oqctl->qc_type, rc);
- oqctl->qc_cmd = Q_QUOTAOFF;
- if (rc2 != -EALREADY)
- mds_admin_quota_off(obd, oqctl);
- if (rc1 != -EALREADY) {
- fsfilt_quotactl(obd, obd->u.obt.obt_sb, oqctl);
- qctxt->lqc_flags &= ~UGQUOTA2LQC(oqctl->qc_type);
- }
- oqctl->qc_cmd = Q_QUOTAON;
- }
- EXIT;
+int mds_admin_quota_off(struct obd_device *obd,
+ struct obd_quotactl *oqctl)
+{
+ struct mds_obd *mds = &obd->u.mds;
+ struct lustre_quota_info *qinfo = &mds->mds_quota_info;
+ int rc;
+ ENTRY;
-out:
- cfs_up(&mds->mds_qonoff_sem);
- pop_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
- cfs_up(&obt->obt_quotachecking);
- return rc ? : (rc1 ? : rc2);
+ /* close admin quota files */
+ rc = close_quota_files(oqctl, qinfo);
+ RETURN(rc);
}
+
/* with obt->obt_quotachecking held */
int do_mds_quota_off(struct obd_device *obd, struct obd_quotactl *oqctl)
{
RETURN(-EINVAL);
push_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
/* close admin quota files */
rc2 = mds_admin_quota_off(obd, oqctl);
if (rc2 && rc2 != -EALREADY) {
GOTO(out, rc1);
}
- rc = obd_quotactl(mds->mds_osc_exp, oqctl);
+ rc = obd_quotactl(mds->mds_lov_exp, oqctl);
if (rc && rc != -EALREADY) {
CWARN("mds remote quota[%d] is failed to be off for %d\n",
oqctl->qc_type, rc);
EXIT;
out:
- cfs_up(&mds->mds_qonoff_sem);
+ CDEBUG(D_QUOTA, "%s: quotaoff type:flags:rc %u:%lu:%d\n",
+ obd->obd_name, oqctl->qc_type, qctxt->lqc_flags, rc);
+ cfs_up_write(&mds->mds_qonoff_sem);
pop_ctxt(&saved, &obd->obd_lvfs_ctxt, NULL);
return rc ? : (rc1 ? : rc2);
}
oqctl->qc_type != GRPQUOTA)
RETURN(-EINVAL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
if (qinfo->qi_files[oqctl->qc_type] == NULL) {
CWARN("quota[%u] is off\n", oqctl->qc_type);
GOTO(out, rc = -ESRCH);
EXIT;
out:
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
return rc;
}
oqctl->qc_type != GRPQUOTA)
RETURN(-EINVAL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_read(&mds->mds_qonoff_sem);
if (qinfo->qi_files[oqctl->qc_type] == NULL) {
CWARN("quota[%u] is off\n", oqctl->qc_type);
GOTO(out, rc = -ESRCH);
EXIT;
out:
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_read(&mds->mds_qonoff_sem);
return rc;
}
id[GRPQUOTA] = oqctl->qc_id;
/* initialize all slave's limit */
- rc = obd_quotactl(mds->mds_osc_exp, ioqc);
+ rc = obd_quotactl(mds->mds_lov_exp, ioqc);
rc = qctxt_adjust_qunit(obd, &obd->u.obt.obt_qctxt, id, 1, 0, NULL);
if (rc == -EDQUOT || rc == -EBUSY) {
/* adjust remote lqs */
if (QAQ_IS_ADJBLK(qaq)) {
- rc = obd_quota_adjust_qunit(obd->u.mds.mds_osc_exp, qaq, qctxt);
+ rc = obd_quota_adjust_qunit(obd->u.mds.mds_lov_exp, qaq, qctxt, NULL);
if (rc < 0)
CERROR("adjust slaves' qunit size failed!(rc=%d)\n", rc);
{
struct mds_obd *mds = &obd->u.mds;
struct lustre_quota_ctxt *qctxt = &mds->mds_obt.obt_qctxt;
- struct obd_device *lov_obd = class_exp2obd(mds->mds_osc_exp);
+ struct obd_device *lov_obd = class_exp2obd(mds->mds_lov_exp);
struct lov_obd *lov = &lov_obd->u.lov;
struct quota_adjust_qunit *oqaq = NULL;
struct lustre_quota_info *qinfo = &mds->mds_quota_info;
/* orig_set means if quota was set before; now_set means we are
* setting/cancelling quota */
int orig_set, now_set;
- int rc, rc2 = 0, flag = 0;
+ struct lustre_qunit_size *lqs;
+ int rc = 0, rc2 = 0, flag = 0;
ENTRY;
if (oqctl->qc_type != USRQUOTA &&
OBD_ALLOC_PTR(oqaq);
if (!oqaq)
RETURN(-ENOMEM);
- cfs_down(&mds->mds_qonoff_sem);
+
+ cfs_down_write(&mds->mds_qonoff_sem);
init_oqaq(oqaq, qctxt, oqctl->qc_id, oqctl->qc_type);
if (qinfo->qi_files[oqctl->qc_type] == NULL) {
GOTO(out_sem, rc = -ESRCH);
}
- dquot = lustre_dqget(obd, qinfo, oqctl->qc_id, oqctl->qc_type);
+ dquot = lustre_dqget(obd, qinfo, oqctl->qc_id, oqctl->qc_type, 1);
if (IS_ERR(dquot))
GOTO(out_sem, rc = PTR_ERR(dquot));
DQUOT_DEBUG(dquot, "get dquot in mds_set_blk\n");
QINFO_DEBUG(dquot->dq_info, "get dquot in mds_set_blk\n");
- cfs_down(&dquot->dq_sem);
+ lqs = quota_search_lqs(LQS_KEY(oqctl->qc_type, oqctl->qc_id), qctxt, 1);
+ if (lqs == NULL)
+ rc = -ENOENT;
+ if (IS_ERR(lqs))
+ rc = PTR_ERR(lqs);
+ if (rc)
+ GOTO(out, rc);
- if (dquot->dq_status) {
+ cfs_down(&dquot->dq_sem);
+ cfs_spin_lock(&lqs->lqs_lock);
+ if (LQS_IS_SETQUOTA(lqs) || LQS_IS_RECOVERY(lqs)) {
+ cfs_spin_unlock(&lqs->lqs_lock);
cfs_up(&dquot->dq_sem);
- lustre_dqput(dquot);
- GOTO(out_sem, rc = -EBUSY);
+ GOTO(skip, rc = -EBUSY);
}
- dquot->dq_status |= DQ_STATUS_SET;
+ LQS_SET_SETQUOTA(lqs);
+ cfs_spin_unlock(&lqs->lqs_lock);
ihardlimit = dquot->dq_dqb.dqb_ihardlimit;
isoftlimit = dquot->dq_dqb.dqb_isoftlimit;
if (rc) {
CERROR("set limit failed! (rc:%d)\n", rc);
- goto out;
+ GOTO(update_fail, rc);
}
- cfs_up(&mds->mds_qonoff_sem);
-
+ cfs_up_write(&mds->mds_qonoff_sem);
adjust_lqs(obd, oqaq);
orig_set = ihardlimit || isoftlimit;
}
revoke_out:
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_write(&mds->mds_qonoff_sem);
cfs_down(&dquot->dq_sem);
if (rc) {
/* cancel previous setting */
}
rc2 = fsfilt_dquot(obd, dquot, QFILE_WR_DQUOT);
cfs_up(&dquot->dq_sem);
-
+update_fail:
+ cfs_spin_lock(&lqs->lqs_lock);
+ LQS_CLEAR_SETQUOTA(lqs);
+ cfs_spin_unlock(&lqs->lqs_lock);
+skip:
+ lqs_putref(lqs);
out:
- cfs_down(&dquot->dq_sem);
- dquot->dq_status &= ~DQ_STATUS_SET;
- cfs_up(&dquot->dq_sem);
lustre_dqput(dquot);
EXIT;
out_sem:
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_write(&mds->mds_qonoff_sem);
if (oqaq)
OBD_FREE_PTR(oqaq);
/* get block usage from OSS */
soqc->qc_dqblk.dqb_curspace = 0;
- rc = obd_quotactl(obd->u.mds.mds_osc_exp, soqc);
+ rc = obd_quotactl(obd->u.mds.mds_lov_exp, soqc);
if (!rc || rc == -EREMOTEIO) {
oqctl->qc_dqblk.dqb_curspace = soqc->qc_dqblk.dqb_curspace;
oqctl->qc_dqblk.dqb_valid |= QIF_SPACE;
oqctl->qc_type != GRPQUOTA)
RETURN(-EINVAL);
- cfs_down(&mds->mds_qonoff_sem);
+ cfs_down_read(&mds->mds_qonoff_sem);
dqblk->dqb_valid = 0;
if (qinfo->qi_files[oqctl->qc_type] == NULL) {
CWARN("quota[%u] is off\n", oqctl->qc_type);
GOTO(out, rc = -ESRCH);
}
- dquot = lustre_dqget(obd, qinfo, oqctl->qc_id, oqctl->qc_type);
+ dquot = lustre_dqget(obd, qinfo, oqctl->qc_id, oqctl->qc_type, 1);
if (IS_ERR(dquot))
GOTO(out, rc = PTR_ERR(dquot));
cfs_up(&dquot->dq_sem);
lustre_dqput(dquot);
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_read(&mds->mds_qonoff_sem);
/* the usages in admin quota file is inaccurate */
dqblk->dqb_curinodes = 0;
dqblk->dqb_curspace = 0;
rc = mds_get_space(obd, oqctl);
- EXIT;
- return rc;
+
+ /*
+ * Querying of curinodes and/or curspace may have failed, administrative
+ * quota data are likely to be better approximation to the real usage in
+ * this case.
+ */
+ if (!(dqblk->dqb_valid & QIF_INODES) && dquot->dq_dqb.dqb_curinodes > 0)
+ dqblk->dqb_curinodes = dquot->dq_dqb.dqb_curinodes;
+
+ if (!(dqblk->dqb_valid & QIF_SPACE) && dquot->dq_dqb.dqb_curspace > 0)
+ dqblk->dqb_curspace = dquot->dq_dqb.dqb_curspace;
+
+ RETURN(rc);
+
out:
- cfs_up(&mds->mds_qonoff_sem);
+ cfs_up_read(&mds->mds_qonoff_sem);
return rc;
}
dquot_recovery(struct obd_device *obd, unsigned int id, unsigned short type)
{
struct mds_obd *mds = &obd->u.mds;
- struct lustre_quota_info *qinfo= &mds->mds_quota_info;
+ struct lustre_quota_ctxt *qctxt = &mds->mds_obt.obt_qctxt;
+ struct lustre_quota_info *qinfo = &mds->mds_quota_info;
+ struct lustre_qunit_size *lqs;
struct lustre_dquot *dquot;
struct obd_quotactl *qctl;
__u64 total_limits = 0;
- int rc;
+ int rc = 0;
ENTRY;
OBD_ALLOC_PTR(qctl);
if (qctl == NULL)
RETURN(-ENOMEM);
- dquot = lustre_dqget(obd, qinfo, id, type);
+ dquot = lustre_dqget(obd, qinfo, id, type, 0);
if (IS_ERR(dquot)) {
CERROR("Get dquot failed. (rc:%ld)\n", PTR_ERR(dquot));
OBD_FREE_PTR(qctl);
RETURN(PTR_ERR(dquot));
}
+ lqs = quota_search_lqs(LQS_KEY(type, id), qctxt, 1);
+ if (lqs == NULL)
+ rc = -ENOENT;
+ if (IS_ERR(lqs))
+ rc = PTR_ERR(lqs);
+ if (rc)
+ GOTO(skip, rc);
+
cfs_down(&dquot->dq_sem);
- /* don't recovery the dquot without limits or under setting */
+ /* don't recover the dquot without limits or quota is setting or
+ * another recovery is already going on */
if (!(dquot->dq_dqb.dqb_bhardlimit || dquot->dq_dqb.dqb_bsoftlimit) ||
- dquot->dq_status)
- GOTO(skip, rc = 0);
- dquot->dq_status |= DQ_STATUS_RECOVERY;
+ LQS_IS_SETQUOTA(lqs) || LQS_IS_RECOVERY(lqs)) {
+ cfs_up(&dquot->dq_sem);
+ GOTO(skip1, rc = 0);
+ }
+ cfs_spin_lock(&lqs->lqs_lock);
+ LQS_SET_RECOVERY(lqs);
+ cfs_spin_unlock(&lqs->lqs_lock);
cfs_up(&dquot->dq_sem);
+ /* release mds_qonoff_sem during obd_quotactl ops here */
+ cfs_up_write(&mds->mds_qonoff_sem);
+
/* get real bhardlimit from all slaves. */
qctl->qc_cmd = Q_GETOQUOTA;
qctl->qc_type = type;
qctl->qc_id = id;
qctl->qc_stat = QUOTA_RECOVERING;
- rc = obd_quotactl(mds->mds_osc_exp, qctl);
+ rc = obd_quotactl(mds->mds_lov_exp, qctl);
+ cfs_down_write(&mds->mds_qonoff_sem);
if (rc)
GOTO(out, rc);
total_limits = qctl->qc_dqblk.dqb_bhardlimit;
total_limits += qctl->qc_dqblk.dqb_bhardlimit;
/* amend the usage of the administrative quotafile */
- cfs_down(&mds->mds_qonoff_sem);
cfs_down(&dquot->dq_sem);
dquot->dq_dqb.dqb_curspace = total_limits << QUOTABLOCK_BITS;
CERROR("write dquot failed! (rc:%d)\n", rc);
cfs_up(&dquot->dq_sem);
- cfs_up(&mds->mds_qonoff_sem);
EXIT;
out:
- cfs_down(&dquot->dq_sem);
- dquot->dq_status &= ~DQ_STATUS_RECOVERY;
+ cfs_spin_lock(&lqs->lqs_lock);
+ LQS_CLEAR_RECOVERY(lqs);
+ cfs_spin_unlock(&lqs->lqs_lock);
+skip1:
+ lqs_putref(lqs);
skip:
- cfs_up(&dquot->dq_sem);
-
lustre_dqput(dquot);
OBD_FREE_PTR(qctl);
return rc;
/* for mds */
class_incref(obd, "qmaster_recovd_mds", obd);
/* for lov */
- class_incref(mds->mds_osc_obd, "qmaster_recovd_lov", mds->mds_osc_obd);
+ class_incref(mds->mds_lov_obd, "qmaster_recovd_lov", mds->mds_lov_obd);
cfs_complete(&data->comp);
+ cfs_down_write(&mds->mds_qonoff_sem);
for (type = USRQUOTA; type < MAXQUOTAS; type++) {
cfs_list_t id_list;
struct dquot_id *dqid, *tmp;
- cfs_down(&mds->mds_qonoff_sem);
- if (qinfo->qi_files[type] == NULL) {
- cfs_up(&mds->mds_qonoff_sem);
+ if (qinfo->qi_files[type] == NULL)
continue;
- }
+
CFS_INIT_LIST_HEAD(&id_list);
rc = fsfilt_qids(obd, qinfo->qi_files[type], NULL, type,
&id_list);
- cfs_up(&mds->mds_qonoff_sem);
-
if (rc)
CERROR("error get ids from admin quotafile.(%d)\n", rc);
OBD_FREE_PTR(dqid);
}
}
- class_decref(mds->mds_osc_obd, "qmaster_recovd_lov", mds->mds_osc_obd);
+ cfs_up_write(&mds->mds_qonoff_sem);
+ class_decref(mds->mds_lov_obd, "qmaster_recovd_lov", mds->mds_lov_obd);
class_decref(obd, "qmaster_recovd_mds", obd);
RETURN(rc);
}
int rc = 0;
ENTRY;
+ if (!ll_sb_any_quota_active(obd->u.obt.obt_qctxt.lqc_sb))
+ RETURN(0);
+
if (unlikely(!mds->mds_quota || obd->obd_stopping))
RETURN(rc);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff